From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A60F5C43217 for ; Mon, 25 Oct 2021 18:17:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88B2060F46 for ; Mon, 25 Oct 2021 18:17:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232476AbhJYSTX (ORCPT ); Mon, 25 Oct 2021 14:19:23 -0400 Received: from mail-oi1-f180.google.com ([209.85.167.180]:46960 "EHLO mail-oi1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231671AbhJYSTV (ORCPT ); Mon, 25 Oct 2021 14:19:21 -0400 Received: by mail-oi1-f180.google.com with SMTP id o204so16731923oih.13; Mon, 25 Oct 2021 11:16:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=c8iDrdrscM2c58XhHr9hAeNjE08nH97DcHB6REi5ScM=; b=MVMb4je/U+cCTo504rqWYnOqCy1cqJD+pgleJIqmP7nhjJ8YxrBp4+fXXe6FcXnBhl eJyBZoRgu6/2TOsL4tiHghjT/qxTJ/Isx06iwalEn96k++a6vFjvr12Mpkkfud775rNR J0tzTCqppreRmWpGt9IRh4ZirYb5OSiE6EskrTIyxMcG6S5GOwogXFYsFFzRh0Cdwr1J XpMKUM4xy5mwjLsMhc8F1eSlRGlJtfGCfhPVJNc0E90+hx+OqZrTbxeilM9Qxy0cRaVV a0mzk/q5g+g9+/SCKYNR45lm0cSs26UYaZpB/p2QVBbcZMPhBT5LwUygrFiMxi4n24UH BDWA== X-Gm-Message-State: AOAM5327t8cYkBEgpQimh6rHO9guNz6Pumh60zwfayQo6IhT8vNaNri8 mXXx5o5/OPn+X6ckz01+fA== X-Google-Smtp-Source: ABdhPJzt9UxcoWWAoSw1waWa4o7cP/4BdO3Lt0f7+VkpxhBaAKmqzO61CJbl9tB6ZxiVOi2kQsPn2g== X-Received: by 2002:a05:6808:158c:: with SMTP id t12mr23688907oiw.74.1635185817319; Mon, 25 Oct 2021 11:16:57 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id z8sm3050765oof.47.2021.10.25.11.16.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Oct 2021 11:16:56 -0700 (PDT) Received: (nullmailer pid 824870 invoked by uid 1000); Mon, 25 Oct 2021 18:16:53 -0000 From: Rob Herring To: Hector Martin Cc: Alyssa Rosenzweig , Mark Kettenis , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, Marc Zyngier , Linus Walleij , Mark Kettenis , Krzysztof Kozlowski , Arnd Bergmann , Philipp Zabel , Greg Kroah-Hartman , Rob Herring , Johan Hovold In-Reply-To: <20211025144718.157794-4-marcan@marcan.st> References: <20211025144718.157794-1-marcan@marcan.st> <20211025144718.157794-4-marcan@marcan.st> Subject: Re: [PATCH v2 3/8] dt-bindings: power: Add apple,pmgr-pwrstate binding Date: Mon, 25 Oct 2021 13:16:53 -0500 Message-Id: <1635185813.771483.824869.nullmailer@robh.at.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Oct 2021 23:47:13 +0900, Hector Martin wrote: > This syscon child node represents a single SoC device controlled by the > PMGR block. This layout allows us to declare all device power state > controls (power/clock gating and reset) in the device tree, including > dependencies, instead of hardcoding it into the driver. The register > layout is uniform. > > Each pmgr-pwrstate node provides genpd and reset features, to be > consumed by downstream device nodes. > > Future SoCs are expected to use backwards compatible registers, and the > "apple,pmgr-pwrstate" represents any such interfaces (possibly with > additional features gated by the more specific compatible), allowing > them to be bound without driver updates. If a backwards incompatible > change is introduced in future SoCs, it will require a new compatible, > such as "apple,pmgr-pwrstate-v2". > > Reviewed-by: Mark Kettenis > Signed-off-by: Hector Martin > --- > .../bindings/power/apple,pmgr-pwrstate.yaml | 69 +++++++++++++++++++ > 1 file changed, 69 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml: Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml See https://patchwork.ozlabs.org/patch/1545800 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41A65C433F5 for ; Mon, 25 Oct 2021 18:18:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B46E60E8F for ; Mon, 25 Oct 2021 18:18:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0B46E60E8F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject: References:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4/GuUMuBTNY35VhV1oiYEjKBJgwzDssiUhBc6tCH1Is=; b=18zXIaI/NpJME7 O4rzs1WCUs0uvwpTh4IRKoWgzSvLZ9a8g3SDk0F82iPvh/N9bLv44achLJc2CpnEjM7MYHBjoCf6/ Z4c1OO/a1CRZaDAJ82cwg1/unons4++KIU3EOAFPXUGHgbI+SS8yxfc9lLJImCsD98rKaYig6Jtm2 ykMphNor5+qvZ4YgLigaDA502KLXjca92W5VZFHqTaT5PPrMaKNpcRbzY+eufyB3AYRnDYqWy2AyN l2ucApd+c7CVL9GzrO+x89Itmk6FYBTlSrKNtTiGh4/Bjp56eG50yiXY9yuOH76rd0LFR/Kbyvhba 3VroMYPGP4zIGEivMtfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mf4Ws-00HJOf-5P; Mon, 25 Oct 2021 18:17:02 +0000 Received: from mail-oi1-f169.google.com ([209.85.167.169]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mf4Wp-00HJNe-8M for linux-arm-kernel@lists.infradead.org; Mon, 25 Oct 2021 18:17:00 +0000 Received: by mail-oi1-f169.google.com with SMTP id r6so16797443oiw.2 for ; Mon, 25 Oct 2021 11:16:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=c8iDrdrscM2c58XhHr9hAeNjE08nH97DcHB6REi5ScM=; b=eTGaLtkM+y/DyINK6Kiwb9RCcAK3HDvBn25tpotyQfTI8UOuMaYztqArtdT7lb9psG WI4Yo0wxmsr+xIbLqzkoU6I57K4uZEDBgnlUqp7nXktsa0N8l/n1FZCDlRjIDvk62Dy3 aRAh3P2NdsZ6MkxQmV1Zi6PWmB24no2uEwqdDE2tv/7jFPtvfmr1kC1lcItI9x86NSzT lWJ7c8yanJoQxNoKuxc5KiZpIP6DXXFL8ICxObEd09RuzYBQbENrzTnDiTfPXqTouTbu SXvnOhMeyZOHnfo9xkOL8OuL5XtNswa0c48eFcESwDCzmiSKgom7ksAjkoyOauDQoi1I itIw== X-Gm-Message-State: AOAM533f6VstvDzwVS59pH6nPX8PxuFKw3FhiCV4SQ6yP80yGnW+a+4L jOx8Ri/lcpt1Sm/1HWoyPA== X-Google-Smtp-Source: ABdhPJzt9UxcoWWAoSw1waWa4o7cP/4BdO3Lt0f7+VkpxhBaAKmqzO61CJbl9tB6ZxiVOi2kQsPn2g== X-Received: by 2002:a05:6808:158c:: with SMTP id t12mr23688907oiw.74.1635185817319; Mon, 25 Oct 2021 11:16:57 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id z8sm3050765oof.47.2021.10.25.11.16.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Oct 2021 11:16:56 -0700 (PDT) Received: (nullmailer pid 824870 invoked by uid 1000); Mon, 25 Oct 2021 18:16:53 -0000 From: Rob Herring To: Hector Martin Cc: Alyssa Rosenzweig , Mark Kettenis , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, Marc Zyngier , Linus Walleij , Mark Kettenis , Krzysztof Kozlowski , Arnd Bergmann , Philipp Zabel , Greg Kroah-Hartman , Rob Herring , Johan Hovold In-Reply-To: <20211025144718.157794-4-marcan@marcan.st> References: <20211025144718.157794-1-marcan@marcan.st> <20211025144718.157794-4-marcan@marcan.st> Subject: Re: [PATCH v2 3/8] dt-bindings: power: Add apple, pmgr-pwrstate binding Date: Mon, 25 Oct 2021 13:16:53 -0500 Message-Id: <1635185813.771483.824869.nullmailer@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211025_111659_320487_A99A29C3 X-CRM114-Status: GOOD ( 18.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 25 Oct 2021 23:47:13 +0900, Hector Martin wrote: > This syscon child node represents a single SoC device controlled by the > PMGR block. This layout allows us to declare all device power state > controls (power/clock gating and reset) in the device tree, including > dependencies, instead of hardcoding it into the driver. The register > layout is uniform. > > Each pmgr-pwrstate node provides genpd and reset features, to be > consumed by downstream device nodes. > > Future SoCs are expected to use backwards compatible registers, and the > "apple,pmgr-pwrstate" represents any such interfaces (possibly with > additional features gated by the more specific compatible), allowing > them to be bound without driver updates. If a backwards incompatible > change is introduced in future SoCs, it will require a new compatible, > such as "apple,pmgr-pwrstate-v2". > > Reviewed-by: Mark Kettenis > Signed-off-by: Hector Martin > --- > .../bindings/power/apple,pmgr-pwrstate.yaml | 69 +++++++++++++++++++ > 1 file changed, 69 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml: Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml See https://patchwork.ozlabs.org/patch/1545800 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel