From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA224C433F5 for ; Thu, 28 Oct 2021 01:59:23 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4CDE961130 for ; Thu, 28 Oct 2021 01:59:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4CDE961130 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 1243340576; Thu, 28 Oct 2021 01:59:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y95xg3x_ToGn; Thu, 28 Oct 2021 01:59:22 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id BD57C40485; Thu, 28 Oct 2021 01:59:21 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 94658C0012; Thu, 28 Oct 2021 01:59:21 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5048EC000E for ; Thu, 28 Oct 2021 01:59:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 37FB240518 for ; Thu, 28 Oct 2021 01:59:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MgAeFWT66ZJy for ; Thu, 28 Oct 2021 01:59:19 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from out30-42.freemail.mail.aliyun.com (out30-42.freemail.mail.aliyun.com [115.124.30.42]) by smtp4.osuosl.org (Postfix) with ESMTPS id B380640485 for ; Thu, 28 Oct 2021 01:59:18 +0000 (UTC) X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R201e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e04426; MF=xuanzhuo@linux.alibaba.com; NM=1; PH=DS; RN=6; SR=0; TI=SMTPD_---0Utx0X9O_1635386354; Received: from localhost(mailfrom:xuanzhuo@linux.alibaba.com fp:SMTPD_---0Utx0X9O_1635386354) by smtp.aliyun-inc.com(127.0.0.1); Thu, 28 Oct 2021 09:59:14 +0800 MIME-Version: 1.0 message-id: <1635386220.8124611-1-xuanzhuo@linux.alibaba.com> subject: Re: [PATCH 3/3] virtio-net: enable virtio indirect cache date: Thu, 28 Oct 2021 09:57:00 +0800 from: Xuan Zhuo to: Jakub Kicinski in-reply-to: <20211027085528.01c4b313@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Cc: netdev@vger.kernel.org, "Michael S. Tsirkin" , "David S. Miller" , virtualization@lists.linux-foundation.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Wed, 27 Oct 2021 08:55:28 -0700, Jakub Kicinski wrote: > On Wed, 27 Oct 2021 14:19:13 +0800 Xuan Zhuo wrote: > > +static bool virtio_desc_cache = true; > > module_param(csum, bool, 0444); > > module_param(gso, bool, 0444); > > module_param(napi_tx, bool, 0644); > > +module_param(virtio_desc_cache, bool, 0644); > > Can this be an ethtool priv flag? module params are discouraged because > they can't be controlled per-netdev. The current design can only be set when the device is initialized. So using ethtool to modify it will not work. Thanks. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization