From: Stephen Boyd <sboyd@kernel.org>
To: Horatiu Vultur <horatiu.vultur@microchip.com>,
mturquette@baylibre.com, robh+dt@kernel.org
Cc: nicolas.ferre@microchip.com, kavyasree.kotagiri@microchip.com,
eugen.hristev@microchip.com, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Horatiu Vultur <horatiu.vultur@microchip.com>
Subject: Re: [RFC PATCH 3/3] clk: lan966x: Extend lan966x clock driver for clock gating support
Date: Thu, 28 Oct 2021 23:41:57 -0700 [thread overview]
Message-ID: <163548971798.15791.952778566228263608@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20211019084449.1411060-4-horatiu.vultur@microchip.com>
Quoting Horatiu Vultur (2021-10-19 01:44:49)
> diff --git a/drivers/clk/clk-lan966x.c b/drivers/clk/clk-lan966x.c
> index 19bec94e1551..40be47092a31 100644
> --- a/drivers/clk/clk-lan966x.c
> +++ b/drivers/clk/clk-lan966x.c
> @@ -188,26 +202,64 @@ static struct clk_hw *lan966x_gck_clk_register(struct device *dev, int i)
> return &priv->hw;
> };
>
> +static int lan966x_gate_clk_register(struct device *dev,
> + struct clk_hw_onecell_data *hw_data,
> + void __iomem *gate_base)
> +{
> + int i;
> +
> + for (i = GCK_GATE_UHPHS; i < N_CLOCKS; ++i) {
> + int idx = i - GCK_GATE_UHPHS;
> +
> + hw_data->hws[i] =
> + clk_hw_register_gate(dev, clk_gate_desc[idx].name,
Use devm?
> + "lan966x", 0, base,
> + clk_gate_desc[idx].bit_idx,
> + 0, &clk_gate_lock);
> +
> + if (IS_ERR(hw_data->hws[i]))
> + return dev_err_probe(dev, PTR_ERR(hw_data->hws[i]),
> + "failed to register %s clock\n",
> + clk_gate_desc[idx].name);
> + }
> +
> + return 0;
> +}
> +
> +static void lan966x_gate_clk_unregister(struct clk_hw_onecell_data *hw_data)
> +{
> + int i;
> +
> + for (i = GCK_GATE_UHPHS; i < N_CLOCKS; ++i)
for (int i =
should suffice
> + if (!IS_ERR(hw_data->hws[i]))
> + clk_hw_unregister(hw_data->hws[i]);
> +}
> +
next prev parent reply other threads:[~2021-10-29 6:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 8:44 [RFC PATCH 0/3] Extend lan966x clock driver for clock gating support Horatiu Vultur
2021-10-19 8:44 ` [RFC PATCH 1/3] dt-bindings: clock: lan966x: Extend for clock gate support Horatiu Vultur
2021-10-27 3:08 ` Rob Herring
2021-10-29 12:06 ` Horatiu Vultur
2021-10-19 8:44 ` [RFC PATCH 2/3] dt-bindings: clock: lan966x: Extend includes with clock gates Horatiu Vultur
2021-10-27 3:09 ` Rob Herring
2021-10-19 8:44 ` [RFC PATCH 3/3] clk: lan966x: Extend lan966x clock driver for clock gating support Horatiu Vultur
2021-10-29 6:41 ` Stephen Boyd [this message]
2021-10-29 9:35 ` Horatiu Vultur
2021-10-29 23:32 ` Stephen Boyd
2021-10-31 9:03 ` Horatiu Vultur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163548971798.15791.952778566228263608@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eugen.hristev@microchip.com \
--cc=horatiu.vultur@microchip.com \
--cc=kavyasree.kotagiri@microchip.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.