All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
	Taniya Das <tdas@codeaurora.org>
Cc: Rajendra Nayak <rnayak@codeaurora.org>,
	linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, robh@kernel.org, robh+dt@kernel.org,
	Taniya Das <tdas@codeaurora.org>
Subject: Re: [PATCH v1 1/4] clk: qcom: clk-alpha-pll: Increase PLL lock detect poll time
Date: Tue, 02 Nov 2021 14:56:14 -0700	[thread overview]
Message-ID: <163589017472.2993099.8634048687805619874@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1635847013-3220-2-git-send-email-tdas@codeaurora.org>

Quoting Taniya Das (2021-11-02 02:56:50)
> PLL poll for lock detection can take more than 100us for certain type

What types of PLLs? Is this fixing something that's broken? Or fixing a
future problem?

> of PLLs, thus update to 200us.
> 

Does it needs a Fixes tag?

> Signed-off-by: Taniya Das <tdas@codeaurora.org>
> ---
>  drivers/clk/qcom/clk-alpha-pll.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c
> index eaedcce..7cf6cfa 100644
> --- a/drivers/clk/qcom/clk-alpha-pll.c
> +++ b/drivers/clk/qcom/clk-alpha-pll.c
> @@ -204,7 +204,7 @@ static int wait_for_pll(struct clk_alpha_pll *pll, u32 mask, bool inverse,
>         if (ret)
>                 return ret;
> 
> -       for (count = 100; count > 0; count--) {
> +       for (count = 200; count > 0; count--) {
>                 ret = regmap_read(pll->clkr.regmap, PLL_MODE(pll), &val);
>                 if (ret)

  reply	other threads:[~2021-11-02 21:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-02  9:56 [PATCH v1 0/4] Add support for LPASS Core and Audio Clock for SC7280 Taniya Das
2021-11-02  9:56 ` [PATCH v1 1/4] clk: qcom: clk-alpha-pll: Increase PLL lock detect poll time Taniya Das
2021-11-02 21:56   ` Stephen Boyd [this message]
2021-11-02  9:56 ` [PATCH v1 2/4] clk: qcom: gdsc: Add support for clock voting from GDSC Taniya Das
2021-11-02 21:58   ` Stephen Boyd
2021-11-02  9:56 ` [PATCH v1 3/4] dt-bindings: clock: Add YAML schemas for LPASS clocks on SC7280 Taniya Das
2021-11-02 12:38   ` Rob Herring
2021-11-02  9:56 ` [PATCH v1 4/4] clk: qcom: lpass: Add support for LPASS clock controller for SC7280 Taniya Das
2021-11-02 22:19   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=163589017472.2993099.8634048687805619874@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=rnayak@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=tdas@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.