From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gloria.sntech.de ([95.129.55.99]:49732 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964845AbeFRIUA (ORCPT ); Mon, 18 Jun 2018 04:20:00 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Marc Zyngier Cc: dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, ezequiel@collabora.com, tfiga@chromium.org, robin.murphy@arm.com, jeffy.chen@rock-chips.com, hjc@rock-chips.com, enric.balletbo@collabora.co.uk, tomeu.vizoso@collabora.co.uk, stable@vger.kernel.org Subject: Re: [PATCH v4 2/2] drm/rockchip: vop: fix irq disabled after vop driver probed Date: Mon, 18 Jun 2018 10:19:46 +0200 Message-ID: <1637509.0BUGQyR5Xn@diego> In-Reply-To: References: <20180612132028.27490-1-heiko@sntech.de> <20180612132028.27490-3-heiko@sntech.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: stable-owner@vger.kernel.org List-ID: Hi Marc, Am Mittwoch, 13. Juni 2018, 15:01:27 CEST schrieb Marc Zyngier: > On 12/06/18 14:20, Heiko Stuebner wrote: > > From: Sandy Huang > > > > The vop irq is shared between vop and iommu and irq probing in the > > iommu driver moved to the probe function recently. This can in some > > cases lead to a stall if the irq is triggered while the vop driver > > still has it disabled, but the vop irq handler gets called. > > > > But there is no real need to disable the irq, as the vop can simply > > also track its enabled state and ignore irqs in that case. > > For this we can simply check the power-domain state of the vop, > > similar to how the iommu driver does it. > > > > So remove the enable/disable handling and add appropriate condition > > to the irq handler. > > > > changes in v2: > > - move to just check the power-domain state > > - add clock handling > > changes in v3: > > - clarify comment to speak of runtime-pm not power-domain > > changes in v4: > > - address Marc's comments (clk-enable WARN_ON and style improvement) > > > > Fixes: d0b912bd4c23 ("iommu/rockchip: Request irqs in rk_iommu_probe()") > > Cc: stable@vger.kernel.org > > Signed-off-by: Sandy Huang > > Signed-off-by: Heiko Stuebner > > Tested-by: Ezequiel Garcia > > Reviewed-by: Marc Zyngier could I ask you to also look at patch1 of this series, to give it an Ack or Review? drm-misc documentation very strongly suggests [0] to have at least another set of eyes on a patch and so far noone came forward ;-) This of course also applies to everybody else in the Cc list :-D . Thanks Heiko [0] https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html#merge-criteria From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH v4 2/2] drm/rockchip: vop: fix irq disabled after vop driver probed Date: Mon, 18 Jun 2018 10:19:46 +0200 Message-ID: <1637509.0BUGQyR5Xn@diego> References: <20180612132028.27490-1-heiko@sntech.de> <20180612132028.27490-3-heiko@sntech.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Marc Zyngier Cc: robin.murphy@arm.com, jeffy.chen@rock-chips.com, dri-devel@lists.freedesktop.org, tfiga@chromium.org, linux-rockchip@lists.infradead.org, enric.balletbo@collabora.co.uk, stable@vger.kernel.org, tomeu.vizoso@collabora.co.uk, ezequiel@collabora.com List-Id: linux-rockchip.vger.kernel.org SGkgTWFyYywKCkFtIE1pdHR3b2NoLCAxMy4gSnVuaSAyMDE4LCAxNTowMToyNyBDRVNUIHNjaHJp ZWIgTWFyYyBaeW5naWVyOgo+IE9uIDEyLzA2LzE4IDE0OjIwLCBIZWlrbyBTdHVlYm5lciB3cm90 ZToKPiA+IEZyb206IFNhbmR5IEh1YW5nIDxoamNAcm9jay1jaGlwcy5jb20+Cj4gPiAKPiA+IFRo ZSB2b3AgaXJxIGlzIHNoYXJlZCBiZXR3ZWVuIHZvcCBhbmQgaW9tbXUgYW5kIGlycSBwcm9iaW5n IGluIHRoZQo+ID4gaW9tbXUgZHJpdmVyIG1vdmVkIHRvIHRoZSBwcm9iZSBmdW5jdGlvbiByZWNl bnRseS4gVGhpcyBjYW4gaW4gc29tZQo+ID4gY2FzZXMgbGVhZCB0byBhIHN0YWxsIGlmIHRoZSBp cnEgaXMgdHJpZ2dlcmVkIHdoaWxlIHRoZSB2b3AgZHJpdmVyCj4gPiBzdGlsbCBoYXMgaXQgZGlz YWJsZWQsIGJ1dCB0aGUgdm9wIGlycSBoYW5kbGVyIGdldHMgY2FsbGVkLgo+ID4gCj4gPiBCdXQg dGhlcmUgaXMgbm8gcmVhbCBuZWVkIHRvIGRpc2FibGUgdGhlIGlycSwgYXMgdGhlIHZvcCBjYW4g c2ltcGx5Cj4gPiBhbHNvIHRyYWNrIGl0cyBlbmFibGVkIHN0YXRlIGFuZCBpZ25vcmUgaXJxcyBp biB0aGF0IGNhc2UuCj4gPiBGb3IgdGhpcyB3ZSBjYW4gc2ltcGx5IGNoZWNrIHRoZSBwb3dlci1k b21haW4gc3RhdGUgb2YgdGhlIHZvcCwKPiA+IHNpbWlsYXIgdG8gaG93IHRoZSBpb21tdSBkcml2 ZXIgZG9lcyBpdC4KPiA+IAo+ID4gU28gcmVtb3ZlIHRoZSBlbmFibGUvZGlzYWJsZSBoYW5kbGlu ZyBhbmQgYWRkIGFwcHJvcHJpYXRlIGNvbmRpdGlvbgo+ID4gdG8gdGhlIGlycSBoYW5kbGVyLgo+ ID4gCj4gPiBjaGFuZ2VzIGluIHYyOgo+ID4gLSBtb3ZlIHRvIGp1c3QgY2hlY2sgdGhlIHBvd2Vy LWRvbWFpbiBzdGF0ZQo+ID4gLSBhZGQgY2xvY2sgaGFuZGxpbmcKPiA+IGNoYW5nZXMgaW4gdjM6 Cj4gPiAtIGNsYXJpZnkgY29tbWVudCB0byBzcGVhayBvZiBydW50aW1lLXBtIG5vdCBwb3dlci1k b21haW4KPiA+IGNoYW5nZXMgaW4gdjQ6Cj4gPiAtIGFkZHJlc3MgTWFyYydzIGNvbW1lbnRzIChj bGstZW5hYmxlIFdBUk5fT04gYW5kIHN0eWxlIGltcHJvdmVtZW50KQo+ID4gCj4gPiBGaXhlczog ZDBiOTEyYmQ0YzIzICgiaW9tbXUvcm9ja2NoaXA6IFJlcXVlc3QgaXJxcyBpbiBya19pb21tdV9w cm9iZSgpIikKPiA+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnCj4gPiBTaWduZWQtb2ZmLWJ5 OiBTYW5keSBIdWFuZyA8aGpjQHJvY2stY2hpcHMuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogSGVp a28gU3R1ZWJuZXIgPGhlaWtvQHNudGVjaC5kZT4KPiA+IFRlc3RlZC1ieTogRXplcXVpZWwgR2Fy Y2lhIDxlemVxdWllbEBjb2xsYWJvcmEuY29tPgo+IAo+IFJldmlld2VkLWJ5OiBNYXJjIFp5bmdp ZXIgPG1hcmMuenluZ2llckBhcm0uY29tPgoKY291bGQgSSBhc2sgeW91IHRvIGFsc28gbG9vayBh dCBwYXRjaDEgb2YgdGhpcyBzZXJpZXMsIHRvIGdpdmUgaXQgYW4KQWNrIG9yIFJldmlldz8gZHJt LW1pc2MgZG9jdW1lbnRhdGlvbiB2ZXJ5IHN0cm9uZ2x5IHN1Z2dlc3RzIFswXQp0byBoYXZlIGF0 IGxlYXN0IGFub3RoZXIgc2V0IG9mIGV5ZXMgb24gYSBwYXRjaCBhbmQgc28gZmFyIG5vb25lCmNh bWUgZm9yd2FyZCA7LSkKClRoaXMgb2YgY291cnNlIGFsc28gYXBwbGllcyB0byBldmVyeWJvZHkg ZWxzZSBpbiB0aGUgQ2MgbGlzdCA6LUQgLgoKClRoYW5rcwpIZWlrbwoKClswXSBodHRwczovLzAx Lm9yZy9saW51eGdyYXBoaWNzL2dmeC1kb2NzL21haW50YWluZXItdG9vbHMvZHJtLW1pc2MuaHRt bCNtZXJnZS1jcml0ZXJpYQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo=