From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBB6EC07E99 for ; Mon, 5 Jul 2021 17:58:30 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB85F61958 for ; Mon, 5 Jul 2021 17:58:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB85F61958 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 000DC82C0B; Mon, 5 Jul 2021 19:58:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1625507908; bh=sk/Qp79ud7pMIgPbrGbZgSLCCRQYutrMrNKocj3nqEg=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=CNXFWuFBGc9FrdqWtYxbtBD+hO4R7xUnkxuXStw47bk9haWltOcx2YnC19rTdNJna tPP1uDzW0HhC4DSvxtjnnVcv5bNLPbugWOLZOCSRcbXm1kRGwcqeBc8s6znalkzd4m yMxR9aPlS0SBIDJWr7Va7kgv+1v1EEawlkQJr8UaRMNQat1E3NihKBHZkvui9omyhL q1pFqje2yJtvzjDBuubAmtXEcBuLd9D6FwO3aCgkAOHgDM+GqHJc9WD7QlRAz/5Bus O084Lti8SLuuKvzjMaE4KWg7f6FCckbfe+II0NwCo1DTz1LKEa3LWcZphOoFS+q+Id +HgeTF2G7pteA== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id E663782C06 for ; Mon, 5 Jul 2021 19:58:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1625507906; bh=sk/Qp79ud7pMIgPbrGbZgSLCCRQYutrMrNKocj3nqEg=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=FXfn7l1p8Wn4tjggzLiWGjiVF8O2+VYZe/DhFUIWlKbZ1QwIB3MGYFE3DgTlVkOE0 NoiF7CGv3JQvFyHbsy1NnNBxCviOb0S2z6qTwB+hKIpJ7yxpPFvQpIr5xRQAWcFLIq Ifv1/7UAedIiNKSJ2dxRTte2KC+7dGGelWynO2tdDU6kpLQOzu62F/iicE1n33dw1q B+6BHVoxEduqpn3QPy3Ro5za1i/Cl2QiLVsmuuyG5U+2KnSdEqm5AoDP6spgVgK9Sk zTvqC972geIChfrq+l7tfPo1PVqC0xVI9b593ZyGaKqIt18VAosY8saq3jpkRxp/sG Q0Ve8SAV1RxpQ== Received: by janitor.denx.de (Postfix, from userid 108) id 6532AA02A4; Mon, 5 Jul 2021 19:58:26 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 8830DA003A; Mon, 5 Jul 2021 19:58:18 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 78C651E1498; Mon, 5 Jul 2021 19:58:18 +0200 (CEST) To: Sean Anderson cc: Simon Glass , U-Boot Mailing List , Tom Rini , =?UTF-8?Q?Marek_Beh=c3=ban?= , Roland Gaudig , Heinrich Schuchardt , Kostas Michalopoulos From: Wolfgang Denk Subject: Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: References: <20210701061611.957918-1-seanga2@gmail.com> <20210701061611.957918-6-seanga2@gmail.com> Comments: In-reply-to Sean Anderson message dated "Mon, 05 Jul 2021 11:54:30 -0400." Date: Mon, 05 Jul 2021 19:58:18 +0200 Message-ID: <163753.1625507898@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Sean, In message you wrote: > > > Is your intent to create a fork of this in U-Boot? > > Yes. I believe some of the major additions I have made (especially "[RFC > PATCH 21/28] cli: lil: Add a distinct parsing step") would not be > accepted by upstream. Ouch... > > Could we not update things upstream, at least as an option, to avoid > > carrying these patches? > > For some of the smaller patches, that may be possible. However, I am not > a fan of the major amount of ifdefs that Hush has. For something as core > as a shell, I think we should be free to make changes as we see fit > without worrying about how it will affect a hypothetical backport. I'm afraind I cannot understand your thinking. You complain that the existing port of hus has a number of severe limitations or bugs which have long been fixed upstream, but cannot be easily fixed in U-Boot because we essentially created an unmaintained fork - and as a cure, you recommend to do the same thing again, but this time intentionally and deliberately? If you had not apparently already invested a lot of effort into this thing I would assume you must be joking... To me such an approach is unacceptable. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de If a train station is a place where a train stops, then what's a workstation?