All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] arm, imx6: fix NOR/OneNAND boot mode mix-up
Date: Mon, 23 Jul 2018 10:48:57 +0200	[thread overview]
Message-ID: <1638b3f0-5c92-bfeb-0821-0e5b384351b0@denx.de> (raw)
In-Reply-To: <20180622051852.21840-1-jay.d.carlson@gmail.com>

Hi Jay,

On 22/06/2018 07:18, Jay Carlson wrote:
> This patch fixes the ordering of the EMI enum to match Table 8-8 in 
> the i.MX6ULL Reference Manual, and has been spot-checked in two other 
> i.MX reference manuals for accuracy.
> 
> Signed-off-by: Jay Carlson <jay.d.carlson@gmail.com>
> ---
>  arch/arm/include/asm/mach-imx/sys_proto.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/include/asm/mach-imx/sys_proto.h b/arch/arm/include/asm/mach-imx/sys_proto.h
> index d1d6cbc462..0acc3640f9 100644
> --- a/arch/arm/include/asm/mach-imx/sys_proto.h
> +++ b/arch/arm/include/asm/mach-imx/sys_proto.h
> @@ -63,8 +63,8 @@ enum imx6_bmode_serial_rom {
>  };
>  
>  enum imx6_bmode_emi {
> -	IMX6_BMODE_ONENAND,
>  	IMX6_BMODE_NOR,
> +	IMX6_BMODE_ONENAND
>  };
>  

I am not understanding which is the issue. The enum are just used in
switch() section as far as I know, and then the order is not so
important. Which is the issue / error you found ?

Best regards,
Stefano babic


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2018-07-23  8:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-22  5:18 [U-Boot] [PATCH v2] arm, imx6: fix NOR/OneNAND boot mode mix-up Jay Carlson
2018-07-23  8:48 ` Stefano Babic [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-05-25 17:38 Jay Carlson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1638b3f0-5c92-bfeb-0821-0e5b384351b0@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.