All of lore.kernel.org
 help / color / mirror / Atom feed
From: "tip-bot2 for Thomas Gleixner" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Juergen Gross <jgross@suse.com>, Jason Gunthorpe <jgg@nvidia.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: irq/msi] genirq/msi: Remove unused domain callbacks
Date: Thu, 09 Dec 2021 16:07:11 -0000	[thread overview]
Message-ID: <163906603144.11128.3225742767932206586.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20211126223824.322987915@linutronix.de>

The following commit has been merged into the irq/msi branch of tip:

Commit-ID:     1dd2c6a0817fd08f80dee75d7d3bd99a0c4b828d
Gitweb:        https://git.kernel.org/tip/1dd2c6a0817fd08f80dee75d7d3bd99a0c4b828d
Author:        Thomas Gleixner <tglx@linutronix.de>
AuthorDate:    Mon, 06 Dec 2021 23:27:29 +01:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Thu, 09 Dec 2021 11:52:20 +01:00

genirq/msi: Remove unused domain callbacks

No users and there is no need to grow them.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/20211126223824.322987915@linutronix.de
Link: https://lore.kernel.org/r/20211206210224.041777889@linutronix.de

---
 include/linux/msi.h | 11 ++++-------
 kernel/irq/msi.c    |  5 -----
 2 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/include/linux/msi.h b/include/linux/msi.h
index d43b946..4b962f7 100644
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -304,7 +304,6 @@ struct msi_domain_info;
  * @msi_free:		Domain specific function to free a MSI interrupts
  * @msi_check:		Callback for verification of the domain/info/dev data
  * @msi_prepare:	Prepare the allocation of the interrupts in the domain
- * @msi_finish:		Optional callback to finalize the allocation
  * @set_desc:		Set the msi descriptor for an interrupt
  * @handle_error:	Optional error handler if the allocation fails
  * @domain_alloc_irqs:	Optional function to override the default allocation
@@ -312,12 +311,11 @@ struct msi_domain_info;
  * @domain_free_irqs:	Optional function to override the default free
  *			function.
  *
- * @get_hwirq, @msi_init and @msi_free are callbacks used by
- * msi_create_irq_domain() and related interfaces
+ * @get_hwirq, @msi_init and @msi_free are callbacks used by the underlying
+ * irqdomain.
  *
- * @msi_check, @msi_prepare, @msi_finish, @set_desc and @handle_error
- * are callbacks used by msi_domain_alloc_irqs() and related
- * interfaces which are based on msi_desc.
+ * @msi_check, @msi_prepare, @handle_error and @set_desc are callbacks used by
+ * msi_domain_alloc/free_irqs().
  *
  * @domain_alloc_irqs, @domain_free_irqs can be used to override the
  * default allocation/free functions (__msi_domain_alloc/free_irqs). This
@@ -351,7 +349,6 @@ struct msi_domain_ops {
 	int		(*msi_prepare)(struct irq_domain *domain,
 				       struct device *dev, int nvec,
 				       msi_alloc_info_t *arg);
-	void		(*msi_finish)(msi_alloc_info_t *arg, int retval);
 	void		(*set_desc)(msi_alloc_info_t *arg,
 				    struct msi_desc *desc);
 	int		(*handle_error)(struct irq_domain *domain,
diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c
index a8a0dae..cd4fa26 100644
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -562,8 +562,6 @@ int __msi_domain_alloc_irqs(struct irq_domain *domain, struct device *dev,
 			ret = -ENOSPC;
 			if (ops->handle_error)
 				ret = ops->handle_error(domain, desc, ret);
-			if (ops->msi_finish)
-				ops->msi_finish(&arg, ret);
 			return ret;
 		}
 
@@ -573,9 +571,6 @@ int __msi_domain_alloc_irqs(struct irq_domain *domain, struct device *dev,
 		}
 	}
 
-	if (ops->msi_finish)
-		ops->msi_finish(&arg, 0);
-
 	can_reserve = msi_check_reservation_mode(domain, info, dev);
 
 	/*

  reply	other threads:[~2021-12-09 16:07 UTC|newest]

Thread overview: 184+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-27  1:18 [patch 00/22] genirq/msi, PCI/MSI: Spring cleaning - Part 1 Thomas Gleixner
2021-11-27  1:19 ` Thomas Gleixner
2021-11-27  1:19 ` Thomas Gleixner
2021-11-27  1:19 ` Thomas Gleixner
2021-11-27  1:18 ` Thomas Gleixner
2021-11-27  1:18 ` Thomas Gleixner
2021-11-27  1:18 ` [patch 01/22] powerpc/4xx: Remove MSI support which never worked Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18 ` [patch 02/22] PCI/MSI: Fix pci_irq_vector()/pci_irq_get_attinity() Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18 ` [patch 03/22] genirq/msi: Guard sysfs code Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18 ` [patch 04/22] genirq/msi: Remove unused domain callbacks Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-12-09 16:07   ` tip-bot2 for Thomas Gleixner [this message]
2021-11-27  1:18 ` [patch 05/22] genirq/msi: Fixup includes Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-29  7:33   ` Cédric Le Goater
2021-11-29  7:33     ` Cédric Le Goater
2021-11-29  7:33     ` Cédric Le Goater
2021-11-29 21:38     ` Thomas Gleixner
2021-11-29 21:38       ` Thomas Gleixner
2021-11-29 21:38       ` Thomas Gleixner
2021-11-30 21:48       ` Cédric Le Goater
2021-11-30 21:48         ` Cédric Le Goater
2021-11-30 21:48         ` Cédric Le Goater
2021-11-30 22:10         ` Thomas Gleixner
2021-11-30 22:10           ` Thomas Gleixner
2021-11-30 22:10           ` Thomas Gleixner
2021-11-30 22:41           ` Thomas Gleixner
2021-11-30 22:41             ` Thomas Gleixner
2021-11-30 22:41             ` Thomas Gleixner
2021-12-01  7:14             ` Cédric Le Goater
2021-12-01  7:14               ` Cédric Le Goater
2021-12-01  7:14               ` Cédric Le Goater
2021-12-01 10:48               ` Thomas Gleixner
2021-12-01 10:48                 ` Thomas Gleixner
2021-12-01 10:48                 ` Thomas Gleixner
2021-11-27  1:18 ` [patch 06/22] PCI/MSI: Make pci_msi_domain_write_msg() static Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18 ` [patch 07/22] PCI/MSI: Remove msi_desc_to_pci_sysdata() Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18 ` [patch 08/22] PCI/sysfs: Use pci_irq_vector() Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18 ` [patch 09/22] MIPS: Octeon: Use arch_setup_msi_irq() Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-29 10:21   ` Thomas Bogendoerfer
2021-11-29 10:21     ` Thomas Bogendoerfer
2021-11-29 10:21     ` Thomas Bogendoerfer
2021-11-27  1:18 ` [patch 10/22] genirq/msi, treewide: Use a named struct for PCI/MSI attributes Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-29  9:29   ` Kalle Valo
2021-11-29  9:29     ` Kalle Valo
2021-11-29  9:29     ` Kalle Valo
2021-11-27  1:18 ` [patch 11/22] x86/hyperv: Refactor hv_msi_domain_free_irqs() Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-12-02 14:36   ` Wei Liu
2021-12-02 14:36     ` Wei Liu
2021-12-02 14:36     ` Wei Liu
2021-11-27  1:18 ` [patch 12/22] PCI/MSI: Make arch_restore_msi_irqs() less horrible Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18 ` [patch 13/22] PCI/MSI: Cleanup include zoo Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18 ` [patch 14/22] PCI/MSI: Make msix_update_entries() smarter Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18 ` [patch 15/22] PCI/MSI: Move code into a separate directory Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18 ` [patch 16/22] PCI/MSI: Split out CONFIG_PCI_MSI independent part Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:18   ` Thomas Gleixner
2021-11-27  1:19 ` [patch 17/22] PCI/MSI: Split out !IRQDOMAIN code Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-29  7:47   ` Cédric Le Goater
2021-11-29  7:47     ` Cédric Le Goater
2021-11-29  7:47     ` Cédric Le Goater
2021-11-29  7:51   ` Cédric Le Goater
2021-11-29  7:51     ` Cédric Le Goater
2021-11-29  7:51     ` Cédric Le Goater
2021-11-27  1:19 ` [patch 18/22] PCI/MSI: Split out irqdomain code Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19 ` [patch 19/22] PCI/MSI: Sanitize MSIX table map handling Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19 ` [patch 20/22] PCI/MSI: Make pci_msi_domain_check_cap() static Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19 ` [patch 21/22] genirq/msi: Handle PCI/MSI allocation fail in core code Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19 ` [patch 22/22] PCI/MSI: Move descriptor counting on allocation fail to the legacy code Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-27  1:19   ` Thomas Gleixner
2021-11-28  0:08 ` [patch 00/22] genirq/msi, PCI/MSI: Spring cleaning - Part 1 Jason Gunthorpe
2021-11-28  0:08   ` Jason Gunthorpe
2021-11-28  0:08   ` Jason Gunthorpe
2021-11-28 11:15 ` Juergen Gross
2021-11-28 11:15   ` Juergen Gross
2021-11-28 11:15   ` Juergen Gross
2021-11-29  9:52 ` Cédric Le Goater
2021-11-29  9:52   ` Cédric Le Goater
2021-11-29  9:52   ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=163906603144.11128.3225742767932206586.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=jgg@nvidia.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.