Re: [PATCH v5 2/2] arm64: dts: renesas: r8a779a0: falcon-cpu: Add DSI display output

[Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>]

Quoting Geert Uytterhoeven (2021-12-14 10:49:15)
> Hi Kieran,
> 
> On Tue, Nov 30, 2021 at 5:43 PM Kieran Bingham
> <kieran.bingham+renesas@ideasonboard.com> wrote:
> > Provide the display output using the sn65dsi86 MIPI DSI bridge
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> 
> LGTM, so
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> i.e. will queue in renesas-devel for v5.17.
> 
> > --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi
> 
> > @@ -146,6 +190,41 @@ &i2c1 {
> >
> >         status = "okay";
> >         clock-frequency = <400000>;
> > +
> > +       sn65dsi86@2c {
> > +               compatible = "ti,sn65dsi86";
> > +               reg = <0x2c>;
> > +
> > +               clocks = <&sn65dsi86_refclk>;
> > +               clock-names = "refclk";
> > +
> > +               interrupt-parent = <&gpio1>;
> > +               interrupts = <24 IRQ_TYPE_LEVEL_HIGH>;
> 
> Does the driver use this interrupt, and is it triggered?

No, it does not currently, but I expect it can be made to do so. Which
is likely a next development task to adapt polling hotplug to interrupt
driven hotplug detection anyway, so I'll try that then.


> If yes, as GP1_24 == IRQ0, you can switch from a GPIO to an INTC_EX IRQ,
> (don't forget to configure pinctrl) and test the INTC_EX driver.
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds