From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 01/32] common/cpt: add common logging support Date: Mon, 08 Oct 2018 15:37:04 +0200 Message-ID: <1640090.FxR765Yp0Y@xps> References: <1536033560-21541-1-git-send-email-ajoseph@caviumnetworks.com> <2582518.r5GVpR4kJk@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Akhil Goyal , Pablo de Lara , Ankur Dwivedi , Jerin Jacob , Narayana Prasad , Murthy NSSR , Nithin Dabilpuram , Ragothaman Jayaraman , Srisivasubramanian S , Tejasree Kondoj To: "Joseph, Anoob" Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 7D5A1D0B2 for ; Mon, 8 Oct 2018 15:37:08 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/10/2018 15:07, Joseph, Anoob: > On 08-10-2018 17:57, Thomas Monjalon wrote: > > 05/10/2018 14:58, Anoob Joseph: > >> +Cavium OCTEON TX > >> +M: Anoob Joseph > >> +F: drivers/common/cpt/ > > What is the real wording for this device family? > > Sometimes I read OcteonTX with lowercases and no space, > > sometimes OCTEONTX without space, sometimes OCTEON TX. > > > > Another note: You should differentiate ethdev and cryptodev devices, > > at least in the maintainer file. > > We have nicvf, zipvf, ssovf, timvf. > OCTEON TX (with the space) is the registered name of the chip. nicvf, > zipvf, ssovf, timvf are all multiple blocks on the device and previous > drivers were named that way. CPT is the similar name for the crypto > block. Jerin is planning for a common naming convention for the blocks > on the same family. > > Different blocks would be named crypto_octeontx, event_octeontx etc, to > denote that they are all part of the same device. We had to omit the > space (between OCTEON & TX), since it would complicate the name for the > directories. > > OcteonTX is a wrong convention. It would be fixed going ahead. > > I suggest to add "crypto" to the name of this section. > This entry is already under "Crypto Drivers". So do we need a separate > mention of "crypto"? Yes I think it is better to add "crypto", especially for automated processing of this file, we should avoid to have two times the same section title.