From: Daniel Wagner <dwagner@suse.de>
To: linux-nvme@lists.infradead.org, James Smart <jsmart2021@gmail.com>
Cc: Daniel Wagner <dwagner@suse.de>
Subject: Re: [PATCH v2] nvme-cli: Make connect-all matching be case insensitive
Date: Tue, 21 Dec 2021 14:02:40 +0100 [thread overview]
Message-ID: <164009175251.30030.7452352641833716630.b4-ty@suse.de> (raw)
In-Reply-To: <20211217222022.30516-1-jsmart2021@gmail.com>
On Fri, 17 Dec 2021 14:20:22 -0800, James Smart wrote:
> The comparison routine that checks discovery controller traddr with a
> discovery log traddr uses a simple strncmp. For FC, which kicks off
> connect-all requests vay systemd, the nvme-fc transport will build
> traddr strings with lower case hexadecimal. Some FC discovery
> controllers return traddr strings with upper case hexadecimal. There
> was is no rqmt in the NVME-FC spec that it be upper or lower case.
> Given the case difference, the connect-all fails the match logic and
> doesn't connect to storage.
>
> [...]
Applied, thanks!
[1/1] nvme-cli: Make connect-all matching be case insensitive
commit: 1264c6323937c4a0342174fdd9be5a66ab1eaf24
Best regards,
--
Daniel Wagner <dwagner@suse.de>
prev parent reply other threads:[~2021-12-21 13:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 22:20 [PATCH v2] nvme-cli: Make connect-all matching be case insensitive James Smart
2021-12-21 13:02 ` Daniel Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164009175251.30030.7452352641833716630.b4-ty@suse.de \
--to=dwagner@suse.de \
--cc=jsmart2021@gmail.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.