All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm: bridge: it66121: Remove redundant check
@ 2022-01-14  6:40 ` Drew Davenport
  0 siblings, 0 replies; 6+ messages in thread
From: Drew Davenport @ 2022-01-14  6:40 UTC (permalink / raw)
  To: ple, narmstrong
  Cc: a.hajda, robert.foss, Laurent.pinchart, jonas, jernej.skrabec,
	airlied, daniel, dri-devel, linux-kernel, Drew Davenport

ctx->next_bridge is checked for NULL twice in a row. The second
conditional is redundant, so remove it.

Signed-off-by: Drew Davenport <ddavenport@chromium.org>
---
 drivers/gpu/drm/bridge/ite-it66121.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
index 06b59b422c69..69288cf894b9 100644
--- a/drivers/gpu/drm/bridge/ite-it66121.c
+++ b/drivers/gpu/drm/bridge/ite-it66121.c
@@ -936,9 +936,6 @@ static int it66121_probe(struct i2c_client *client,
 		return -EPROBE_DEFER;
 	}
 
-	if (!ctx->next_bridge)
-		return -EPROBE_DEFER;
-
 	i2c_set_clientdata(client, ctx);
 	mutex_init(&ctx->lock);
 
-- 
2.34.1.703.g22d0c6ccf7-goog


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] drm: bridge: it66121: Remove redundant check
@ 2022-01-14  6:40 ` Drew Davenport
  0 siblings, 0 replies; 6+ messages in thread
From: Drew Davenport @ 2022-01-14  6:40 UTC (permalink / raw)
  To: ple, narmstrong
  Cc: jonas, airlied, robert.foss, dri-devel, linux-kernel,
	jernej.skrabec, a.hajda, Laurent.pinchart, Drew Davenport

ctx->next_bridge is checked for NULL twice in a row. The second
conditional is redundant, so remove it.

Signed-off-by: Drew Davenport <ddavenport@chromium.org>
---
 drivers/gpu/drm/bridge/ite-it66121.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
index 06b59b422c69..69288cf894b9 100644
--- a/drivers/gpu/drm/bridge/ite-it66121.c
+++ b/drivers/gpu/drm/bridge/ite-it66121.c
@@ -936,9 +936,6 @@ static int it66121_probe(struct i2c_client *client,
 		return -EPROBE_DEFER;
 	}
 
-	if (!ctx->next_bridge)
-		return -EPROBE_DEFER;
-
 	i2c_set_clientdata(client, ctx);
 	mutex_init(&ctx->lock);
 
-- 
2.34.1.703.g22d0c6ccf7-goog


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm: bridge: it66121: Remove redundant check
  2022-01-14  6:40 ` Drew Davenport
@ 2022-01-14 10:48   ` Neil Armstrong
  -1 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2022-01-14 10:48 UTC (permalink / raw)
  To: Drew Davenport, ple
  Cc: a.hajda, robert.foss, Laurent.pinchart, jonas, jernej.skrabec,
	airlied, daniel, dri-devel, linux-kernel

On 14/01/2022 07:40, Drew Davenport wrote:
> ctx->next_bridge is checked for NULL twice in a row. The second
> conditional is redundant, so remove it.
> 
> Signed-off-by: Drew Davenport <ddavenport@chromium.org>
> ---
>  drivers/gpu/drm/bridge/ite-it66121.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
> index 06b59b422c69..69288cf894b9 100644
> --- a/drivers/gpu/drm/bridge/ite-it66121.c
> +++ b/drivers/gpu/drm/bridge/ite-it66121.c
> @@ -936,9 +936,6 @@ static int it66121_probe(struct i2c_client *client,
>  		return -EPROBE_DEFER;
>  	}
>  
> -	if (!ctx->next_bridge)
> -		return -EPROBE_DEFER;
> -
>  	i2c_set_clientdata(client, ctx);
>  	mutex_init(&ctx->lock);
>  
> 

Acked-by: Neil Armstrong <narmstrong@baylibre.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm: bridge: it66121: Remove redundant check
@ 2022-01-14 10:48   ` Neil Armstrong
  0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2022-01-14 10:48 UTC (permalink / raw)
  To: Drew Davenport, ple
  Cc: jonas, airlied, robert.foss, dri-devel, linux-kernel,
	jernej.skrabec, a.hajda, Laurent.pinchart

On 14/01/2022 07:40, Drew Davenport wrote:
> ctx->next_bridge is checked for NULL twice in a row. The second
> conditional is redundant, so remove it.
> 
> Signed-off-by: Drew Davenport <ddavenport@chromium.org>
> ---
>  drivers/gpu/drm/bridge/ite-it66121.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
> index 06b59b422c69..69288cf894b9 100644
> --- a/drivers/gpu/drm/bridge/ite-it66121.c
> +++ b/drivers/gpu/drm/bridge/ite-it66121.c
> @@ -936,9 +936,6 @@ static int it66121_probe(struct i2c_client *client,
>  		return -EPROBE_DEFER;
>  	}
>  
> -	if (!ctx->next_bridge)
> -		return -EPROBE_DEFER;
> -
>  	i2c_set_clientdata(client, ctx);
>  	mutex_init(&ctx->lock);
>  
> 

Acked-by: Neil Armstrong <narmstrong@baylibre.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm: bridge: it66121: Remove redundant check
  2022-01-14  6:40 ` Drew Davenport
@ 2022-01-14 10:51   ` Neil Armstrong
  -1 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2022-01-14 10:51 UTC (permalink / raw)
  To: Drew Davenport, ple
  Cc: Neil Armstrong, airlied, jernej.skrabec, robert.foss, daniel,
	a.hajda, jonas, Laurent.pinchart, dri-devel, linux-kernel

Hi,

On Thu, 13 Jan 2022 23:40:12 -0700, Drew Davenport wrote:
> ctx->next_bridge is checked for NULL twice in a row. The second
> conditional is redundant, so remove it.
> 
> 

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

[1/1] drm: bridge: it66121: Remove redundant check
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=1500296576464dd4f8f7ba409069591648f4e98c

-- 
Neil

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm: bridge: it66121: Remove redundant check
@ 2022-01-14 10:51   ` Neil Armstrong
  0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2022-01-14 10:51 UTC (permalink / raw)
  To: Drew Davenport, ple
  Cc: Neil Armstrong, airlied, dri-devel, jonas, linux-kernel,
	robert.foss, a.hajda, jernej.skrabec, Laurent.pinchart

Hi,

On Thu, 13 Jan 2022 23:40:12 -0700, Drew Davenport wrote:
> ctx->next_bridge is checked for NULL twice in a row. The second
> conditional is redundant, so remove it.
> 
> 

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

[1/1] drm: bridge: it66121: Remove redundant check
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=1500296576464dd4f8f7ba409069591648f4e98c

-- 
Neil

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-14 10:51 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-14  6:40 [PATCH] drm: bridge: it66121: Remove redundant check Drew Davenport
2022-01-14  6:40 ` Drew Davenport
2022-01-14 10:48 ` Neil Armstrong
2022-01-14 10:48   ` Neil Armstrong
2022-01-14 10:51 ` Neil Armstrong
2022-01-14 10:51   ` Neil Armstrong

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.