From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0191DC433EF for ; Fri, 14 Jan 2022 11:30:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240793AbiANLaM (ORCPT ); Fri, 14 Jan 2022 06:30:12 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:52974 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230218AbiANLaM (ORCPT ); Fri, 14 Jan 2022 06:30:12 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 702EC61F14 for ; Fri, 14 Jan 2022 11:30:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id C5872C36AF3; Fri, 14 Jan 2022 11:30:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642159810; bh=sLsNgaqjW2U6QlzM5RG4QTdUVssGVZWYI4cf4SQFWqk=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=XR9Z1B2E74UGtdE+M5sopu//rN3GfyFRFzEcXV7EOuHB5lHocmdc57SHb7iYpm8Ja GXgSEF8BKE0RbK9XwFKi7rWpdhUGZcantf3YWYmgT9OgIIvKlQeFAkFXB7KAdVrzVz hFuJM3UKC3I5CEIGaAfL8UorD3+ntXhs184LvvPlGWq4LZq6mIZGTr3z2rh776Tz1k JmscimOriGXMvSaPCkwFdhUPB0AJcirRLpl8Id0wFuyAx87YfhWRrsZrASXa5gFd4e ZG9OitXh262rDZwPBsnvRnlKoxQhAEG7ls0YcDmxg6MXsYSQbpr3ZQX+/dfGAK9QfK XPteBv0PUnzEA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 8DE9DF607A0; Fri, 14 Jan 2022 11:30:10 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] net: apple: mace: Fix build since dev_addr constification From: patchwork-bot+netdevbpf@kernel.org Message-Id: <164215981057.30922.17945470510196780677.git-patchwork-notify@kernel.org> Date: Fri, 14 Jan 2022 11:30:10 +0000 References: <20220114031252.2419042-1-mpe@ellerman.id.au> In-Reply-To: <20220114031252.2419042-1-mpe@ellerman.id.au> To: Michael Ellerman Cc: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net, linuxppc-dev@lists.ozlabs.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Fri, 14 Jan 2022 14:12:52 +1100 you wrote: > Since commit adeef3e32146 ("net: constify netdev->dev_addr") the mace > driver no longer builds with various errors (pmac32_defconfig): > > linux/drivers/net/ethernet/apple/mace.c: In function ‘mace_probe’: > linux/drivers/net/ethernet/apple/mace.c:170:20: error: assignment of read-only location ‘*(dev->dev_addr + (sizetype)j)’ > 170 | dev->dev_addr[j] = rev ? bitrev8(addr[j]): addr[j]; > | ^ > linux/drivers/net/ethernet/apple/mace.c: In function ‘mace_reset’: > linux/drivers/net/ethernet/apple/mace.c:349:32: warning: passing argument 2 of ‘__mace_set_address’ discards ‘const’ qualifier from pointer target type > 349 | __mace_set_address(dev, dev->dev_addr); > | ~~~^~~~~~~~~~ > linux/drivers/net/ethernet/apple/mace.c:93:62: note: expected ‘void *’ but argument is of type ‘const unsigned char *’ > 93 | static void __mace_set_address(struct net_device *dev, void *addr); > | ~~~~~~^~~~ > linux/drivers/net/ethernet/apple/mace.c: In function ‘__mace_set_address’: > linux/drivers/net/ethernet/apple/mace.c:388:36: error: assignment of read-only location ‘*(dev->dev_addr + (sizetype)i)’ > 388 | out_8(&mb->padr, dev->dev_addr[i] = p[i]); > | ^ > > [...] Here is the summary with links: - net: apple: mace: Fix build since dev_addr constification https://git.kernel.org/netdev/net/c/6c8dc12cd925 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC294C433F5 for ; Fri, 14 Jan 2022 11:31:32 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4JZzdv4R0gz3bbk for ; Fri, 14 Jan 2022 22:31:31 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=XR9Z1B2E; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4601:e00::1; helo=ams.source.kernel.org; envelope-from=patchwork-bot+netdevbpf@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=XR9Z1B2E; dkim-atps=neutral Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4JZzcS4HzXz2y8P for ; Fri, 14 Jan 2022 22:30:16 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AC7E7B825CB; Fri, 14 Jan 2022 11:30:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id C5872C36AF3; Fri, 14 Jan 2022 11:30:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642159810; bh=sLsNgaqjW2U6QlzM5RG4QTdUVssGVZWYI4cf4SQFWqk=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=XR9Z1B2E74UGtdE+M5sopu//rN3GfyFRFzEcXV7EOuHB5lHocmdc57SHb7iYpm8Ja GXgSEF8BKE0RbK9XwFKi7rWpdhUGZcantf3YWYmgT9OgIIvKlQeFAkFXB7KAdVrzVz hFuJM3UKC3I5CEIGaAfL8UorD3+ntXhs184LvvPlGWq4LZq6mIZGTr3z2rh776Tz1k JmscimOriGXMvSaPCkwFdhUPB0AJcirRLpl8Id0wFuyAx87YfhWRrsZrASXa5gFd4e ZG9OitXh262rDZwPBsnvRnlKoxQhAEG7ls0YcDmxg6MXsYSQbpr3ZQX+/dfGAK9QfK XPteBv0PUnzEA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 8DE9DF607A0; Fri, 14 Jan 2022 11:30:10 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] net: apple: mace: Fix build since dev_addr constification From: patchwork-bot+netdevbpf@kernel.org Message-Id: <164215981057.30922.17945470510196780677.git-patchwork-notify@kernel.org> Date: Fri, 14 Jan 2022 11:30:10 +0000 References: <20220114031252.2419042-1-mpe@ellerman.id.au> In-Reply-To: <20220114031252.2419042-1-mpe@ellerman.id.au> To: Michael Ellerman X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net, kuba@kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Fri, 14 Jan 2022 14:12:52 +1100 you wrote: > Since commit adeef3e32146 ("net: constify netdev->dev_addr") the mace > driver no longer builds with various errors (pmac32_defconfig): > > linux/drivers/net/ethernet/apple/mace.c: In function ‘mace_probe’: > linux/drivers/net/ethernet/apple/mace.c:170:20: error: assignment of read-only location ‘*(dev->dev_addr + (sizetype)j)’ > 170 | dev->dev_addr[j] = rev ? bitrev8(addr[j]): addr[j]; > | ^ > linux/drivers/net/ethernet/apple/mace.c: In function ‘mace_reset’: > linux/drivers/net/ethernet/apple/mace.c:349:32: warning: passing argument 2 of ‘__mace_set_address’ discards ‘const’ qualifier from pointer target type > 349 | __mace_set_address(dev, dev->dev_addr); > | ~~~^~~~~~~~~~ > linux/drivers/net/ethernet/apple/mace.c:93:62: note: expected ‘void *’ but argument is of type ‘const unsigned char *’ > 93 | static void __mace_set_address(struct net_device *dev, void *addr); > | ~~~~~~^~~~ > linux/drivers/net/ethernet/apple/mace.c: In function ‘__mace_set_address’: > linux/drivers/net/ethernet/apple/mace.c:388:36: error: assignment of read-only location ‘*(dev->dev_addr + (sizetype)i)’ > 388 | out_8(&mb->padr, dev->dev_addr[i] = p[i]); > | ^ > > [...] Here is the summary with links: - net: apple: mace: Fix build since dev_addr constification https://git.kernel.org/netdev/net/c/6c8dc12cd925 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html