From: Kalle Valo <kvalo@kernel.org>
To: davidcomponentone@gmail.com
Cc: m@bues.ch, davidcomponentone@gmail.com,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Yang Guang <yang.guang5@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] ssb: fix boolreturn.cocci warning
Date: Tue, 1 Feb 2022 12:26:05 +0000 (UTC) [thread overview]
Message-ID: <164371836390.16633.773589948034456813.kvalo@kernel.org> (raw)
In-Reply-To: <fa4f1fa737e715eb62a85229ac5f12bae21145cf.1642065490.git.davidcomponentone@gmail.com>
davidcomponentone@gmail.com wrote:
> From: Yang Guang <yang.guang5@zte.com.cn>
>
> The coccinelle report
> ./include/linux/ssb/ssb_driver_gige.h:98:8-9:
> WARNING: return of 0/1 in function
> 'ssb_gige_must_flush_posted_writes' with return type bool
>
> Return statements in functions returning bool should use true/false
> instead of 1/0.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
> Signed-off-by: David Yang <davidcomponentone@gmail.com>
Patch applied to wireless-next.git, thanks.
6d3ac94bae21 ssb: fix boolreturn.cocci warning
--
https://patchwork.kernel.org/project/linux-wireless/patch/fa4f1fa737e715eb62a85229ac5f12bae21145cf.1642065490.git.davidcomponentone@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2022-02-01 12:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 0:11 [PATCH] ssb: fix boolreturn.cocci warning davidcomponentone
2022-02-01 12:26 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164371836390.16633.773589948034456813.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=davidcomponentone@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=m@bues.ch \
--cc=yang.guang5@zte.com.cn \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.