All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Damato <jdamato@fastly.com>
To: netdev@vger.kernel.org, kuba@kernel.org,
	ilias.apalodimas@linaro.org, davem@davemloft.net,
	hawk@kernel.org, saeed@kernel.org, ttoukan.linux@gmail.com,
	brouer@redhat.com
Cc: Joe Damato <jdamato@fastly.com>
Subject: [net-next v4 10/11] page_pool: Add a stat tracking waived pages
Date: Thu,  3 Feb 2022 16:09:32 -0800	[thread overview]
Message-ID: <1643933373-6590-11-git-send-email-jdamato@fastly.com> (raw)
In-Reply-To: <1643933373-6590-1-git-send-email-jdamato@fastly.com>

Track how often pages obtained from the ring cannot be added to the cache
because of a NUMA mismatch.

Signed-off-by: Joe Damato <jdamato@fastly.com>
---
 include/net/page_pool.h | 1 +
 net/core/page_pool.c    | 1 +
 2 files changed, 2 insertions(+)

diff --git a/include/net/page_pool.h b/include/net/page_pool.h
index 65cd0ca..bb87706 100644
--- a/include/net/page_pool.h
+++ b/include/net/page_pool.h
@@ -150,6 +150,7 @@ struct page_pool_stats {
 			    * slow path allocation
 			    */
 		u64 refill; /* allocations via successful refill */
+		u64 waive;  /* failed refills due to numa zone mismatch */
 	} alloc;
 };
 #endif
diff --git a/net/core/page_pool.c b/net/core/page_pool.c
index 4fe48ec..0bd084c 100644
--- a/net/core/page_pool.c
+++ b/net/core/page_pool.c
@@ -166,6 +166,7 @@ static struct page *page_pool_refill_alloc_cache(struct page_pool *pool)
 			 * This limit stress on page buddy alloactor.
 			 */
 			page_pool_return_page(pool, page);
+			this_cpu_inc_alloc_stat(pool, waive);
 			page = NULL;
 			break;
 		}
-- 
2.7.4


  parent reply	other threads:[~2022-02-04  0:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-04  0:09 [net-next v4 00/11] page_pool: Add page_pool stat counters Joe Damato
2022-02-04  0:09 ` [net-next v4 01/11] page_pool: kconfig: Add flag for page pool stats Joe Damato
2022-02-04  7:42   ` Ilias Apalodimas
2022-02-04 17:59     ` Joe Damato
2022-02-04  0:09 ` [net-next v4 02/11] page_pool: Add per-pool-per-cpu struct Joe Damato
2022-02-04  0:09 ` [net-next v4 03/11] page_pool: Allocate and free stats structure Joe Damato
2022-02-04  0:09 ` [net-next v4 04/11] page_pool: Add macro for incrementing alloc stats Joe Damato
2022-02-04  0:09 ` [net-next v4 05/11] page_pool: Add fast path stat Joe Damato
2022-02-04  0:09 ` [net-next v4 06/11] page_pool: Add slow path order-0 stat Joe Damato
2022-02-04  0:09 ` [net-next v4 07/11] page_pool: Add slow path high order alloc stat Joe Damato
2022-02-04  0:09 ` [net-next v4 08/11] page_pool: Add stat tracking empty ring Joe Damato
2022-02-04  0:09 ` [net-next v4 09/11] page_pool: Add stat tracking cache refill Joe Damato
2022-02-04  0:09 ` Joe Damato [this message]
2022-02-04  7:44   ` [net-next v4 10/11] page_pool: Add a stat tracking waived pages Ilias Apalodimas
2022-02-04 17:59     ` Joe Damato
2022-02-04  0:09 ` [net-next v4 11/11] page_pool: Add function to batch and return stats Joe Damato
2022-02-04  7:46   ` Ilias Apalodimas
2022-02-04 18:00     ` Joe Damato
2022-02-04 13:58 ` [net-next v4 00/11] page_pool: Add page_pool stat counters Toke Høiland-Jørgensen
2022-02-04 18:04   ` Joe Damato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1643933373-6590-11-git-send-email-jdamato@fastly.com \
    --to=jdamato@fastly.com \
    --cc=brouer@redhat.com \
    --cc=davem@davemloft.net \
    --cc=hawk@kernel.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=saeed@kernel.org \
    --cc=ttoukan.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.