From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A125C433F5 for ; Tue, 8 Feb 2022 10:51:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RbEvrgrbefqqmZTstZX6V3FIkgAma1WSP3140U5Ihmw=; b=rzpcKOOCMVDI/u ZZho0elL04FHeiH5IfMTjCvSO3QMrcdYusSUopAShls6viqPH7vc28+sMB7KD1GjFYl845OLZ90sC 554VxBrsVCPEp6MXjLyTLNgTpdh/A7XjqH8YEwjmruzZobRxev46qHGbZVsegDrHE2IswLuV/u3Is OiL07560JWqrhWr+gZPHg9tTjrQ9U9rOKW8mJzPyAJcNDu8Sm4vyS3vHJsZR3Qc07rC6DKAbIgvGN efbaWorWdLk2wOfEUDoCXtPDrzmbm2WnbuBf3WWPgjUMjRBYaVy9KwjADPqpeLXLFiaZa/gE+jP6y UqYV4QQe5RegeYAIWUlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHO4y-00DSWV-1c; Tue, 08 Feb 2022 10:50:36 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHO4n-00DSQh-A8 for linux-arm-kernel@lists.infradead.org; Tue, 08 Feb 2022 10:50:27 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5864C11D4; Tue, 8 Feb 2022 02:50:22 -0800 (PST) Received: from e123427-lin.arm.com (unknown [10.57.37.38]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3D7873F73B; Tue, 8 Feb 2022 02:50:21 -0800 (PST) From: Lorenzo Pieralisi To: =?UTF-8?q?Marek=20Beh=C3=BAn?= , Bjorn Helgaas , Marc Zyngier Cc: Lorenzo Pieralisi , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, pali@kernel.org Subject: Re: (subset) [PATCH v2 00/23] PCI: aardvark controller fixes BATCH 4 Date: Tue, 8 Feb 2022 10:50:13 +0000 Message-Id: <164431738306.20265.453911406614125295.b4-ty@arm.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20220110015018.26359-1-kabel@kernel.org> References: <20220110015018.26359-1-kabel@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220208_025025_501040_06735898 X-CRM114-Status: UNSURE ( 9.37 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAxMCBKYW4gMjAyMiAwMjo0OTo1NSArMDEwMCwgTWFyZWsgQmVow7puIHdyb3RlOgo+ IHRoaXMgaXMgdjIgb2YgZm91cnRoIGJhdGNoIG9mIGZpeGVzIGZvciB0aGUgQWFyZHZhcmsgUENJ ZSBjb250cm9sbGVyCj4gZHJpdmVyLgo+IAo+IFN0dWZmIGlzIGNvbnZlcnRlZCB0byBuZXcgaW50 ZXJydXB0IEFQSXMgYW5kIHJlY29tbWVuZGF0aW9ucyBmcm9tIE1hcmMuCj4gTWFyYywgY291bGQg eW91IGxvb2sgYXQgdGhlc2UgYW5kIGFja25vd2xlZGdlIG9yIGNvbW1lbnQ/Cj4gCj4gVGhpcyBz ZXJpZXMgbWFpbmx5IGZpeGVzIGFuZCBhZGRzIHN1cHBvcnQgZm9yIHN0dWZmIGFyb3VuZCBpbnRl cnJ1cHRzOgo+IHRoZSBtb3N0IGltcG9ydGFudCB0aGluZyBpcyBmaXhpbmcgTVNJIHN1cHBvcnQu Cj4gCj4gWy4uLl0KCkFwcGxpZWQgdG8gcGNpL2FhcmR2YXJrLCB0aGFua3MhCgpbMDEvMjNdIFBD STogYWFyZHZhcms6IFJlcGxhY2UgY3VzdG9tIFBDSUVfQ09SRV9JTlRfKiBtYWNyb3Mgd2l0aCBQ Q0lfSU5URVJSVVBUXyoKICAgICAgICBodHRwczovL2dpdC5rZXJuZWwub3JnL2xwaWVyYWxpc2kv cGNpL2MvMWQ4NmFiZjFmOApbMDIvMjNdIFBDSTogYWFyZHZhcms6IEZpeCByZWFkaW5nIE1TSSBp bnRlcnJ1cHQgbnVtYmVyCiAgICAgICAgaHR0cHM6Ly9naXQua2VybmVsLm9yZy9scGllcmFsaXNp L3BjaS9jLzgwNWRmYzE4ZGQKWzAzLzIzXSBQQ0k6IGFhcmR2YXJrOiBGaXggc3VwcG9ydCBmb3Ig TVNJIGludGVycnVwdHMKICAgICAgICBodHRwczovL2dpdC5rZXJuZWwub3JnL2xwaWVyYWxpc2kv cGNpL2MvYjBiMGI4Yjg5NwpbMDQvMjNdIFBDSTogYWFyZHZhcms6IFJld3JpdGUgSVJRIGNvZGUg dG8gY2hhaW5lZCBJUlEgaGFuZGxlcgogICAgICAgIGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvbHBp ZXJhbGlzaS9wY2kvYy8xNTcxZDY3ZGMxClswNS8yM10gUENJOiBhYXJkdmFyazogQ2hlY2sgcmV0 dXJuIHZhbHVlIG9mIGdlbmVyaWNfaGFuZGxlX2RvbWFpbl9pcnEoKSB3aGVuIHByb2Nlc3Npbmcg SU5UeCBJUlEKICAgICAgICBodHRwczovL2dpdC5rZXJuZWwub3JnL2xwaWVyYWxpc2kvcGNpL2Mv NTFmOTZlMjg3YwpbMDYvMjNdIFBDSTogYWFyZHZhcms6IE1ha2UgTVNJIGlycV9jaGlwIHN0cnVj dHVyZXMgc3RhdGljIGRyaXZlciBzdHJ1Y3R1cmVzCiAgICAgICAgaHR0cHM6Ly9naXQua2VybmVs Lm9yZy9scGllcmFsaXNpL3BjaS9jL2MzY2I4ZTUxODMKWzA3LzIzXSBQQ0k6IGFhcmR2YXJrOiBN YWtlIG1zaV9kb21haW5faW5mbyBzdHJ1Y3R1cmUgYSBzdGF0aWMgZHJpdmVyIHN0cnVjdHVyZQog ICAgICAgIGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvbHBpZXJhbGlzaS9wY2kvYy8yNmJjZDU0ZTRh ClswOC8yM10gUENJOiBhYXJkdmFyazogVXNlIGRldl9md25vZGUoKSBpbnN0ZWFkIG9mIG9mX25v ZGVfdG9fZndub2RlKGRldi0+b2Zfbm9kZSkKICAgICAgICBodHRwczovL2dpdC5rZXJuZWwub3Jn L2xwaWVyYWxpc2kvcGNpL2MvMjIyYWY3ODUzMgpbMDkvMjNdIFBDSTogYWFyZHZhcms6IFJlZmFj dG9yIHVubWFza2luZyBzdW1tYXJ5IE1TSSBpbnRlcnJ1cHQKICAgICAgICBodHRwczovL2dpdC5r ZXJuZWwub3JnL2xwaWVyYWxpc2kvcGNpL2MvNDY4OWMwOTE2MwpbMTAvMjNdIFBDSTogYWFyZHZh cms6IEFkZCBzdXBwb3J0IGZvciBtYXNraW5nIE1TSSBpbnRlcnJ1cHRzCiAgICAgICAgaHR0cHM6 Ly9naXQua2VybmVsLm9yZy9scGllcmFsaXNpL3BjaS9jL2U3N2Q5YzkwNjkKWzExLzIzXSBQQ0k6 IGFhcmR2YXJrOiBGaXggc2V0dGluZyBNU0kgYWRkcmVzcwogICAgICAgIGh0dHBzOi8vZ2l0Lmtl cm5lbC5vcmcvbHBpZXJhbGlzaS9wY2kvYy80NmFkM2RjNDE3ClsxMi8yM10gUENJOiBhYXJkdmFy azogRW5hYmxlIE1TSS1YIHN1cHBvcnQKICAgICAgICBodHRwczovL2dpdC5rZXJuZWwub3JnL2xw aWVyYWxpc2kvcGNpL2MvNzU0ZTQ0OTg4OQpbMTMvMjNdIFBDSTogYWFyZHZhcms6IEFkZCBzdXBw b3J0IGZvciBFUlIgaW50ZXJydXB0IG9uIGVtdWxhdGVkIGJyaWRnZQogICAgICAgIGh0dHBzOi8v Z2l0Lmtlcm5lbC5vcmcvbHBpZXJhbGlzaS9wY2kvYy8zZWJmZWZhMzk2ClsxNC8yM10gUENJOiBh YXJkdmFyazogRml4IHJlYWRpbmcgUENJX0VYUF9SVFNUQV9QTUUgYml0IG9uIGVtdWxhdGVkIGJy aWRnZQogICAgICAgIGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvbHBpZXJhbGlzaS9wY2kvYy83MzVm NWFlNDllClsxNS8yM10gUENJOiBhYXJkdmFyazogT3B0aW1pemUgd3JpdGluZyBQQ0lfRVhQX1JU Q1RMX1BNRUlFIGFuZCBQQ0lfRVhQX1JUU1RBX1BNRSBvbiBlbXVsYXRlZCBicmlkZ2UKICAgICAg ICBodHRwczovL2dpdC5rZXJuZWwub3JnL2xwaWVyYWxpc2kvcGNpL2MvNzEyMmJjYjMzMgpbMTYv MjNdIFBDSTogYWFyZHZhcms6IEFkZCBzdXBwb3J0IGZvciBQTUUgaW50ZXJydXB0cwogICAgICAg IGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvbHBpZXJhbGlzaS9wY2kvYy8wZmM3NWQ4NzQ1ClsxNy8y M10gUENJOiBhYXJkdmFyazogRml4IHN1cHBvcnQgZm9yIFBNRSByZXF1ZXN0ZXIgb24gZW11bGF0 ZWQgYnJpZGdlCiAgICAgICAgaHR0cHM6Ly9naXQua2VybmVsLm9yZy9scGllcmFsaXNpL3BjaS9j LzI3M2RkZDg2ZDYKWzE4LzIzXSBQQ0k6IGFhcmR2YXJrOiBVc2Ugc2VwYXJhdGUgSU5UQSBpbnRl cnJ1cHQgZm9yIGVtdWxhdGVkIHJvb3QgYnJpZGdlCiAgICAgICAgaHR0cHM6Ly9naXQua2VybmVs Lm9yZy9scGllcmFsaXNpL3BjaS9jLzgxNWJjMzEzNjgKWzE5LzIzXSBQQ0k6IGFhcmR2YXJrOiBS ZW1vdmUgaXJxX21hc2tfYWNrIGNhbGxiYWNrIGZvciBJTlR4IGludGVycnVwdHMKICAgICAgICBo dHRwczovL2dpdC5rZXJuZWwub3JnL2xwaWVyYWxpc2kvcGNpL2MvYjA4ZTViNTNkMQpbMjAvMjNd IFBDSTogYWFyZHZhcms6IERvbid0IG1hc2sgaXJxIHdoZW4gbWFwcGluZwogICAgICAgIGh0dHBz Oi8vZ2l0Lmtlcm5lbC5vcmcvbHBpZXJhbGlzaS9wY2kvYy9iZWZhNzEwMDAxClsyMS8yM10gUENJ OiBhYXJkdmFyazogRHJvcCBfX21heWJlX3VudXNlZCBmcm9tIGFkdmtfcGNpZV9kaXNhYmxlX3Bo eSgpCiAgICAgICAgaHR0cHM6Ly9naXQua2VybmVsLm9yZy9scGllcmFsaXNpL3BjaS9jLzBjMzZh YjQzN2UKWzIyLzIzXSBQQ0k6IGFhcmR2YXJrOiBVcGRhdGUgY29tbWVudCBhYm91dCBsaW5rIGdv aW5nIGRvd24gYWZ0ZXIgbGluay11cAogICAgICAgIGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvbHBp ZXJhbGlzaS9wY2kvYy85MmY0ZmZlY2M0CgpUaGFua3MsCkxvcmVuem8KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D8F7C4167D for ; Tue, 8 Feb 2022 11:31:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245360AbiBHLbi (ORCPT ); Tue, 8 Feb 2022 06:31:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356513AbiBHKuY (ORCPT ); Tue, 8 Feb 2022 05:50:24 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E1AC6C03FEC0 for ; Tue, 8 Feb 2022 02:50:22 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5864C11D4; Tue, 8 Feb 2022 02:50:22 -0800 (PST) Received: from e123427-lin.arm.com (unknown [10.57.37.38]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3D7873F73B; Tue, 8 Feb 2022 02:50:21 -0800 (PST) From: Lorenzo Pieralisi To: =?UTF-8?q?Marek=20Beh=C3=BAn?= , Bjorn Helgaas , Marc Zyngier Cc: Lorenzo Pieralisi , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, pali@kernel.org Subject: Re: (subset) [PATCH v2 00/23] PCI: aardvark controller fixes BATCH 4 Date: Tue, 8 Feb 2022 10:50:13 +0000 Message-Id: <164431738306.20265.453911406614125295.b4-ty@arm.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20220110015018.26359-1-kabel@kernel.org> References: <20220110015018.26359-1-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, 10 Jan 2022 02:49:55 +0100, Marek Behún wrote: > this is v2 of fourth batch of fixes for the Aardvark PCIe controller > driver. > > Stuff is converted to new interrupt APIs and recommendations from Marc. > Marc, could you look at these and acknowledge or comment? > > This series mainly fixes and adds support for stuff around interrupts: > the most important thing is fixing MSI support. > > [...] Applied to pci/aardvark, thanks! [01/23] PCI: aardvark: Replace custom PCIE_CORE_INT_* macros with PCI_INTERRUPT_* https://git.kernel.org/lpieralisi/pci/c/1d86abf1f8 [02/23] PCI: aardvark: Fix reading MSI interrupt number https://git.kernel.org/lpieralisi/pci/c/805dfc18dd [03/23] PCI: aardvark: Fix support for MSI interrupts https://git.kernel.org/lpieralisi/pci/c/b0b0b8b897 [04/23] PCI: aardvark: Rewrite IRQ code to chained IRQ handler https://git.kernel.org/lpieralisi/pci/c/1571d67dc1 [05/23] PCI: aardvark: Check return value of generic_handle_domain_irq() when processing INTx IRQ https://git.kernel.org/lpieralisi/pci/c/51f96e287c [06/23] PCI: aardvark: Make MSI irq_chip structures static driver structures https://git.kernel.org/lpieralisi/pci/c/c3cb8e5183 [07/23] PCI: aardvark: Make msi_domain_info structure a static driver structure https://git.kernel.org/lpieralisi/pci/c/26bcd54e4a [08/23] PCI: aardvark: Use dev_fwnode() instead of of_node_to_fwnode(dev->of_node) https://git.kernel.org/lpieralisi/pci/c/222af78532 [09/23] PCI: aardvark: Refactor unmasking summary MSI interrupt https://git.kernel.org/lpieralisi/pci/c/4689c09163 [10/23] PCI: aardvark: Add support for masking MSI interrupts https://git.kernel.org/lpieralisi/pci/c/e77d9c9069 [11/23] PCI: aardvark: Fix setting MSI address https://git.kernel.org/lpieralisi/pci/c/46ad3dc417 [12/23] PCI: aardvark: Enable MSI-X support https://git.kernel.org/lpieralisi/pci/c/754e449889 [13/23] PCI: aardvark: Add support for ERR interrupt on emulated bridge https://git.kernel.org/lpieralisi/pci/c/3ebfefa396 [14/23] PCI: aardvark: Fix reading PCI_EXP_RTSTA_PME bit on emulated bridge https://git.kernel.org/lpieralisi/pci/c/735f5ae49e [15/23] PCI: aardvark: Optimize writing PCI_EXP_RTCTL_PMEIE and PCI_EXP_RTSTA_PME on emulated bridge https://git.kernel.org/lpieralisi/pci/c/7122bcb332 [16/23] PCI: aardvark: Add support for PME interrupts https://git.kernel.org/lpieralisi/pci/c/0fc75d8745 [17/23] PCI: aardvark: Fix support for PME requester on emulated bridge https://git.kernel.org/lpieralisi/pci/c/273ddd86d6 [18/23] PCI: aardvark: Use separate INTA interrupt for emulated root bridge https://git.kernel.org/lpieralisi/pci/c/815bc31368 [19/23] PCI: aardvark: Remove irq_mask_ack callback for INTx interrupts https://git.kernel.org/lpieralisi/pci/c/b08e5b53d1 [20/23] PCI: aardvark: Don't mask irq when mapping https://git.kernel.org/lpieralisi/pci/c/befa710001 [21/23] PCI: aardvark: Drop __maybe_unused from advk_pcie_disable_phy() https://git.kernel.org/lpieralisi/pci/c/0c36ab437e [22/23] PCI: aardvark: Update comment about link going down after link-up https://git.kernel.org/lpieralisi/pci/c/92f4ffecc4 Thanks, Lorenzo