Re: [PATCH][sata_fsl] Defer non-ncq = commands when ncq commands active

From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kalra Ashish-B00888" Subject: RE: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active Date: Thu, 30 Jul 2009 19:28:12 +0530 Message-ID: <16444A0F3094A24C83EAB7836A12C63B032E5C@zin33exm20.fsl.freescale.net> References: <4A70A78D.7070601@gmail.com> <16444A0F3094A24C83EAB7836A12C63B032E5A@zin33exm20.fsl.freescale.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4725882383979835935==" Return-path: Content-class: urn:content-classes:message List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org To: Kumar Gala Cc: linuxppc-dev@ozlabs.org, linux-ide@vger.kernel.org, Robert Hancock List-Id: linux-ide@vger.kernel.org This is a multi-part message in MIME format. --===============4725882383979835935== Content-class: urn:content-classes:message Content-Type: multipart/alternative; boundary="----_=_NextPart_001_01CA111E.1FE629D0" This is a multi-part message in MIME format. ------_=_NextPart_001_01CA111E.1FE629D0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hello Kumar, >> > This doesn't look like it should change anything. sata_fsl_ops=20 >> inherits >> > from sata_pmp_port_ops, which inherits from sata_port_ops, which=20 >> already >> > sets qc_defer to ata_std_qc_defer. >> Oh, yes. Actually this patch was for older kernels where there=20 >> inheritence was not there. As you mentioned, this patch is not=20 >> required now. >> >How old? Should we be asking for this to be applied to some of the=20 >stable kernel series? I believe that the inheritence stuff was added in 2.6.26, thus, this = patch is required for quite old kernels ( < 2.6.26 ). Thanks, Ashish ------_=_NextPart_001_01CA111E.1FE629D0 Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Re: [PATCH][sata_fsl] Defer non-ncq = commands when ncq commands active=0A= =0A= =0A= =0A=

=0A=

Hello = Kumar,

=0A=

>> > This doesn't look like = it should change anything. sata_fsl_ops
>> = inherits
>> > from sata_pmp_port_ops, which inherits from = sata_port_ops, which
>> already
>> > sets = qc_defer to ata_std_qc_defer.
>> Oh, yes. Actually this patch = was for older kernels where there
>> inheritence was not = there. As you mentioned, this patch is not
>> required = now.
>>
>How old? Should we be asking for this to = be applied to some of the
>stable kernel series?

I = believe that the inheritence stuff was added in 2.6.26, thus, this patch = is

=0A=

required for quite old kernels ( < = 2.6.26 ).

=0A=

Thanks,

=0A=

Ashish

------_=_NextPart_001_01CA111E.1FE629D0-- --===============4725882383979835935== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev --===============4725882383979835935==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 37198B7BBA for ; Fri, 31 Jul 2009 00:01:02 +1000 (EST) Received: from az33egw02.freescale.net (az33egw02.freescale.net [192.88.158.103]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "az33egw02.freescale.net", Issuer "Thawte Premium Server CA" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 1E72BDDD1C for ; Fri, 31 Jul 2009 00:00:54 +1000 (EST) Received: from de01smr02.am.mot.com (de01smr02.freescale.net [10.208.0.151]) by az33egw02.freescale.net (8.14.3/az33egw02) with ESMTP id n6UE0kq7025896 for ; Thu, 30 Jul 2009 07:00:51 -0700 (MST) Received: from zin33exm20.fsl.freescale.net (zin33exm20.ap.freescale.net [10.232.192.5]) by de01smr02.am.mot.com (8.13.1/8.13.0) with ESMTP id n6UE10dT014684 for ; Thu, 30 Jul 2009 09:01:01 -0500 (CDT) MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----_=_NextPart_001_01CA111E.1FE629D0" Subject: RE: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active Date: Thu, 30 Jul 2009 19:28:12 +0530 Message-ID: <16444A0F3094A24C83EAB7836A12C63B032E5C@zin33exm20.fsl.freescale.net> References: <4A70A78D.7070601@gmail.com> <16444A0F3094A24C83EAB7836A12C63B032E5A@zin33exm20.fsl.freescale.net> From: "Kalra Ashish-B00888" To: "Kumar Gala" Cc: linuxppc-dev@ozlabs.org, linux-ide@vger.kernel.org, Robert Hancock List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , This is a multi-part message in MIME format. ------_=_NextPart_001_01CA111E.1FE629D0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hello Kumar, >> > This doesn't look like it should change anything. sata_fsl_ops=20 >> inherits >> > from sata_pmp_port_ops, which inherits from sata_port_ops, which=20 >> already >> > sets qc_defer to ata_std_qc_defer. >> Oh, yes. Actually this patch was for older kernels where there=20 >> inheritence was not there. As you mentioned, this patch is not=20 >> required now. >> >How old? Should we be asking for this to be applied to some of the=20 >stable kernel series? I believe that the inheritence stuff was added in 2.6.26, thus, this = patch is required for quite old kernels ( < 2.6.26 ). Thanks, Ashish ------_=_NextPart_001_01CA111E.1FE629D0 Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Re: [PATCH][sata_fsl] Defer non-ncq = commands when ncq commands active=0A= =0A= =0A= =0A=

=0A=

Hello = Kumar,

=0A=

required for quite old kernels ( < = 2.6.26 ).

=0A=

Thanks,

=0A=

Ashish

------_=_NextPart_001_01CA111E.1FE629D0--