All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
	Vlad.Karpovich@cirrus.com, lgirdwood@gmail.com
Subject: Re: (subset) [PATCH 1/3] ASoC: wm_adsp: Correct control read size when parsing compressed buffer
Date: Thu, 10 Feb 2022 20:19:51 +0000	[thread overview]
Message-ID: <164452439180.1098326.4968635038186775717.b4-ty@kernel.org> (raw)
In-Reply-To: <20220210172053.22782-1-ckeepax@opensource.cirrus.com>

On Thu, 10 Feb 2022 17:20:51 +0000, Charles Keepax wrote:
> When parsing the compressed stream the whole buffer descriptor is
> now read in a single cs_dsp_coeff_read_ctrl; on older firmwares
> this descriptor is just 4 bytes but on more modern firmwares it is
> 24 bytes. The current code reads the full 24 bytes regardless, this
> was working but reading junk for the last 20 bytes. However commit
> f444da38ac92 ("firmware: cs_dsp: Add offset to cs_dsp read/write")
> added a size check into cs_dsp_coeff_read_ctrl, causing the older
> firmwares to now return an error.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-linus

Thanks!

[1/3] ASoC: wm_adsp: Correct control read size when parsing compressed buffer
      commit: a887f9c7a4d37a8e874ba8415a42a92a1b5139fc

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

  parent reply	other threads:[~2022-02-10 20:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 17:20 [PATCH 1/3] ASoC: wm_adsp: Correct control read size when parsing compressed buffer Charles Keepax
2022-02-10 17:20 ` [PATCH 2/3] ASoC: wm_adsp: Make compressed buffers optional Charles Keepax
2022-02-10 17:20 ` [PATCH 3/3] ASoC: wm_adsp: Add trace caps to speaker protection FW Charles Keepax
2022-02-10 20:19 ` Mark Brown [this message]
2022-02-14 12:54 ` (subset) [PATCH 1/3] ASoC: wm_adsp: Correct control read size when parsing compressed buffer Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=164452439180.1098326.4968635038186775717.b4-ty@kernel.org \
    --to=broonie@kernel.org \
    --cc=Vlad.Karpovich@cirrus.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=lgirdwood@gmail.com \
    --cc=patches@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.