From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: Survey for final decision about per-port offload API
Date: Fri, 30 Mar 2018 17:46:48 +0200
Message-ID: <1644846.U24NRPAHE1@xps>
References: <2759953.P7QpFFSjiU@xps>
 <93ee347b-3474-30c5-d35e-cd2766dcb34a@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Ajit Khaparde <ajit.khaparde@broadcom.com>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 Shijith Thotton <shijith.thotton@cavium.com>,
 Santosh Shukla <santosh.shukla@caviumnetworks.com>,
 Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
 John Daley <johndale@cisco.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Beilei Xing <beilei.xing@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
 Yongseok Koh <yskoh@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>,
 Tomasz Duszynski <tdu@semihalf.com>, Jianbo Liu <jianbo.liu@arm.com>,
 Alejandro Lucero <alejandro.lucero@netronome.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>,
 Harish Patil <harish.patil@cavium
To: Andrew Rybchenko <arybchenko@solarflare.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 0C5FD728B
 for <dev@dpdk.org>; Fri, 30 Mar 2018 17:47:06 +0200 (CEST)
In-Reply-To: <93ee347b-3474-30c5-d35e-cd2766dcb34a@solarflare.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

30/03/2018 17:13, Andrew Rybchenko:
> On 03/30/2018 04:47 PM, Thomas Monjalon wrote:
> > There is the same kind of confusion in the offload capabilities:
> > 	rte_eth_dev_info.[rt]x_offload_capa
> > 	rte_eth_dev_info.[rt]x_queue_offload_capa
> > The queue capabilities must be a subset of port capabilities,
> > i.e. every queue capabilities must be reported as port capabilities.
> > But the port capabilities should be reported at queue level
> > only if it can be applied to a specific queue.
> >
> > 4/ Do you agree with above statement (to be added in the doc)?
> 
> Yes, may be it would be good to be more precise what "can be applied" mean.
> As I understand it is "can be enabled on queue when it is disabled on 
> port level".

Yes, "can be applied to a specific queue" means
"can be enabled on queue when it is disabled on port level".

Thanks for answering the survey.