From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Kees Cook <keescook@chromium.org>, Michael Cyr <mikecyr@linux.ibm.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-hardening@vger.kernel.org, target-devel@vger.kernel.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Tyrel Datwyler <tyreld@linux.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: ibmvscsis: Silence -Warray-bounds warning
Date: Mon, 14 Feb 2022 22:19:18 -0500 [thread overview]
Message-ID: <164489513313.15031.7832986884338779882.b4-ty@oracle.com> (raw)
In-Reply-To: <20220208061231.3429486-1-keescook@chromium.org>
On Mon, 7 Feb 2022 22:12:31 -0800, Kees Cook wrote:
> Instead of doing a cast to storage that is too small, add a union for
> the high 64 bits. Silences the warnings under -Warray-bounds:
>
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_send_messages':
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:1934:44: error: array subscript 'struct viosrp_crq[0]' is partly outside array bounds of 'u64[1]' {aka 'long long unsigned int[1]'} [-Werror=array-bounds]
> 1934 | crq->valid = VALID_CMD_RESP_EL;
> | ^~
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:1875:13: note: while referencing 'msg_hi'
> 1875 | u64 msg_hi = 0;
> | ^~~~~~
>
> [...]
Applied to 5.18/scsi-queue, thanks!
[1/1] scsi: ibmvscsis: Silence -Warray-bounds warning
https://git.kernel.org/mkp/scsi/c/03e4383c7ce3
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2022-02-15 3:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 6:12 [PATCH] scsi: ibmvscsis: Silence -Warray-bounds warning Kees Cook
2022-02-09 23:53 ` Tyrel Datwyler
2022-02-11 21:42 ` Martin K. Petersen
2022-02-15 3:19 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164489513313.15031.7832986884338779882.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=jejb@linux.ibm.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mikecyr@linux.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=target-devel@vger.kernel.org \
--cc=tyreld@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.