From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Vivek Kasireddy" <vivek.kasireddy@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/mm: Add an iterator to optimally walk over holes suitable for an allocation
Date: Mon, 28 Feb 2022 23:57:27 -0000 [thread overview]
Message-ID: <164609264768.6632.3502754247422902088@emeril.freedesktop.org> (raw)
In-Reply-To: <20220228190429.1358951-1-vivek.kasireddy@intel.com>
== Series Details ==
Series: drm/mm: Add an iterator to optimally walk over holes suitable for an allocation
URL : https://patchwork.freedesktop.org/series/100847/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
0ae83c35ff14 drm/mm: Add an iterator to optimally walk over holes for an allocation (v5)
-:157: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pos' - possible side-effects?
#157: FILE: include/drm/drm_mm.h:430:
+#define drm_mm_for_each_suitable_hole(pos, mm, range_start, range_end, \
+ size, mode) \
+ for (pos = __drm_mm_first_hole(mm, range_start, range_end, size, \
+ mode & ~DRM_MM_INSERT_ONCE); \
+ pos; \
+ pos = mode & DRM_MM_INSERT_ONCE ? \
+ NULL : __drm_mm_next_hole(mm, pos, size, \
+ mode & ~DRM_MM_INSERT_ONCE))
-:157: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mm' - possible side-effects?
#157: FILE: include/drm/drm_mm.h:430:
+#define drm_mm_for_each_suitable_hole(pos, mm, range_start, range_end, \
+ size, mode) \
+ for (pos = __drm_mm_first_hole(mm, range_start, range_end, size, \
+ mode & ~DRM_MM_INSERT_ONCE); \
+ pos; \
+ pos = mode & DRM_MM_INSERT_ONCE ? \
+ NULL : __drm_mm_next_hole(mm, pos, size, \
+ mode & ~DRM_MM_INSERT_ONCE))
-:157: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'size' - possible side-effects?
#157: FILE: include/drm/drm_mm.h:430:
+#define drm_mm_for_each_suitable_hole(pos, mm, range_start, range_end, \
+ size, mode) \
+ for (pos = __drm_mm_first_hole(mm, range_start, range_end, size, \
+ mode & ~DRM_MM_INSERT_ONCE); \
+ pos; \
+ pos = mode & DRM_MM_INSERT_ONCE ? \
+ NULL : __drm_mm_next_hole(mm, pos, size, \
+ mode & ~DRM_MM_INSERT_ONCE))
-:157: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mode' - possible side-effects?
#157: FILE: include/drm/drm_mm.h:430:
+#define drm_mm_for_each_suitable_hole(pos, mm, range_start, range_end, \
+ size, mode) \
+ for (pos = __drm_mm_first_hole(mm, range_start, range_end, size, \
+ mode & ~DRM_MM_INSERT_ONCE); \
+ pos; \
+ pos = mode & DRM_MM_INSERT_ONCE ? \
+ NULL : __drm_mm_next_hole(mm, pos, size, \
+ mode & ~DRM_MM_INSERT_ONCE))
-:157: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'mode' may be better as '(mode)' to avoid precedence issues
#157: FILE: include/drm/drm_mm.h:430:
+#define drm_mm_for_each_suitable_hole(pos, mm, range_start, range_end, \
+ size, mode) \
+ for (pos = __drm_mm_first_hole(mm, range_start, range_end, size, \
+ mode & ~DRM_MM_INSERT_ONCE); \
+ pos; \
+ pos = mode & DRM_MM_INSERT_ONCE ? \
+ NULL : __drm_mm_next_hole(mm, pos, size, \
+ mode & ~DRM_MM_INSERT_ONCE))
total: 0 errors, 0 warnings, 5 checks, 114 lines checked
81e2ccf8eadb drm/i915/gem: Don't try to map and fence large scanout buffers (v9)
next prev parent reply other threads:[~2022-02-28 23:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 19:04 [CI 0/2] drm/mm: Add an iterator to optimally walk over holes suitable for an allocation Vivek Kasireddy
2022-02-28 19:04 ` [Intel-gfx] " Vivek Kasireddy
2022-02-28 19:04 ` [CI 1/2] drm/mm: Add an iterator to optimally walk over holes for an allocation (v5) Vivek Kasireddy
2022-02-28 19:04 ` [Intel-gfx] " Vivek Kasireddy
2022-02-28 19:04 ` [CI 2/2] drm/i915/gem: Don't try to map and fence large scanout buffers (v9) Vivek Kasireddy
2022-02-28 19:04 ` [Intel-gfx] " Vivek Kasireddy
2022-02-28 23:57 ` Patchwork [this message]
2022-02-28 23:59 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/mm: Add an iterator to optimally walk over holes suitable for an allocation Patchwork
2022-03-01 0:31 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-03-01 12:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/mm: Add an iterator to optimally walk over holes suitable for an allocation (rev2) Patchwork
2022-03-01 12:03 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-03-01 12:32 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-03-01 19:23 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-03-02 8:41 ` Tvrtko Ursulin
-- strict thread matches above, loose matches on Subject: below --
2022-03-07 20:21 [PATCH v6 0/2] drm/mm: Add an iterator to optimally walk over holes suitable for an allocation Vivek Kasireddy
2022-03-07 20:56 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-03-05 23:36 [CI 0/2] " Vivek Kasireddy
2022-03-06 0:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-03-07 9:50 ` Tvrtko Ursulin
2022-02-27 17:29 [CI 0/2] " Vivek Kasireddy
2022-02-27 17:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-02-14 23:56 [PATCH 0/2] " Vivek Kasireddy
2022-02-16 3:16 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164609264768.6632.3502754247422902088@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=vivek.kasireddy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.