All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kurt Manucredo" <fuzzybritches0@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH v2] bpf: core: fix shift-out-of-bounds in ___bpf_prog_run
Date: Tue, 01 Jun 2021 23:28:00 +0200	[thread overview]
Message-ID: <16463-26867-curtm@phaethon> (raw)
In-Reply-To: <YLZVnNNAkAQFvSm8@kroah.com>

On Tue, 1 Jun 2021 17:43:24 +0200, Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> On Tue, Jun 01, 2021 at 04:33:09PM +0200, Kurt Manucredo wrote:
> > Fix shift-out-of-bounds in ___bpf_prog_run().
> 
> How is this "fixed"?
> 
Fix shift-out-of-bounds in ___bpf_prog_run() by adding extra boundary
check in check_alu_op() in verifier.c.

> > 
> > UBSAN: shift-out-of-bounds in kernel/bpf/core.c:1414:2
> > shift exponent 248 is too large for 32-bit type 'unsigned int'
> 
> What is this from?

https://syzkaller.appspot.com/bug?id=edb51be4c9a320186328893287bb30d5eed09231
> 
> Any reason you didn't cc: the bpf maintainers and developers?
> 
Yes. I send them to you, the mentees mailing list and Shuah, first, for
review, comment and help. Is this not okay? 

> 
> > Reported-by: syzbot+bed360704c521841c85d@syzkaller.appspotmail.com
> 
> Does this pass the syzbot testing?

Yes, it says 'OK' in the 'Result' column at:
https://syzkaller.appspot.com/bug?id=edb51be4c9a320186328893287bb30d5eed09231
It's the latest from fuzzybritches0@gmail.com.

But at this point I cannot say if this is right. Should I send the next
version to everyone?

thanks and kind regards,

Kurt Manucredo

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  reply	other threads:[~2021-06-01 21:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26 21:40 [PATCH] bpf: core: fix shift-out-of-bounds in ___bpf_prog_run Kurt Manucredo
2021-05-27  4:29 ` Greg KH
2021-06-01 14:33   ` [PATCH v2] " Kurt Manucredo
2021-06-01 15:43     ` Greg KH
2021-06-01 21:28       ` Kurt Manucredo [this message]
2021-06-02  6:09         ` Greg KH
2021-06-02  6:36           ` Pavel Skripkin
2021-06-04 21:15             ` Kurt Manucredo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16463-26867-curtm@phaethon \
    --to=fuzzybritches0@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.