* [PATCH net] net: dsa: mt7530: fix incorrect test in mt753x_phylink_validate()
@ 2022-03-07 12:13 ` Russell King (Oracle)
0 siblings, 0 replies; 6+ messages in thread
From: Russell King (Oracle) @ 2022-03-07 12:13 UTC (permalink / raw)
To: DENG Qingfang, Landen Chao, Sean Wang
Cc: Andrew Lunn, Vivien Didelot, Florian Fainelli, Vladimir Oltean,
David S. Miller, Jakub Kicinski, Matthias Brugger, netdev,
linux-arm-kernel, linux-mediatek
Discussing one of the tests in mt753x_phylink_validate() with Landen
Chao confirms that the "||" should be "&&". Fix this.
Fixes: c288575f7810 ("net: dsa: mt7530: Add the support of MT7531 switch")
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
As the mt7530 maintainers are not very responsive to my recent two patch
series, but Landen Chao did state that this should be "&&" not "||", lets
at least get this patch merged.
drivers/net/dsa/mt7530.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index ff3c267d0f26..a251bc55727f 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -2936,7 +2936,7 @@ mt753x_phylink_validate(struct dsa_switch *ds, int port,
phylink_set_port_modes(mask);
- if (state->interface != PHY_INTERFACE_MODE_TRGMII ||
+ if (state->interface != PHY_INTERFACE_MODE_TRGMII &&
!phy_interface_mode_is_8023z(state->interface)) {
phylink_set(mask, 10baseT_Half);
phylink_set(mask, 10baseT_Full);
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH net] net: dsa: mt7530: fix incorrect test in mt753x_phylink_validate()
@ 2022-03-07 12:13 ` Russell King (Oracle)
0 siblings, 0 replies; 6+ messages in thread
From: Russell King (Oracle) @ 2022-03-07 12:13 UTC (permalink / raw)
To: DENG Qingfang, Landen Chao, Sean Wang
Cc: Andrew Lunn, Vivien Didelot, Florian Fainelli, Vladimir Oltean,
David S. Miller, Jakub Kicinski, Matthias Brugger, netdev,
linux-arm-kernel, linux-mediatek
Discussing one of the tests in mt753x_phylink_validate() with Landen
Chao confirms that the "||" should be "&&". Fix this.
Fixes: c288575f7810 ("net: dsa: mt7530: Add the support of MT7531 switch")
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
As the mt7530 maintainers are not very responsive to my recent two patch
series, but Landen Chao did state that this should be "&&" not "||", lets
at least get this patch merged.
drivers/net/dsa/mt7530.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index ff3c267d0f26..a251bc55727f 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -2936,7 +2936,7 @@ mt753x_phylink_validate(struct dsa_switch *ds, int port,
phylink_set_port_modes(mask);
- if (state->interface != PHY_INTERFACE_MODE_TRGMII ||
+ if (state->interface != PHY_INTERFACE_MODE_TRGMII &&
!phy_interface_mode_is_8023z(state->interface)) {
phylink_set(mask, 10baseT_Half);
phylink_set(mask, 10baseT_Full);
--
2.30.2
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH net] net: dsa: mt7530: fix incorrect test in mt753x_phylink_validate()
@ 2022-03-07 12:13 ` Russell King (Oracle)
0 siblings, 0 replies; 6+ messages in thread
From: Russell King (Oracle) @ 2022-03-07 12:13 UTC (permalink / raw)
To: DENG Qingfang, Landen Chao, Sean Wang
Cc: Andrew Lunn, Vivien Didelot, Florian Fainelli, Vladimir Oltean,
David S. Miller, Jakub Kicinski, Matthias Brugger, netdev,
linux-arm-kernel, linux-mediatek
Discussing one of the tests in mt753x_phylink_validate() with Landen
Chao confirms that the "||" should be "&&". Fix this.
Fixes: c288575f7810 ("net: dsa: mt7530: Add the support of MT7531 switch")
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
As the mt7530 maintainers are not very responsive to my recent two patch
series, but Landen Chao did state that this should be "&&" not "||", lets
at least get this patch merged.
drivers/net/dsa/mt7530.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index ff3c267d0f26..a251bc55727f 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -2936,7 +2936,7 @@ mt753x_phylink_validate(struct dsa_switch *ds, int port,
phylink_set_port_modes(mask);
- if (state->interface != PHY_INTERFACE_MODE_TRGMII ||
+ if (state->interface != PHY_INTERFACE_MODE_TRGMII &&
!phy_interface_mode_is_8023z(state->interface)) {
phylink_set(mask, 10baseT_Half);
phylink_set(mask, 10baseT_Full);
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net] net: dsa: mt7530: fix incorrect test in mt753x_phylink_validate()
2022-03-07 12:13 ` Russell King (Oracle)
(?)
@ 2022-03-08 12:30 ` patchwork-bot+netdevbpf
-1 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-03-08 12:30 UTC (permalink / raw)
To: Russell King
Cc: dqfext, Landen.Chao, sean.wang, andrew, vivien.didelot,
f.fainelli, olteanv, davem, kuba, matthias.bgg, netdev,
linux-arm-kernel, linux-mediatek
Hello:
This patch was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Mon, 07 Mar 2022 12:13:30 +0000 you wrote:
> Discussing one of the tests in mt753x_phylink_validate() with Landen
> Chao confirms that the "||" should be "&&". Fix this.
>
> Fixes: c288575f7810 ("net: dsa: mt7530: Add the support of MT7531 switch")
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---
> As the mt7530 maintainers are not very responsive to my recent two patch
> series, but Landen Chao did state that this should be "&&" not "||", lets
> at least get this patch merged.
>
> [...]
Here is the summary with links:
- [net] net: dsa: mt7530: fix incorrect test in mt753x_phylink_validate()
https://git.kernel.org/netdev/net/c/e5417cbf7ab5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] net: dsa: mt7530: fix incorrect test in mt753x_phylink_validate()
@ 2022-03-08 12:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-03-08 12:30 UTC (permalink / raw)
To: Russell King
Cc: dqfext, Landen.Chao, sean.wang, andrew, vivien.didelot,
f.fainelli, olteanv, davem, kuba, matthias.bgg, netdev,
linux-arm-kernel, linux-mediatek
Hello:
This patch was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Mon, 07 Mar 2022 12:13:30 +0000 you wrote:
> Discussing one of the tests in mt753x_phylink_validate() with Landen
> Chao confirms that the "||" should be "&&". Fix this.
>
> Fixes: c288575f7810 ("net: dsa: mt7530: Add the support of MT7531 switch")
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---
> As the mt7530 maintainers are not very responsive to my recent two patch
> series, but Landen Chao did state that this should be "&&" not "||", lets
> at least get this patch merged.
>
> [...]
Here is the summary with links:
- [net] net: dsa: mt7530: fix incorrect test in mt753x_phylink_validate()
https://git.kernel.org/netdev/net/c/e5417cbf7ab5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] net: dsa: mt7530: fix incorrect test in mt753x_phylink_validate()
@ 2022-03-08 12:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-03-08 12:30 UTC (permalink / raw)
To: Russell King
Cc: dqfext, Landen.Chao, sean.wang, andrew, vivien.didelot,
f.fainelli, olteanv, davem, kuba, matthias.bgg, netdev,
linux-arm-kernel, linux-mediatek
Hello:
This patch was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Mon, 07 Mar 2022 12:13:30 +0000 you wrote:
> Discussing one of the tests in mt753x_phylink_validate() with Landen
> Chao confirms that the "||" should be "&&". Fix this.
>
> Fixes: c288575f7810 ("net: dsa: mt7530: Add the support of MT7531 switch")
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---
> As the mt7530 maintainers are not very responsive to my recent two patch
> series, but Landen Chao did state that this should be "&&" not "||", lets
> at least get this patch merged.
>
> [...]
Here is the summary with links:
- [net] net: dsa: mt7530: fix incorrect test in mt753x_phylink_validate()
https://git.kernel.org/netdev/net/c/e5417cbf7ab5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-08 12:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-07 12:13 [PATCH net] net: dsa: mt7530: fix incorrect test in mt753x_phylink_validate() Russell King (Oracle)
2022-03-07 12:13 ` Russell King (Oracle)
2022-03-07 12:13 ` Russell King (Oracle)
2022-03-08 12:30 ` patchwork-bot+netdevbpf
2022-03-08 12:30 ` patchwork-bot+netdevbpf
2022-03-08 12:30 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.