From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nUDiU-000081-K0 for mharc-grub-devel@gnu.org; Tue, 15 Mar 2022 16:24:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUDiN-0008Qk-F7 for grub-devel@gnu.org; Tue, 15 Mar 2022 16:24:19 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:37558) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUDiL-0005CT-0v for grub-devel@gnu.org; Tue, 15 Mar 2022 16:24:19 -0400 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22FISvoK020020 for ; Tue, 15 Mar 2022 20:24:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=corp-2021-07-09; bh=TqPg06XB2fbYFEY8P8822/y+Ve2eKmSKHXKdOwozhyA=; b=cix1TrHug9Bfj8nz3anaTgSmjjYN5/821awTuL8LmoXpck1xMNvRkEB2wOwrOGWX0trh NNG+VjXNTzKySnc2adxXuRSiHSajclTzUVplq4YiZtWdViGt2KUchkubnUevcMxR8Ekm 6uXBr2vMh53q1kaAMbp9WXe/ckBlCp+n/6F0Aqci4AhiutwGI7DPOQPLukm4aSOSI3vf 57C57ggdCKsHRwH7y1Qk/lfqWH4hF50gb9V/Gsi4F0spme/ofVjq8e55VjhZtnZe2g1B ttpq5at5TOvrPfprs3vB7mQ0HD0sXftzSMNVJR8qTSeCC+B3DiwkzTVaRboZf+IeFmKH 0A== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3et60rc6yq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 15 Mar 2022 20:24:16 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 22FKAX8s023759 for ; Tue, 15 Mar 2022 20:24:15 GMT Received: from pps.reinject (localhost [127.0.0.1]) by userp3020.oracle.com with ESMTP id 3et65830ds-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 15 Mar 2022 20:24:15 +0000 Received: from userp3020.oracle.com (userp3020.oracle.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 22FKOE3c055817 for ; Tue, 15 Mar 2022 20:24:14 GMT Received: from localhost (dhcp-10-152-14-18.usdhcp.oraclecorp.com [10.152.14.18]) by userp3020.oracle.com with ESMTP id 3et65830dj-1; Tue, 15 Mar 2022 20:24:14 +0000 From: Alec Brown To: grub-devel@gnu.org Cc: daniel.kiper@oracle.com, darren.kenny@oracle.com, alec.r.brown@oracle.com Subject: [PATCH 5/7] grub-core/net/net.c: Fix uninitialized scalar variable Date: Tue, 15 Mar 2022 16:24:07 -0400 Message-Id: <1647375849-24164-6-git-send-email-alec.r.brown@oracle.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1647375849-24164-1-git-send-email-alec.r.brown@oracle.com> References: <1647375849-24164-1-git-send-email-alec.r.brown@oracle.com> X-Proofpoint-GUID: BXqXH1hZMyy28zYGNXt4nxvsqCJonFnS X-Proofpoint-ORIG-GUID: BXqXH1hZMyy28zYGNXt4nxvsqCJonFnS Received-SPF: pass client-ip=205.220.177.32; envelope-from=alec.r.brown@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Mar 2022 20:24:20 -0000 In the function grub_net_ipv6_get_link_local(), grub_net_network_level_address_t addr is called but isn't being initialized. To prevent contents of this structure from being filled with junk data from the stack, we can initialize it to 0 by setting addr to {}; Fixes: CID 375033 Signed-off-by: Alec Brown --- grub-core/net/net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/net/net.c b/grub-core/net/net.c index 4d3eb5c1a..4e93365a7 100644 --- a/grub-core/net/net.c +++ b/grub-core/net/net.c @@ -287,7 +287,7 @@ grub_net_ipv6_get_link_local (struct grub_net_card *card, struct grub_net_network_level_interface *inf; char *name; char *ptr; - grub_net_network_level_address_t addr; + grub_net_network_level_address_t addr = {}; addr.type = GRUB_NET_NETWORK_LEVEL_PROTOCOL_IPV6; addr.ipv6[0] = grub_cpu_to_be64_compile_time (0xfe80ULL << 48); -- 2.27.0