From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E529EC433F5 for ; Thu, 17 Mar 2022 14:15:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234893AbiCQOQe (ORCPT ); Thu, 17 Mar 2022 10:16:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234866AbiCQOQd (ORCPT ); Thu, 17 Mar 2022 10:16:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3B2DA6E1D; Thu, 17 Mar 2022 07:15:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 31DB3617BE; Thu, 17 Mar 2022 14:15:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60E5EC340E9; Thu, 17 Mar 2022 14:15:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647526511; bh=Gw06cUiqZUFqaQ47kCBtK/oLuXtFQCo2+/8QuxFZfl8=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=ttAwNCiZfGksZpSzkyklqcmY6KoXhdZmcnUpZXPNhpZS+flX7riy2hVdfRRcbIp5G 8IjZQRHDP2l4PJYlo7NOljcIC3pFMApz+fWqWCFhdr66uOApjpzg7uV7OD7FzZYfZa 6nvl++P+fZ4nWxrlF2vC79amqP4do/zeI0EV4ugJwM2OqXad5UQSnNymM1JuOkQRWz CutvRCb7Rs0w1FXBh6+aLKtE3u90bZMCqBEzsTgSEOjj2OlvtGLm/EWV0OLemqGdQn 0eVVS5iRa1I1MbhBlM7SafO/tTbeR4vVhbq4QM4ixsO4m/+bi5SWh7d0HXnN2K+FZ9 TpsJBZsQJeEYg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] iwlwifi: mei: fix building iwlmei From: Kalle Valo In-Reply-To: <20220316183617.1470631-1-arnd@kernel.org> References: <20220316183617.1470631-1-arnd@kernel.org> To: Arnd Bergmann Cc: Luca Coelho , Arnd Bergmann , "David S. Miller" , Jakub Kicinski , Ayala Beker , Emmanuel Grumbach , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <164752649601.16149.4589465777164464023.kvalo@kernel.org> Date: Thu, 17 Mar 2022 14:15:09 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Arnd Bergmann wrote: > From: Arnd Bergmann > > Building iwlmei without CONFIG_CFG80211 causes a link-time warning: > > ld.lld: error: undefined symbol: ieee80211_hdrlen > >>> referenced by net.c > >>> net/wireless/intel/iwlwifi/mei/net.o:(iwl_mei_tx_copy_to_csme) in archive drivers/built-in.a > > Add an explicit dependency to avoid this. In theory it should not > be needed here, but it also seems pointless to allow IWLMEI > for configurations without CFG80211. > > Signed-off-by: Arnd Bergmann > Acked-by: Emmanuel Grumbach > Acked-by: Luca Coelho Patch applied to wireless-next.git, thanks. 066291bec0c5 iwlwifi: mei: fix building iwlmei -- https://patchwork.kernel.org/project/linux-wireless/patch/20220316183617.1470631-1-arnd@kernel.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches