All of lore.kernel.org
 help / color / mirror / Atom feed
From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: <dri-devel@lists.freedesktop.org>
Cc: hamohammed.sa@gmail.com, suraj.kandpal@intel.com,
	emma@anholt.net, rodrigosiqueiramelo@gmail.com,
	jani.nikula@intel.com, liviu.dudau@arm.com,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	swboyd@chromium.org, melissa.srw@gmail.com,
	nganji@codeaurora.org, seanpaul@chromium.org,
	laurent.pinchart@ideasonboard.com, dmitry.baryshkov@linaro.org,
	james.qian.wang@arm.com, quic_aravindh@quicinc.com,
	mihail.atanassov@arm.com, freedreno@lists.freedesktop.org
Subject: [PATCH v7 0/4] Allow drm_writeback_connector to accept pointer to drm_encoder
Date: Fri, 8 Apr 2022 17:53:51 -0700	[thread overview]
Message-ID: <1649465635-20542-1-git-send-email-quic_abhinavk@quicinc.com> (raw)

There are some vendor drivers for which the writeback encoder shares
hardware resources such as clocks and interrupts with the rest of the
display pipeline. In addition, there can be use-cases where the
writeback encoder could be a shared encoder between the physical display
path and the writeback path.

To accommodate for such cases, change the drm_writeback_connector to
accept a pointer to drm_encoder.

For existing users of drm_writeback_connector there will not be any
change in functionality due to this change.

This approach was first posted by Suraj Kandpal here [1] for both
encoder and connector. But after discussions [2], the consensus was
reached to split this change for the drm_encoder first and the
drm_connector part can be reworked in a subsequent change later.

Validation of this change was done using igt_writeback tests on
MSM based RB5 board using the changes posted here [3].

For all other chipsets, these changes were compile-tested.

[1] https://patchwork.kernel.org/project/dri-devel/patch/20220202081702.22119-1-suraj.kandpal@intel.com/
[2] https://patchwork.kernel.org/project/dri-devel/patch/20220202085429.22261-6-suraj.kandpal@intel.com/
[3] https://patchwork.freedesktop.org/series/99724/

changes in v7:
	- move the change to make drm_encoder a pointer ahead in the
	  series. This allows vendor changes to be kept at a minimum
	  in core API changes
	- add a more detailed change log for some of the changes 

Abhinav Kumar (4):
  drm: allow passing possible_crtcs to drm_writeback_connector_init()
  drm: introduce drm_writeback_connector_init_with_encoder() API
  drm: allow real encoder to be passed for drm_writeback_connector
  drm/vc4: change vc4 driver to use
    drm_writeback_connector_init_with_encoder()

 .../drm/arm/display/komeda/komeda_wb_connector.c   |  4 +-
 drivers/gpu/drm/arm/malidp_mw.c                    |  4 +-
 drivers/gpu/drm/drm_writeback.c                    | 79 ++++++++++++++++++----
 drivers/gpu/drm/rcar-du/rcar_du_writeback.c        |  4 +-
 drivers/gpu/drm/vc4/vc4_txp.c                      | 33 ++++++---
 drivers/gpu/drm/vkms/vkms_writeback.c              |  4 +-
 include/drm/drm_writeback.h                        | 31 ++++++++-
 7 files changed, 128 insertions(+), 31 deletions(-)

-- 
2.7.4


             reply	other threads:[~2022-04-09  0:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-09  0:53 Abhinav Kumar [this message]
2022-04-09  0:53 ` [PATCH v7 1/4] drm: allow passing possible_crtcs to drm_writeback_connector_init() Abhinav Kumar
2022-04-09  0:59   ` Dmitry Baryshkov
2022-04-09  0:53 ` [PATCH v7 2/4] drm: introduce drm_writeback_connector_init_with_encoder() API Abhinav Kumar
2022-04-09  1:01   ` Dmitry Baryshkov
2022-04-09  0:53 ` [PATCH v7 3/4] drm: allow real encoder to be passed for drm_writeback_connector Abhinav Kumar
2022-04-09  1:05   ` Dmitry Baryshkov
2022-04-21 10:47   ` Liviu Dudau
2022-04-09  0:53 ` [PATCH v7 4/4] drm/vc4: change vc4 driver to use drm_writeback_connector_init_with_encoder() Abhinav Kumar
2022-04-20  1:54   ` Abhinav Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1649465635-20542-1-git-send-email-quic_abhinavk@quicinc.com \
    --to=quic_abhinavk@quicinc.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emma@anholt.net \
    --cc=freedreno@lists.freedesktop.org \
    --cc=hamohammed.sa@gmail.com \
    --cc=james.qian.wang@arm.com \
    --cc=jani.nikula@intel.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=liviu.dudau@arm.com \
    --cc=melissa.srw@gmail.com \
    --cc=mihail.atanassov@arm.com \
    --cc=nganji@codeaurora.org \
    --cc=quic_aravindh@quicinc.com \
    --cc=rodrigosiqueiramelo@gmail.com \
    --cc=seanpaul@chromium.org \
    --cc=suraj.kandpal@intel.com \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.