From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1806C433FE for ; Mon, 11 Apr 2022 22:54:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348185AbiDKW4z (ORCPT ); Mon, 11 Apr 2022 18:56:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350471AbiDKW4y (ORCPT ); Mon, 11 Apr 2022 18:56:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C1C6A195; Mon, 11 Apr 2022 15:54:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0559961745; Mon, 11 Apr 2022 22:54:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 600C7C385A3; Mon, 11 Apr 2022 22:54:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649717677; bh=aeUFknBcWBelMSTUFf2w3tHyo65gOicRWbiyY82fQJ8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Tv0vawjW/qGFgYu5PlIaUEBQKAPLJrz2l+es7dN+4fKuyVzg7BMJiYp9oY6LQPqO3 T8JXnCrakekIPzMO8L8CeBKSBfp3I/OFUkR0RRjDrj8j3C1nh0FtQH+ssc2xVWE9Hb zjaDFTasiBRAqYAdxcZyjzCcFYpnWlz2NtQE3QBbm8E4sjpQ4XjtvARnXanzjLyyw3 YmiDPLjsOJzQ2OG8gWMzUdjlqlzdy/K+BVW3+UMm0581skls1rvZBD0h1JdXyZl5Jn AmKO17dS985kz8GoCb4l7eG/SEEmcU/JKW4Ln+sfwgPKXPHJCcQh23QOVffKn0b9Bv 3IZ4d8CLwP4zA== Subject: [PATCH 1/4] xfs: make sure syncfs(2) passes back super_operations.sync_fs errors From: "Darrick J. Wong" To: djwong@kernel.org, guaneryu@gmail.com, zlang@redhat.com Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me Date: Mon, 11 Apr 2022 15:54:37 -0700 Message-ID: <164971767699.169983.772317637668809854.stgit@magnolia> In-Reply-To: <164971767143.169983.12905331894414458027.stgit@magnolia> References: <164971767143.169983.12905331894414458027.stgit@magnolia> User-Agent: StGit/0.19 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org From: Darrick J. Wong This is a regression test to make sure that nonzero error returns from a filesystem's ->sync_fs implementation are actually passed back to userspace when the call stack involves syncfs(2). Signed-off-by: Darrick J. Wong --- tests/xfs/839 | 42 ++++++++++++++++++++++++++++++++++++++++++ tests/xfs/839.out | 2 ++ 2 files changed, 44 insertions(+) create mode 100755 tests/xfs/839 create mode 100644 tests/xfs/839.out diff --git a/tests/xfs/839 b/tests/xfs/839 new file mode 100755 index 00000000..9bfe93ef --- /dev/null +++ b/tests/xfs/839 @@ -0,0 +1,42 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2022 Oracle. All Rights Reserved. +# +# FS QA Test No. 839 +# +# Regression test for kernel commits: +# +# 5679897eb104 ("vfs: make sync_filesystem return errors from ->sync_fs") +# 2d86293c7075 ("xfs: return errors in xfs_fs_sync_fs") +# +# During a code inspection, I noticed that sync_filesystem ignores the return +# value of the ->sync_fs calls that it makes. sync_filesystem, in turn is used +# by the syncfs(2) syscall to persist filesystem changes to disk. This means +# that syncfs(2) does not capture internal filesystem errors that are neither +# visible from the block device (e.g. media error) nor recorded in s_wb_err. +# XFS historically returned 0 from ->sync_fs even if there were log failures, +# so that had to be corrected as well. +# +# The kernel commits above fix this problem, so this test tries to trigger the +# bug by using the shutdown ioctl on a clean, freshly mounted filesystem in the +# hope that the EIO generated as a result of the filesystem being shut down is +# only visible via ->sync_fs. +# +. ./common/preamble +_begin_fstest auto quick shutdown + +# real QA test starts here + +# Modify as appropriate. +_require_xfs_io_command syncfs +_require_scratch_nocheck +_require_scratch_shutdown + +# Reuse the fs formatted when we checked for the shutdown ioctl, and don't +# bother checking the filesystem afterwards since we never wrote anything. +_scratch_mount +$XFS_IO_PROG -x -c 'shutdown -f ' -c syncfs $SCRATCH_MNT + +# success, all done +status=0 +exit diff --git a/tests/xfs/839.out b/tests/xfs/839.out new file mode 100644 index 00000000..f275cdcc --- /dev/null +++ b/tests/xfs/839.out @@ -0,0 +1,2 @@ +QA output created by 839 +syncfs: Input/output error