From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Johan Hovold <johan+linaro@kernel.org>,
Stanimir Varbanov <svarbanov@mm-sol.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
linux-kernel@vger.kernel.org, "Rob Herring" <robh@kernel.org>
Subject: Re: [PATCH v2] PCI: qcom: Fix pipe clock imbalance
Date: Wed, 13 Apr 2022 11:57:01 +0100 [thread overview]
Message-ID: <164984714583.9020.940270907096326400.b4-ty@arm.com> (raw)
In-Reply-To: <20220401133351.10113-1-johan+linaro@kernel.org>
On Fri, 1 Apr 2022 15:33:51 +0200, Johan Hovold wrote:
> Commit ed8cc3b1fc84 ("PCI: qcom: Add support for SDM845 PCIe
> controller") introduced a clock imbalance by enabling the pipe clock
> both in init() and in post_init() but only disabling in post_deinit().
>
> Note that the pipe clock was also never disabled in the init() error
> paths and that enabling the clock before powering up the PHY looks
> questionable.
>
> [...]
Applied to pci/qcom, thanks!
[1/1] PCI: qcom: Fix pipe clock imbalance
https://git.kernel.org/lpieralisi/pci/c/dcd9011f59
Thanks,
Lorenzo
prev parent reply other threads:[~2022-04-13 10:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 13:33 [PATCH v2] PCI: qcom: Fix pipe clock imbalance Johan Hovold
2022-04-04 13:53 ` Bjorn Andersson
2022-04-13 10:57 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164984714583.9020.940270907096326400.b4-ty@arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=agross@kernel.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=robh@kernel.org \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.