All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org, guaneryu@gmail.com, zlang@redhat.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me
Subject: [PATCH 2/2] generic/019: fix incorrect unset statements
Date: Tue, 19 Apr 2022 10:32:06 -0700	[thread overview]
Message-ID: <165038952637.1677615.2651496553218188517.stgit@magnolia> (raw)
In-Reply-To: <165038951495.1677615.10687913612774985228.stgit@magnolia>

From: Darrick J. Wong <djwong@kernel.org>

Fix incorrect usage of unset -- one passes the name of the variable, not
the *value* contained within it.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 tests/generic/019 |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


diff --git a/tests/generic/019 b/tests/generic/019
index 854ba57d..45c91624 100755
--- a/tests/generic/019
+++ b/tests/generic/019
@@ -140,8 +140,8 @@ _workout()
 	kill $fs_pid &> /dev/null
 	wait $fs_pid
 	wait $fio_pid
-	unset $fs_pid
-	unset $fio_pid
+	unset fs_pid
+	unset fio_pid
 
 	# We expect that broken FS still can be umounted
 	run_check _scratch_unmount


  parent reply	other threads:[~2022-04-19 17:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19 17:31 [PATCHSET 0/2] fstests: random fixes Darrick J. Wong
2022-04-19 17:32 ` [PATCH 1/2] xfs/019: fix golden output for files created in setgid dir Darrick J. Wong
2022-04-19 18:33   ` Zorro Lang
2022-04-19 18:38     ` Darrick J. Wong
2022-04-20 14:47       ` Zorro Lang
2022-04-20 16:03   ` Catherine Hoang
2022-04-19 17:32 ` Darrick J. Wong [this message]
2022-04-19 18:34   ` [PATCH 2/2] generic/019: fix incorrect unset statements Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=165038952637.1677615.2651496553218188517.stgit@magnolia \
    --to=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=guan@eryu.me \
    --cc=guaneryu@gmail.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.