From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59A04C433EF for ; Wed, 20 Apr 2022 10:20:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377574AbiDTKXA (ORCPT ); Wed, 20 Apr 2022 06:23:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377530AbiDTKW6 (ORCPT ); Wed, 20 Apr 2022 06:22:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 302241400E for ; Wed, 20 Apr 2022 03:20:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BBB9061790 for ; Wed, 20 Apr 2022 10:20:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 038FEC385A8; Wed, 20 Apr 2022 10:20:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650450011; bh=/kdrOscUXpoTe8OKXrVoGjhZrmlONVarr3cDpQHst9I=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=r4euG7tA1dKEixKtNEorriN9zHT/PHz65n++wmmdngajFBvjX1BpmR3HS1B3dPmvs ACZgRaO+sTLRl06co6jxBAGu3LelTq4yHaKHEM1KeJ/wBs+FAJGvAsD4E6fMgq5wTr 6ZnzYXjhj60w5lsL1Bj+8+cUUKgdIV7jHj2JYbZBALB3tmeZnmAgXTqL9TZ6jN2IYa vN+NChKpFlgPwqWcQ3HwsrIr8aJiLlxUBB57D2nzj7Xii3XbeUPUtjSTo+zEnEem46 YNRr/+IHFg9WfL5CXNU3E6T1UwiNn3zWi8InFzzv3zTUPS7ssBEebc5l1BTcrAxn0E miEuziuYqydIQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id DC37EE7399D; Wed, 20 Apr 2022 10:20:10 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2 net] net: stmmac: Use readl_poll_timeout_atomic() in atomic state From: patchwork-bot+netdevbpf@kernel.org Message-Id: <165045001089.14273.9231245992154971496.git-patchwork-notify@kernel.org> Date: Wed, 20 Apr 2022 10:20:10 +0000 References: <20220419084226.38340-1-haokexin@gmail.com> In-Reply-To: <20220419084226.38340-1-haokexin@gmail.com> To: Kevin Hao Cc: netdev@vger.kernel.org, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, zhengdejin5@gmail.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Tue, 19 Apr 2022 16:42:26 +0800 you wrote: > The init_systime() may be invoked in atomic state. We have observed the > following call trace when running "phc_ctl /dev/ptp0 set" on a Intel > Agilex board. > BUG: sleeping function called from invalid context at drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c:74 > in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 381, name: phc_ctl > preempt_count: 1, expected: 0 > RCU nest depth: 0, expected: 0 > Preemption disabled at: > [] stmmac_set_time+0x34/0x8c > CPU: 2 PID: 381 Comm: phc_ctl Not tainted 5.18.0-rc2-next-20220414-yocto-standard+ #567 > Hardware name: SoCFPGA Agilex SoCDK (DT) > Call trace: > dump_backtrace.part.0+0xc4/0xd0 > show_stack+0x24/0x40 > dump_stack_lvl+0x7c/0xa0 > dump_stack+0x18/0x34 > __might_resched+0x154/0x1c0 > __might_sleep+0x58/0x90 > init_systime+0x78/0x120 > stmmac_set_time+0x64/0x8c > ptp_clock_settime+0x60/0x9c > pc_clock_settime+0x6c/0xc0 > __arm64_sys_clock_settime+0x88/0xf0 > invoke_syscall+0x5c/0x130 > el0_svc_common.constprop.0+0x4c/0x100 > do_el0_svc+0x7c/0xa0 > el0_svc+0x58/0xcc > el0t_64_sync_handler+0xa4/0x130 > el0t_64_sync+0x18c/0x190 > > [...] Here is the summary with links: - [v2,net] net: stmmac: Use readl_poll_timeout_atomic() in atomic state https://git.kernel.org/netdev/net/c/234901de2bc6 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9685CC433FE for ; Wed, 20 Apr 2022 10:21:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Date: Message-Id:From:Subject:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bLIIAdlLoA3vd0oKbNe+f7OlbX7eLLYd5Uyjvqe8t84=; b=YL2scKXNAB7GvJ pYBCdt+S7i8Kuf08WcHiAZdtGcl45eDG0abJHIq0ocQldH/KchrGptJmLDt7uEEazM4ad5h4PTmNR 6FDBHaXQgXjLnUZDGTPMKUjLBwf/xIx5e83yZMcEn3dSCJQyF8kNfVeS0Hai9jVyd5L8oziv1ugD8 Uc+JgRtqhLz1duUl3X0XRqssV6cUw6OC1BoG+1e7woovXY7vlOEWaWp2YOm50gBDeaqPajBqBR0LE +OjZugRfs13m6O8i2yOKPZ0i7+E4nzVLOm8B7q031LACzZveN45J9dpxJvo/Ht7HhD0W+nYw/6Vzm F3VZeQhqnWH/3oP6v63Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh7RZ-008Wcr-4H; Wed, 20 Apr 2022 10:20:17 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh7RV-008Wc0-KM for linux-arm-kernel@lists.infradead.org; Wed, 20 Apr 2022 10:20:15 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 42EBEB81A62; Wed, 20 Apr 2022 10:20:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 038FEC385A8; Wed, 20 Apr 2022 10:20:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650450011; bh=/kdrOscUXpoTe8OKXrVoGjhZrmlONVarr3cDpQHst9I=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=r4euG7tA1dKEixKtNEorriN9zHT/PHz65n++wmmdngajFBvjX1BpmR3HS1B3dPmvs ACZgRaO+sTLRl06co6jxBAGu3LelTq4yHaKHEM1KeJ/wBs+FAJGvAsD4E6fMgq5wTr 6ZnzYXjhj60w5lsL1Bj+8+cUUKgdIV7jHj2JYbZBALB3tmeZnmAgXTqL9TZ6jN2IYa vN+NChKpFlgPwqWcQ3HwsrIr8aJiLlxUBB57D2nzj7Xii3XbeUPUtjSTo+zEnEem46 YNRr/+IHFg9WfL5CXNU3E6T1UwiNn3zWi8InFzzv3zTUPS7ssBEebc5l1BTcrAxn0E miEuziuYqydIQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id DC37EE7399D; Wed, 20 Apr 2022 10:20:10 +0000 (UTC) MIME-Version: 1.0 Subject: Re: [PATCH v2 net] net: stmmac: Use readl_poll_timeout_atomic() in atomic state From: patchwork-bot+netdevbpf@kernel.org Message-Id: <165045001089.14273.9231245992154971496.git-patchwork-notify@kernel.org> Date: Wed, 20 Apr 2022 10:20:10 +0000 References: <20220419084226.38340-1-haokexin@gmail.com> In-Reply-To: <20220419084226.38340-1-haokexin@gmail.com> To: Kevin Hao Cc: netdev@vger.kernel.org, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, zhengdejin5@gmail.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220420_032013_862243_B2E84A2A X-CRM114-Status: GOOD ( 10.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Tue, 19 Apr 2022 16:42:26 +0800 you wrote: > The init_systime() may be invoked in atomic state. We have observed the > following call trace when running "phc_ctl /dev/ptp0 set" on a Intel > Agilex board. > BUG: sleeping function called from invalid context at drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c:74 > in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 381, name: phc_ctl > preempt_count: 1, expected: 0 > RCU nest depth: 0, expected: 0 > Preemption disabled at: > [] stmmac_set_time+0x34/0x8c > CPU: 2 PID: 381 Comm: phc_ctl Not tainted 5.18.0-rc2-next-20220414-yocto-standard+ #567 > Hardware name: SoCFPGA Agilex SoCDK (DT) > Call trace: > dump_backtrace.part.0+0xc4/0xd0 > show_stack+0x24/0x40 > dump_stack_lvl+0x7c/0xa0 > dump_stack+0x18/0x34 > __might_resched+0x154/0x1c0 > __might_sleep+0x58/0x90 > init_systime+0x78/0x120 > stmmac_set_time+0x64/0x8c > ptp_clock_settime+0x60/0x9c > pc_clock_settime+0x6c/0xc0 > __arm64_sys_clock_settime+0x88/0xf0 > invoke_syscall+0x5c/0x130 > el0_svc_common.constprop.0+0x4c/0x100 > do_el0_svc+0x7c/0xa0 > el0_svc+0x58/0xcc > el0t_64_sync_handler+0xa4/0x130 > el0t_64_sync+0x18c/0x190 > > [...] Here is the summary with links: - [v2,net] net: stmmac: Use readl_poll_timeout_atomic() in atomic state https://git.kernel.org/netdev/net/c/234901de2bc6 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel