From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5862C4332F for ; Thu, 21 Apr 2022 00:06:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383378AbiDUAJd (ORCPT ); Wed, 20 Apr 2022 20:09:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383374AbiDUAJa (ORCPT ); Wed, 20 Apr 2022 20:09:30 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0CD114015 for ; Wed, 20 Apr 2022 17:06:42 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id e62-20020a17090a6fc400b001d2cd8e9b0aso3555089pjk.5 for ; Wed, 20 Apr 2022 17:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gtZMfNzGeYhMURXLY1XiggmvzmJ7zBGBwSixzSCqueo=; b=eBgz4Jdj3KpVL+L3DcDIANI9sXH884X7GMcuZDA3daEecFWtjgBYouZek6J44gsx+L JmUKgRpTPAV6vqC+BoeegczlKhnGF7v6OxI0Cy6QNJk0m4GuTizslzCIWzTcoZ/FMPqd QgpxrMCY8OCJxCNXDrbMqD2dSJMnxvYGTiUyA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gtZMfNzGeYhMURXLY1XiggmvzmJ7zBGBwSixzSCqueo=; b=XqIIHcZ+IDzW1CxsKjLOiFvN20lr+Yc5zynSqgZqSlZHLICORIRLr6trP58GxAAxmK 1f3kFtVc3RjRH9JzcOuks5H4+rW0taFwJ/hgWE5hYO91/xWkFmUfKqrm8JvddqpGNCS+ ua//9R2YhfzCyj1FBqlgv7AYMeFM+G+Crj6b36E3RzyTVjrd5hSAcYW+1S3UpXkgkQ5s 8IPq2+BQpd3XDaRgNJfFT35oq9Zb3x7FD+9lekLvrCOU+XMQvY5jZQvMKWeU9I9zaHx9 gRhDGDBCkPCGuWgXJapuZBgGL65kH21Ovg5vN0HfYqxwD142mvNzA8eBjEzqWlYu1I6J zz4Q== X-Gm-Message-State: AOAM532aLvKwjjKszX/rmvffVKp/1EptFPDBUXdxRpiLjPwDk/6X9VXw dKh7yKNG5ssEPJjn/QHwiFzkiQ== X-Google-Smtp-Source: ABdhPJwUZ02o3o5MBT8n6MGMrt+xN1PWAFYVkoIs5DF8SnTYZwrpdZebjT8ZyRj80drR/SDxakHSUA== X-Received: by 2002:a17:902:ba8e:b0:151:ed65:fda4 with SMTP id k14-20020a170902ba8e00b00151ed65fda4mr23129589pls.127.1650499602483; Wed, 20 Apr 2022 17:06:42 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id f19-20020a17090a639300b001cd4989febasm320094pjj.6.2022.04.20.17.06.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 17:06:42 -0700 (PDT) From: Kees Cook To: ebiederm@xmission.com Cc: Kees Cook , linux-arm-kernel@lists.infradead.org, dalias@libc.org, aou@eecs.berkeley.edu, gerg@linux-m68k.org, geert@linux-m68k.org, vapier@gentoo.org, palmer@dabbelt.com, damien.lemoal@opensource.wdc.com, linux-m68k@lists.linux-m68k.org, linux-riscv@lists.infradead.org, Al Viro , stable@vger.kernel.org, linux-fsdevel@vger.kernel.org, paul.walmsley@sifive.com, ysato@users.sourceforge.jp, Niklas.Cassel@wdc.com, linux-sh@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org Subject: Re: (subset) [PATCH] binfmt_flat: Remove shared library support Date: Wed, 20 Apr 2022 17:05:47 -0700 Message-Id: <165049954506.2420506.9909431091128831748.b4-ty@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <87levzzts4.fsf_-_@email.froward.int.ebiederm.org> References: <20220414091018.896737-1-niklas.cassel@wdc.com> <81788b56-5b15-7308-38c7-c7f2502c4e15@linux-m68k.org> <87levzzts4.fsf_-_@email.froward.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org On Wed, 20 Apr 2022 09:58:03 -0500, Eric W. Biederman wrote: > In a recent discussion[1] it was reported that the binfmt_flat library > support was only ever used on m68k and even on m68k has not been used > in a very long time. > > The structure of binfmt_flat is different from all of the other binfmt > implementations becasue of this shared library support and it made > life and code review more effort when I refactored the code in fs/exec.c. > > [...] It seems like there is agreement that the shared library support is unused, so let's test that assumption. :) With typos fixed up, applied to for-next/execve, thanks! [1/1] binfmt_flat: Remove shared library support https://git.kernel.org/kees/c/c85b5d88951b -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A343C433EF for ; Thu, 21 Apr 2022 00:07:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S1Icmq4SGLeNoBGJxmLYTNX0Ej2zWP2LWl8K2KqI78w=; b=ocgi/OkcQZ68k7 g5fws8NDXxpT2CCy2YBT0fYZ+hMrVNdS63ARz+CKaw5gye2hpZSRJDPgCsI267iSTDg751EAzNoey nEmUxwLlcDUk7jXQ5frAoBOjJU+CUngwdpDXTke3QGjkPU7l2x1Ts0bUtPUw+uQByq7P+t31vumdU G+biQVd0+iGwxun2heYecAEnXHDL4KazqnDKMbuo+RF+mH/y4Fv5Coe/L6l0FE5Ea0C8t2HpyT+Iz 7MwB/aocn76gcr+FJ8jAn+8NusA8+9pGTC3eoNjhhcJmRwo4lSkbK74rwF+/QB1WkTtt7sfnNEYSv Zfuriuq4UpzKStdWF9og==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhKLR-00AwII-A0; Thu, 21 Apr 2022 00:06:49 +0000 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhKLL-00AwFz-Gc for linux-riscv@lists.infradead.org; Thu, 21 Apr 2022 00:06:44 +0000 Received: by mail-pj1-x102e.google.com with SMTP id e62-20020a17090a6fc400b001d2cd8e9b0aso3555088pjk.5 for ; Wed, 20 Apr 2022 17:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gtZMfNzGeYhMURXLY1XiggmvzmJ7zBGBwSixzSCqueo=; b=eBgz4Jdj3KpVL+L3DcDIANI9sXH884X7GMcuZDA3daEecFWtjgBYouZek6J44gsx+L JmUKgRpTPAV6vqC+BoeegczlKhnGF7v6OxI0Cy6QNJk0m4GuTizslzCIWzTcoZ/FMPqd QgpxrMCY8OCJxCNXDrbMqD2dSJMnxvYGTiUyA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gtZMfNzGeYhMURXLY1XiggmvzmJ7zBGBwSixzSCqueo=; b=bGkTOFCaMw7eCGsI7/jioo0QEEl8b94No3PbrX6wUhY2+sWHKNik0YGd9q25VNz2Ex Kfv1y4KpgIQjWUJGwtQfKx1FL6pb3AoSgc1NlIxIlNmcwqVFwfTDPcDHrG+b/x1cMTUo AGAGFySwx1FuGuR4z3ckt9YRe3NqdcnzYkXxGpvDhuCOYKKbNbxDaOmrbPbMzjkDa2PD LejeMINNTstkLPVyzBzt/ykuVYXz4o5dMYu5NH9GP0FEuDSkvhekLupIp63Oo0zAvATZ qPKiVt9OWeZW4/KJ6Vo5n2wkCT9lMEsM4wZPhA9io4bwcFJIdqlV+s3OAnfeB1zvZslY 2dBQ== X-Gm-Message-State: AOAM5330KUtxlv8IhFPxv9qqZyRNr1NNsJJ2XF+ZjT/YBa/mk+iQXUSw 4xEBHuRqY3zGfYKt5QHzTG3dfmBvq3S7aA== X-Google-Smtp-Source: ABdhPJwUZ02o3o5MBT8n6MGMrt+xN1PWAFYVkoIs5DF8SnTYZwrpdZebjT8ZyRj80drR/SDxakHSUA== X-Received: by 2002:a17:902:ba8e:b0:151:ed65:fda4 with SMTP id k14-20020a170902ba8e00b00151ed65fda4mr23129589pls.127.1650499602483; Wed, 20 Apr 2022 17:06:42 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id f19-20020a17090a639300b001cd4989febasm320094pjj.6.2022.04.20.17.06.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 17:06:42 -0700 (PDT) From: Kees Cook To: ebiederm@xmission.com Cc: Kees Cook , linux-arm-kernel@lists.infradead.org, dalias@libc.org, aou@eecs.berkeley.edu, gerg@linux-m68k.org, geert@linux-m68k.org, vapier@gentoo.org, palmer@dabbelt.com, damien.lemoal@opensource.wdc.com, linux-m68k@lists.linux-m68k.org, linux-riscv@lists.infradead.org, Al Viro , stable@vger.kernel.org, linux-fsdevel@vger.kernel.org, paul.walmsley@sifive.com, ysato@users.sourceforge.jp, Niklas.Cassel@wdc.com, linux-sh@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org Subject: Re: (subset) [PATCH] binfmt_flat: Remove shared library support Date: Wed, 20 Apr 2022 17:05:47 -0700 Message-Id: <165049954506.2420506.9909431091128831748.b4-ty@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <87levzzts4.fsf_-_@email.froward.int.ebiederm.org> References: <20220414091018.896737-1-niklas.cassel@wdc.com> <81788b56-5b15-7308-38c7-c7f2502c4e15@linux-m68k.org> <87levzzts4.fsf_-_@email.froward.int.ebiederm.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220420_170643_609922_DF6DBAB8 X-CRM114-Status: GOOD ( 12.39 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, 20 Apr 2022 09:58:03 -0500, Eric W. Biederman wrote: > In a recent discussion[1] it was reported that the binfmt_flat library > support was only ever used on m68k and even on m68k has not been used > in a very long time. > > The structure of binfmt_flat is different from all of the other binfmt > implementations becasue of this shared library support and it made > life and code review more effort when I refactored the code in fs/exec.c. > > [...] It seems like there is agreement that the shared library support is unused, so let's test that assumption. :) With typos fixed up, applied to for-next/execve, thanks! [1/1] binfmt_flat: Remove shared library support https://git.kernel.org/kees/c/c85b5d88951b -- Kees Cook _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C446C433F5 for ; Thu, 21 Apr 2022 00:07:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W9KRleA2ZAI4a7l7oshpse4K/WAWFfVnWlWsNG0io6Y=; b=Ccr1cQMIMUwczI t2C0t5JcQySo9GCmCPWanN2e9Lmmt2VmFm0PyMcksuwEYMNfwfwQB27iM5hFo9AaiTSxfIEN9Zb57 S+L9SctRj7GKjK7yFcJEj7yjp0xCPYWKpRIym0DGZLF5xIspRhWUD23gFClj9dtpj5EvknfwMY7Vz TdkcOX+yrPkhS8Pv29Jm06Qwrv5hoB+PlOMxhAU872mGavQekjECp/l3aHBdUhOXHlOBYhcvBd3ER /HRZMErhOBsLZY/6b0b+V4u+Tjti9+8ZqM2aM1VYb9Zq4FQxwvdC9jbeOBXGDXJpQsxVfwo+l4SuW 9byUiDU4kEtBH4BQLiZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhKLT-00AwJE-A7; Thu, 21 Apr 2022 00:06:51 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhKLL-00AwG0-Rj for linux-arm-kernel@lists.infradead.org; Thu, 21 Apr 2022 00:06:45 +0000 Received: by mail-pj1-x102d.google.com with SMTP id z5-20020a17090a468500b001d2bc2743c4so3611739pjf.0 for ; Wed, 20 Apr 2022 17:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gtZMfNzGeYhMURXLY1XiggmvzmJ7zBGBwSixzSCqueo=; b=eBgz4Jdj3KpVL+L3DcDIANI9sXH884X7GMcuZDA3daEecFWtjgBYouZek6J44gsx+L JmUKgRpTPAV6vqC+BoeegczlKhnGF7v6OxI0Cy6QNJk0m4GuTizslzCIWzTcoZ/FMPqd QgpxrMCY8OCJxCNXDrbMqD2dSJMnxvYGTiUyA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gtZMfNzGeYhMURXLY1XiggmvzmJ7zBGBwSixzSCqueo=; b=SdCoa8oyLK3LqQ7Uy3a0XMIuUjlOXNUjgpxvr9z2z42isXbA96pYRWD5jpPxL1i5wh uCcSns6mkit6EnPrqQLDftMOJvkjZu4CT9XyihNoyJBPYumRmtVfNyBJ8/WV69wSLT5a cErlAR/qozoVUWg1ZLHYoEkkgsfoaylRcPHEwTMKRPwJ6eyzuJJ9rpZsmUu6rNx0BWav Wa8ltunr/7kf+ntbcDbuqVMdVmGsUO10+dxUih653rctQEPMnFeyxiJ/9uGJJ5gJrWpZ kRCsVCnCTTqyZt3v1L9TvqFeOX+VO1G0Za7xvgvQmfn3PGquDS8Zc36rDUqo7GVuwAHR 3zFA== X-Gm-Message-State: AOAM532GYff5GkZcOhQ5g6x0ftNsQrt9/JL/c5d6sr2aUaLRNnXm7G6z 3rwIOJlB4prRhg+NxfiGVawuTQ== X-Google-Smtp-Source: ABdhPJwUZ02o3o5MBT8n6MGMrt+xN1PWAFYVkoIs5DF8SnTYZwrpdZebjT8ZyRj80drR/SDxakHSUA== X-Received: by 2002:a17:902:ba8e:b0:151:ed65:fda4 with SMTP id k14-20020a170902ba8e00b00151ed65fda4mr23129589pls.127.1650499602483; Wed, 20 Apr 2022 17:06:42 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id f19-20020a17090a639300b001cd4989febasm320094pjj.6.2022.04.20.17.06.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 17:06:42 -0700 (PDT) From: Kees Cook To: ebiederm@xmission.com Cc: Kees Cook , linux-arm-kernel@lists.infradead.org, dalias@libc.org, aou@eecs.berkeley.edu, gerg@linux-m68k.org, geert@linux-m68k.org, vapier@gentoo.org, palmer@dabbelt.com, damien.lemoal@opensource.wdc.com, linux-m68k@lists.linux-m68k.org, linux-riscv@lists.infradead.org, Al Viro , stable@vger.kernel.org, linux-fsdevel@vger.kernel.org, paul.walmsley@sifive.com, ysato@users.sourceforge.jp, Niklas.Cassel@wdc.com, linux-sh@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org Subject: Re: (subset) [PATCH] binfmt_flat: Remove shared library support Date: Wed, 20 Apr 2022 17:05:47 -0700 Message-Id: <165049954506.2420506.9909431091128831748.b4-ty@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <87levzzts4.fsf_-_@email.froward.int.ebiederm.org> References: <20220414091018.896737-1-niklas.cassel@wdc.com> <81788b56-5b15-7308-38c7-c7f2502c4e15@linux-m68k.org> <87levzzts4.fsf_-_@email.froward.int.ebiederm.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220420_170643_925116_6EABD24A X-CRM114-Status: GOOD ( 13.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 20 Apr 2022 09:58:03 -0500, Eric W. Biederman wrote: > In a recent discussion[1] it was reported that the binfmt_flat library > support was only ever used on m68k and even on m68k has not been used > in a very long time. > > The structure of binfmt_flat is different from all of the other binfmt > implementations becasue of this shared library support and it made > life and code review more effort when I refactored the code in fs/exec.c. > > [...] It seems like there is agreement that the shared library support is unused, so let's test that assumption. :) With typos fixed up, applied to for-next/execve, thanks! [1/1] binfmt_flat: Remove shared library support https://git.kernel.org/kees/c/c85b5d88951b -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel