All of lore.kernel.org
 help / color / mirror / Atom feed
From: Haowen Bai <baihaowen@meizu.com>
To: <gregkh@linuxfoundation.org>
Cc: <ardb@kernel.org>, <baihaowen@meizu.com>,
	<bjorn.andersson@linaro.org>, <cristian.marussi@arm.com>,
	<linux-kernel@vger.kernel.org>, <sudeep.holla@arm.com>
Subject: [PATCH V2] firmware: edd: Remove redundant condition
Date: Thu, 21 Apr 2022 09:43:13 +0800	[thread overview]
Message-ID: <1650505393-19398-1-git-send-email-baihaowen@meizu.com> (raw)
In-Reply-To: <YmBDgRYGdcjz3ppn@kroah.com>

The logic (!A || (A && B)) is equivalent to (!A || B). so we have
to make code clear.

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
V1->V2: 
change changelog text
1. !A || A && B -> (!A || (A && B))
2. !A || B -> (!A || B)

 drivers/firmware/edd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c
index 69353dd0ea22..5cc238916551 100644
--- a/drivers/firmware/edd.c
+++ b/drivers/firmware/edd.c
@@ -685,8 +685,7 @@ static void edd_populate_dir(struct edd_device * edev)
 	int i;
 
 	for (i = 0; (attr = edd_attrs[i]) && !error; i++) {
-		if (!attr->test ||
-		    (attr->test && attr->test(edev)))
+		if (!attr->test || attr->test(edev))
 			error = sysfs_create_file(&edev->kobj,&attr->attr);
 	}
 
-- 
2.7.4


      parent reply	other threads:[~2022-04-21  1:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tjhedku0cwqypq8pujvusn6i.1647642604045@email.android.com>
2022-04-20 17:31 ` [PATCH] firmware: edd: Remove redundant condition Greg KH
2022-04-21  1:40   ` [PATCH V2] " Haowen Bai
2022-04-21  1:43   ` Haowen Bai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1650505393-19398-1-git-send-email-baihaowen@meizu.com \
    --to=baihaowen@meizu.com \
    --cc=ardb@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=cristian.marussi@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.