From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org, david@fromorbit.com
Cc: Christoph Hellwig <hch@lst.de>,
Dave Chinner <dchinner@redhat.com>,
linux-xfs@vger.kernel.org
Subject: [PATCHSET v2 0/4] xfs: fix rmap inefficiencies
Date: Tue, 26 Apr 2022 17:51:25 -0700 [thread overview]
Message-ID: <165102068549.3922526.15959517253241370597.stgit@magnolia> (raw)
Hi all,
Reduce the performance impact of the reverse mapping btree when reflink
is enabled by using the much faster non-overlapped btree lookup
functions when we're searching the rmap index with a fully specified
key. If we find the exact record we're looking for, great! We don't
have to perform the full overlapped scan. For filesystems with high
sharing factors this reduces the xfs_scrub runtime by a good 15%.
This has been shown to reduce the fstests runtime for realtime rmap
configurations by 30%, since the lack of AGs severely limits
scalability.
v2: simplify the non-overlapped lookup code per dave comments
If you're going to start using this mess, you probably ought to just
pull from my git trees, which are linked below.
This is an extraordinary way to destroy everything. Enjoy!
Comments and questions are, as always, welcome.
--D
kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=rmap-speedups-5.19
---
fs/xfs/libxfs/xfs_rmap.c | 161 +++++++++++++++++++++++++++-------------------
fs/xfs/libxfs/xfs_rmap.h | 7 +-
fs/xfs/scrub/bmap.c | 24 +------
fs/xfs/xfs_trace.h | 5 +
4 files changed, 106 insertions(+), 91 deletions(-)
next reply other threads:[~2022-04-27 0:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 0:51 Darrick J. Wong [this message]
2022-04-27 0:51 ` [PATCH 1/4] xfs: capture buffer ops in the xfs_buf tracepoints Darrick J. Wong
2022-04-27 0:51 ` [PATCH 2/4] xfs: simplify xfs_rmap_lookup_le call sites Darrick J. Wong
2022-04-27 0:51 ` [PATCH 3/4] xfs: speed up rmap lookups by using non-overlapped lookups when possible Darrick J. Wong
2022-04-27 4:19 ` Dave Chinner
2022-04-28 12:44 ` Christoph Hellwig
2022-04-27 0:51 ` [PATCH 4/4] xfs: speed up write operations " Darrick J. Wong
2022-04-27 4:22 ` Dave Chinner
2022-04-28 12:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165102068549.3922526.15959517253241370597.stgit@magnolia \
--to=djwong@kernel.org \
--cc=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.