From: patchwork-bot+netdevbpf@kernel.org
To: Lukas Wunner <lukas@wunner.de>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
hkallweit1@gmail.com, andrew@lunn.ch, linux@armlinux.org.uk,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: phy: Deduplicate interrupt disablement on PHY attach
Date: Fri, 29 Apr 2022 02:10:12 +0000 [thread overview]
Message-ID: <165119821258.31798.4782488207078684684.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <805ccdc606bd8898d59931bd4c7c68537ed6e550.1651040826.git.lukas@wunner.de>
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 27 Apr 2022 08:30:51 +0200 you wrote:
> phy_attach_direct() first calls phy_init_hw() (which restores interrupt
> settings through ->config_intr()), then calls phy_disable_interrupts().
>
> So if phydev->interrupts was previously set to 1, interrupts are briefly
> enabled, then disabled, which seems nonsensical.
>
> If it was previously set to 0, interrupts are disabled twice, which is
> equally nonsensical.
>
> [...]
Here is the summary with links:
- [net-next] net: phy: Deduplicate interrupt disablement on PHY attach
https://git.kernel.org/netdev/net-next/c/07caad0bb1f8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-04-29 2:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 6:30 [PATCH net-next] net: phy: Deduplicate interrupt disablement on PHY attach Lukas Wunner
2022-04-29 0:32 ` Andrew Lunn
2022-04-29 2:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165119821258.31798.4782488207078684684.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukas@wunner.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.