From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25588C433FE for ; Mon, 2 May 2022 16:07:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241311AbiEBQLS (ORCPT ); Mon, 2 May 2022 12:11:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240854AbiEBQLR (ORCPT ); Mon, 2 May 2022 12:11:17 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C349DEAF for ; Mon, 2 May 2022 09:07:47 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id p8so12633340pfh.8 for ; Mon, 02 May 2022 09:07:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:in-reply-to:references:subject:message-id:date :mime-version:content-transfer-encoding; bh=vmp9CQIj1Zs/em4uo2GbHk0NnCqJbYnCBw5TO/vJ0eE=; b=DkgHRwBeptOQUef7LWCd9qKGFhzSbT3Ijmd+WMgxscmZkJoRtExzgWwlapmqlIGmfI mu+FjCmNhJRStsbeODKe5Negvi6KvW6ZBRGPlb5+16I4sOhH9x6y9noeRGSH8ZrOuKnk lnEEBiToVM2DyhbQc53hR6aI53AIhWAPiWyzVYAu+daHb9UzbhIIOk7Vbj5IwoANmyVV Bf/HTXoBhEnIKPYm3UTssLxE+VEM1H8AslebOd37GqDC6JsAZ9QFIcwkMO8ykJR+Vp15 0Xh3qyuHcff8GNtu2J2IGOwEGhwmhwo8o1ZMU8Sinwr1JUi0N4c2NLxgPLv2zZ8Q6bsJ P9XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=vmp9CQIj1Zs/em4uo2GbHk0NnCqJbYnCBw5TO/vJ0eE=; b=IAfPHkjNbUBRfnWN/3RRrR7AZW+5JNn7eVC5QkrlmLIruszOB+Uwq+Y2tBu8XryI3Z pC1sfPnaj/Vw96HM3BpHA8nFgm/PTvDIkJ6NfGtuy/0lAXpCjy62U349yEvFwmOo6xUP AI86k8qHKWLRvDPrGoa7Wuk0VPkZux8B54RoEtM3p/hj6c+8o/OMGtP1u6c9NtMY9avJ 2UqP4nnNoUnv04hsFWXyrrdGXSPuQS55QmPtYVy7g54pN6GDm5JKeluTsNvcyU3lC5K0 7UgqMUavpfWWUmKig3ld0guj1sFMkvV6xI7VfgT3AxvI2iD/x05OPROcHciyyfuZWUC/ BLKg== X-Gm-Message-State: AOAM533l6XRvCxRY/LoqNd4qqLokDIj5FB2mwcRXXl5dnea6E3lamgVi 5BBW406w19RTTVJwoNxLlt+MaHCWLhpMdInE X-Google-Smtp-Source: ABdhPJxN7SayQGlnlRlAnxrbhg/8PgwF1fcHSSb/MBaeXeimsNPqrIIR1crr/+zE4OKE6Nsu7mKRzA== X-Received: by 2002:a05:6a00:1515:b0:50d:bc1a:f7b3 with SMTP id q21-20020a056a00151500b0050dbc1af7b3mr12207502pfu.37.1651507666742; Mon, 02 May 2022 09:07:46 -0700 (PDT) Received: from [127.0.1.1] ([8.34.116.185]) by smtp.gmail.com with ESMTPSA id g25-20020a62e319000000b0050dc7628168sm4883880pfh.66.2022.05.02.09.07.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 May 2022 09:07:46 -0700 (PDT) From: Jens Axboe To: ming.lei@redhat.com Cc: linux-block@vger.kernel.org, Christoph Hellwig , czhong@redhat.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org In-Reply-To: <20220420143110.2679002-1-ming.lei@redhat.com> References: <20220420143110.2679002-1-ming.lei@redhat.com> Subject: Re: [PATCH V2] block: ignore RWF_HIPRI hint for sync dio Message-Id: <165150766572.3972.14278571508374814557.b4-ty@kernel.dk> Date: Mon, 02 May 2022 10:07:45 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, 20 Apr 2022 22:31:10 +0800, Ming Lei wrote: > So far bio is marked as REQ_POLLED if RWF_HIPRI/IOCB_HIPRI is passed > from userspace sync io interface, then block layer tries to poll until > the bio is completed. But the current implementation calls > blk_io_schedule() if bio_poll() returns 0, and this way causes io hang or > timeout easily. > > But looks no one reports this kind of issue, which should have been > triggered in normal io poll sanity test or blktests block/007 as > observed by Changhui, that means it is very likely that no one uses it > or no one cares it. > > [...] Applied, thanks! [1/1] block: ignore RWF_HIPRI hint for sync dio commit: 9650b453a3d4b1b8ed4ea8bcb9b40109608d1faf Best regards, -- Jens Axboe