From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADDF8C433FE for ; Fri, 6 May 2022 01:59:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1388214AbiEFCCq (ORCPT ); Thu, 5 May 2022 22:02:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349212AbiEFCCp (ORCPT ); Thu, 5 May 2022 22:02:45 -0400 Received: from inva020.nxp.com (inva020.nxp.com [92.121.34.13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B836B861; Thu, 5 May 2022 18:59:03 -0700 (PDT) Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 02B5A1A0A38; Fri, 6 May 2022 03:59:02 +0200 (CEST) Received: from aprdc01srsp001v.ap-rdc01.nxp.com (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 933EC1A0A1F; Fri, 6 May 2022 03:59:01 +0200 (CEST) Received: from localhost.localdomain (shlinux2.ap.freescale.net [10.192.224.44]) by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id E090A180031D; Fri, 6 May 2022 09:58:59 +0800 (+08) From: Richard Zhu To: l.stach@pengutronix.de, bhelgaas@google.com, robh+dt@kernel.org, broonie@kernel.org, lorenzo.pieralisi@arm.com, jingoohan1@gmail.com, festevam@gmail.com, francesco.dolcini@toradex.com Cc: hongxing.zhu@nxp.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: [PATCH v9 0/8] PCI: imx6: refine codes and add compliance tests mode support Date: Fri, 6 May 2022 09:47:01 +0800 Message-Id: <1651801629-30223-1-git-send-email-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.7.4 X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series patches refine pci-imx6 driver and do the following main changes. - Encapsulate the clock enable into one standalone function - Add the error propagation from host_init - Disable the regulators and clocks when link never comes up - Add the compliance tests mode support - Move the phy driver callbacks to the proper places Main changes from v8 to v9: - Don't change pcie-designware codes, and do the error exit process only in pci-imx6 driver internally. - Move the phy driver callbacks to the proper places Main changes from v7 to v8: Regarding Bjorn's review comments. - Align the format of the dev_info message and refine commit log of #6/7/8 patches. - Rename the err_reset_phy label, since there is no PHY reset in the out Main changes from v6 to v7: - Keep the regulator usage counter balance in the #5 patch of v6 series. Main changes from v5 to v6: - Refer to the following discussion with Fabio, fix the dump by his patch. https://patchwork.kernel.org/project/linux-pci/patch/1641368602-20401-6-git-send-email-hongxing.zhu@nxp.com/ Refine and rebase this patch-set after Fabio' dump fix patch is merged. - Add one new #4 patch to disable i.MX6QDL REF clock too when disable clocks - Split the regulator refine codes into one standalone patch #5 in this version. Main changes from v4 to v5: - Since i.MX8MM PCIe support had been merged. Based on Lorenzo's git repos, resend the patch-set after rebase. Main changes from v3 to v4: - Regarding Mark's comments, delete the regulator_is_enabled() check. - Squash #3 and #6 of v3 patch into #5 patch of v4 set. Main changes from v2 to v3: - Add "Reviewed-by: Lucas Stach " tag into first two patches. - Add a Fixes tag into #3 patch. - Split the #4 of v2 to two patches, one is clock disable codes move, the other one is the acutal clock unbalance fix. - Add a new host_exit() callback into dw_pcie_host_ops, then it could be invoked to handle the unbalance issue in the error handling after host_init() function when link is down. - Add a new host_exit() callback for i.MX PCIe driver to handle this case in the error handling after host_init. Main changes from v1 to v2: Regarding Lucas' comments. - Move the placement of the new imx6_pcie_clk_enable() to avoid the forward declarition. - Seperate the second patch of v1 patch-set to three patches. - Use the module_param to replace the kernel command line. Regarding Bjorn's comments: - Use the cover-letter for a multi-patch series. - Correct the subject line, and refine the commit logs. For example, remove the timestamp of the logs. drivers/pci/controller/dwc/pci-imx6.c | 277 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------- 1 file changed, 188 insertions(+), 89 deletions(-) [PATCH v9 1/8] PCI: imx6: Encapsulate the clock enable into one [PATCH v9 2/8] PCI: imx6: Add the error propagation from host_init [PATCH v9 3/8] PCI: imx6: Move imx6_pcie_clk_disable() earlier [PATCH v9 4/8] PCI: imx6: Disable iMX6QDL PCIe REF clock when disable [PATCH v9 5/8] PCI: imx6: Refine the regulator usage [PATCH v9 6/8] PCI: imx6: Disable clocks and regulators after link is [PATCH v9 7/8] PCI: imx6: Move the phy driver callbacks to the proper [PATCH v9 8/8] PCI: imx6: Add compliance tests mode support From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94EABC433EF for ; Fri, 6 May 2022 02:00:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=GLXp7/5V0rWS4WarWXqyJlLAr2sOm7rEP5tWXPpuOZU=; b=WwhjAMRdDcTtJE h4nbSHYzAvdBNitMymUuiz7e18T2eVWXa2MEyneTUcnGEMQUJ8oHsZrOyLIo5G1iRFdgiq0f4ddJ2 E03pCgH+/MeVFi+O00i+0lz9AdOqEbuNAjlbhEaiKWyQqL2m2LoVGcNL9AxHofT4EIPoMK6ztXUTS h7sgMZYIA/h0zgvgtRxJWyc0w0fVjjkscjXvAgSGIOS9H+4GSehrI8vLZCHfTiqt66BYKXWtZuxWe 8kpgd1os28GU++jJrcYAsv+A2B0AnDHM/0lglyaTBd9sgVzBhbw4Z9Ha/pxxaD0h0DBroHPJJCJqV 09S4jt0/B4VD1mO0RgNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmnFP-000sd3-8U; Fri, 06 May 2022 01:59:11 +0000 Received: from inva020.nxp.com ([92.121.34.13]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmnFK-000sYW-Nq for linux-arm-kernel@lists.infradead.org; Fri, 06 May 2022 01:59:08 +0000 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 02B5A1A0A38; Fri, 6 May 2022 03:59:02 +0200 (CEST) Received: from aprdc01srsp001v.ap-rdc01.nxp.com (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 933EC1A0A1F; Fri, 6 May 2022 03:59:01 +0200 (CEST) Received: from localhost.localdomain (shlinux2.ap.freescale.net [10.192.224.44]) by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id E090A180031D; Fri, 6 May 2022 09:58:59 +0800 (+08) From: Richard Zhu To: l.stach@pengutronix.de, bhelgaas@google.com, robh+dt@kernel.org, broonie@kernel.org, lorenzo.pieralisi@arm.com, jingoohan1@gmail.com, festevam@gmail.com, francesco.dolcini@toradex.com Cc: hongxing.zhu@nxp.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: [PATCH v9 0/8] PCI: imx6: refine codes and add compliance tests mode support Date: Fri, 6 May 2022 09:47:01 +0800 Message-Id: <1651801629-30223-1-git-send-email-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.7.4 X-Virus-Scanned: ClamAV using ClamSMTP X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220505_185907_083674_964D3CA8 X-CRM114-Status: GOOD ( 14.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This series patches refine pci-imx6 driver and do the following main changes. - Encapsulate the clock enable into one standalone function - Add the error propagation from host_init - Disable the regulators and clocks when link never comes up - Add the compliance tests mode support - Move the phy driver callbacks to the proper places Main changes from v8 to v9: - Don't change pcie-designware codes, and do the error exit process only in pci-imx6 driver internally. - Move the phy driver callbacks to the proper places Main changes from v7 to v8: Regarding Bjorn's review comments. - Align the format of the dev_info message and refine commit log of #6/7/8 patches. - Rename the err_reset_phy label, since there is no PHY reset in the out Main changes from v6 to v7: - Keep the regulator usage counter balance in the #5 patch of v6 series. Main changes from v5 to v6: - Refer to the following discussion with Fabio, fix the dump by his patch. https://patchwork.kernel.org/project/linux-pci/patch/1641368602-20401-6-git-send-email-hongxing.zhu@nxp.com/ Refine and rebase this patch-set after Fabio' dump fix patch is merged. - Add one new #4 patch to disable i.MX6QDL REF clock too when disable clocks - Split the regulator refine codes into one standalone patch #5 in this version. Main changes from v4 to v5: - Since i.MX8MM PCIe support had been merged. Based on Lorenzo's git repos, resend the patch-set after rebase. Main changes from v3 to v4: - Regarding Mark's comments, delete the regulator_is_enabled() check. - Squash #3 and #6 of v3 patch into #5 patch of v4 set. Main changes from v2 to v3: - Add "Reviewed-by: Lucas Stach " tag into first two patches. - Add a Fixes tag into #3 patch. - Split the #4 of v2 to two patches, one is clock disable codes move, the other one is the acutal clock unbalance fix. - Add a new host_exit() callback into dw_pcie_host_ops, then it could be invoked to handle the unbalance issue in the error handling after host_init() function when link is down. - Add a new host_exit() callback for i.MX PCIe driver to handle this case in the error handling after host_init. Main changes from v1 to v2: Regarding Lucas' comments. - Move the placement of the new imx6_pcie_clk_enable() to avoid the forward declarition. - Seperate the second patch of v1 patch-set to three patches. - Use the module_param to replace the kernel command line. Regarding Bjorn's comments: - Use the cover-letter for a multi-patch series. - Correct the subject line, and refine the commit logs. For example, remove the timestamp of the logs. drivers/pci/controller/dwc/pci-imx6.c | 277 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------- 1 file changed, 188 insertions(+), 89 deletions(-) [PATCH v9 1/8] PCI: imx6: Encapsulate the clock enable into one [PATCH v9 2/8] PCI: imx6: Add the error propagation from host_init [PATCH v9 3/8] PCI: imx6: Move imx6_pcie_clk_disable() earlier [PATCH v9 4/8] PCI: imx6: Disable iMX6QDL PCIe REF clock when disable [PATCH v9 5/8] PCI: imx6: Refine the regulator usage [PATCH v9 6/8] PCI: imx6: Disable clocks and regulators after link is [PATCH v9 7/8] PCI: imx6: Move the phy driver callbacks to the proper [PATCH v9 8/8] PCI: imx6: Add compliance tests mode support _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel