* [Intel-gfx] [Intel-gfx 0/6] Update GuC relay logging debugfs
@ 2022-05-09 21:01 Alan Previn
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 1/6] drm/i915/guc: Fix GuC relay log debugfs failing open Alan Previn
` (8 more replies)
0 siblings, 9 replies; 25+ messages in thread
From: Alan Previn @ 2022-05-09 21:01 UTC (permalink / raw)
To: intel-gfx
This series
1. Fixes a bug introduced in GuC Error Capture that
was sharing the memmap of the multi-region GuC
logging buffer.
1. Adds support for unaligned wc memcpy during the
copying of logs to relay channel.
2. Renames the debugfs file for controlling GuC relay
logging to something more discernible.
3. Introduces two debugfs files to allow intel_guc_logger
to read the subbufer-count and subbuffer-size from the
kernel so future changes to buffer sizing in kernel
wont require updating intel_guc_logger codes.
4. Moves the location of the relay-channel debugfs file
to be under the "gt/uc/" path alongside other guc-
id debugfs files.
Alan Previn (6):
drm/i915/guc: Fix GuC relay log debugfs failing open
drm/i915/guc: Add unaligned wc memcpy for copying GuC Log
drm/i915/guc: Add a helper for log buffer size
drm/i915/guc: Provide debugfs for log relay sub-buf info
drm/i915/guc: Rename GuC log relay debugfs descriptively
drm/i915/guc: Move guc_log_relay_chan debugfs path to uc
drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 +
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 75 ++++++++++++-------
drivers/gpu/drm/i915/gt/uc/intel_guc_log.h | 2 +
.../drm/i915/gt/uc/intel_guc_log_debugfs.c | 63 +++++++++++++---
drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c | 2 +
5 files changed, 104 insertions(+), 40 deletions(-)
base-commit: f876385531c7b2509cef8c86a4b6756493f8d457
prerequisite-patch-id: bd289e26be8fba5f456bac9bcf47dceb2e9c4ca9
prerequisite-patch-id: 33c3ec7cd47caab08237ed4ddb299f6d351e74f3
prerequisite-patch-id: 12e1fca75d27bd709dab9e9ca9ffb0126c6dc20d
prerequisite-patch-id: 6ac8d22df34db9e7d467b1ab95ad30f94841d5db
prerequisite-patch-id: f3fa135a3d73937cd923d642d2ad8c0760ac3175
prerequisite-patch-id: 61e40b88ca38aefdc6c17c0e6b83b875a832bc63
prerequisite-patch-id: 6f3232e12fbcf0e0cb312a040a2002de75e70842
prerequisite-patch-id: 46bc9cefd8b30b05c67a5b716d4ed045a62cac14
prerequisite-patch-id: fc2cb39b246060e635341a1afe4b2405ea615948
prerequisite-patch-id: d0869a5b21767338a03d41e31af7317c1166be55
prerequisite-patch-id: 0286c05f8ab431bd64925b533b75554d23403368
prerequisite-patch-id: 0449925cca36664b566f614bfb7d573a11f0575f
prerequisite-patch-id: f7a578825b1efb9df8cf90f5ba3b725bf12ff7f3
prerequisite-patch-id: 2070c8ae646b89fa2db21c1a2e26906dd7220c74
prerequisite-patch-id: 640b750eda1a7327bc7f2a4532ab9a443cc64244
prerequisite-patch-id: 92fdfb264c5c3e5260ac3694fe81861990bcaea0
prerequisite-patch-id: ec6bfb981123156776125f2de8f3168c594346c2
prerequisite-patch-id: 78927aa21ee5861e6b52bef9955747836aeae671
prerequisite-patch-id: 048f14c852ef9cdf345b11d420052d61dbac3f88
prerequisite-patch-id: 40308b701a3e3d1a7e7cf365acb315c17ddbdc5a
prerequisite-patch-id: 8422c8394afa49ad81b6181431eecd2bc58a795c
prerequisite-patch-id: bc581180de3f2f68645b800cb2708b5f6546d1f4
prerequisite-patch-id: 541ce19060961f8fa097b946a306c0e0a4149eaf
prerequisite-patch-id: a803b51482f6e2d9cbda4b483f8520cee51dd337
prerequisite-patch-id: 7792ed4b88b83b05a7111f834a6a0dc78699dbbf
prerequisite-patch-id: 876637bbc5855162282c89a5f12d7c1eff61159d
prerequisite-patch-id: 6abe37df462e54e27d3ae6415297a7e7f64e4eb7
--
2.25.1
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Intel-gfx] [Intel-gfx 1/6] drm/i915/guc: Fix GuC relay log debugfs failing open
2022-05-09 21:01 [Intel-gfx] [Intel-gfx 0/6] Update GuC relay logging debugfs Alan Previn
@ 2022-05-09 21:01 ` Alan Previn
2022-07-19 3:58 ` Dixit, Ashutosh
2022-12-06 8:32 ` Tvrtko Ursulin
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 2/6] drm/i915/guc: Add unaligned wc memcpy for copying GuC Log Alan Previn
` (7 subsequent siblings)
8 siblings, 2 replies; 25+ messages in thread
From: Alan Previn @ 2022-05-09 21:01 UTC (permalink / raw)
To: intel-gfx
When GuC-Error-Capture was introduced, we created
buf_in_use as a way to identify if relay logging
had started. It is meant to replace the previous
method where a mmap of the GuC log buffer was
the indicator but not since GuC Error Capture
shares that mapping throughout operation.
However, that method of checking was not updated
when the debugfs guc_log_relay_ctl_open was called.
Fix that check.
Fixes:
drm/i915/guc: Add capture region into intel_guc_log
(daff407a083d).
Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
Link: https://patchwork.freedesktop.org/patch/479021/?series=101603&rev=1
---
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
index 78d2989fe917..09f4d5fbca82 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
@@ -568,7 +568,7 @@ int intel_guc_log_set_level(struct intel_guc_log *log, u32 level)
bool intel_guc_log_relay_created(const struct intel_guc_log *log)
{
- return log->buf_addr;
+ return log->relay.buf_in_use;
}
int intel_guc_log_relay_open(struct intel_guc_log *log)
--
2.25.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [Intel-gfx] [Intel-gfx 2/6] drm/i915/guc: Add unaligned wc memcpy for copying GuC Log
2022-05-09 21:01 [Intel-gfx] [Intel-gfx 0/6] Update GuC relay logging debugfs Alan Previn
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 1/6] drm/i915/guc: Fix GuC relay log debugfs failing open Alan Previn
@ 2022-05-09 21:01 ` Alan Previn
2022-07-19 17:54 ` Dixit, Ashutosh
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 3/6] drm/i915/guc: Add a helper for log buffer size Alan Previn
` (6 subsequent siblings)
8 siblings, 1 reply; 25+ messages in thread
From: Alan Previn @ 2022-05-09 21:01 UTC (permalink / raw)
To: intel-gfx
Add usage of unaligned wc mempy in read_update_log_buffer
as newer formats of GuC debug-log-events are no longer
guaranteed to be exactly 4-dwords long per event.
Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
index 09f4d5fbca82..d902b40ded0e 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
@@ -301,13 +301,16 @@ static void _guc_log_copy_debuglogs_for_relay(struct intel_guc_log *log)
/* Just copy the newly written data */
if (read_offset > write_offset) {
- i915_memcpy_from_wc(dst_data, src_data, write_offset);
+ if (!i915_memcpy_from_wc(dst_data, src_data, write_offset))
+ i915_unaligned_memcpy_from_wc(dst_data, src_data, write_offset);
bytes_to_copy = buffer_size - read_offset;
} else {
bytes_to_copy = write_offset - read_offset;
}
- i915_memcpy_from_wc(dst_data + read_offset,
- src_data + read_offset, bytes_to_copy);
+ if (!i915_memcpy_from_wc(dst_data + read_offset,
+ src_data + read_offset, bytes_to_copy))
+ i915_unaligned_memcpy_from_wc(dst_data + read_offset,
+ src_data + read_offset, bytes_to_copy);
src_data += buffer_size;
dst_data += buffer_size;
--
2.25.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [Intel-gfx] [Intel-gfx 3/6] drm/i915/guc: Add a helper for log buffer size
2022-05-09 21:01 [Intel-gfx] [Intel-gfx 0/6] Update GuC relay logging debugfs Alan Previn
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 1/6] drm/i915/guc: Fix GuC relay log debugfs failing open Alan Previn
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 2/6] drm/i915/guc: Add unaligned wc memcpy for copying GuC Log Alan Previn
@ 2022-05-09 21:01 ` Alan Previn
2022-07-20 2:49 ` Dixit, Ashutosh
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 4/6] drm/i915/guc: Provide debugfs for log relay sub-buf info Alan Previn
` (5 subsequent siblings)
8 siblings, 1 reply; 25+ messages in thread
From: Alan Previn @ 2022-05-09 21:01 UTC (permalink / raw)
To: intel-gfx
Add a helper to get GuC log buffer size.
Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 49 ++++++++++++----------
1 file changed, 27 insertions(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
index d902b40ded0e..f454d53a8bca 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
@@ -15,6 +15,32 @@
static void guc_log_copy_debuglogs_for_relay(struct intel_guc_log *log);
+static u32 intel_guc_log_size(struct intel_guc_log *log)
+{
+ /*
+ * GuC Log buffer Layout:
+ *
+ * NB: Ordering must follow "enum guc_log_buffer_type".
+ *
+ * +===============================+ 00B
+ * | Debug state header |
+ * +-------------------------------+ 32B
+ * | Crash dump state header |
+ * +-------------------------------+ 64B
+ * | Capture state header |
+ * +-------------------------------+ 96B
+ * | |
+ * +===============================+ PAGE_SIZE (4KB)
+ * | Debug logs |
+ * +===============================+ + DEBUG_SIZE
+ * | Crash Dump logs |
+ * +===============================+ + CRASH_SIZE
+ * | Capture logs |
+ * +===============================+ + CAPTURE_SIZE
+ */
+ return PAGE_SIZE + CRASH_BUFFER_SIZE + DEBUG_BUFFER_SIZE + CAPTURE_BUFFER_SIZE;
+}
+
/**
* DOC: GuC firmware log
*
@@ -464,32 +490,11 @@ int intel_guc_log_create(struct intel_guc_log *log)
GEM_BUG_ON(log->vma);
- /*
- * GuC Log buffer Layout
- * (this ordering must follow "enum guc_log_buffer_type" definition)
- *
- * +===============================+ 00B
- * | Debug state header |
- * +-------------------------------+ 32B
- * | Crash dump state header |
- * +-------------------------------+ 64B
- * | Capture state header |
- * +-------------------------------+ 96B
- * | |
- * +===============================+ PAGE_SIZE (4KB)
- * | Debug logs |
- * +===============================+ + DEBUG_SIZE
- * | Crash Dump logs |
- * +===============================+ + CRASH_SIZE
- * | Capture logs |
- * +===============================+ + CAPTURE_SIZE
- */
if (intel_guc_capture_output_min_size_est(guc) > CAPTURE_BUFFER_SIZE)
DRM_WARN("GuC log buffer for state_capture maybe too small. %d < %d\n",
CAPTURE_BUFFER_SIZE, intel_guc_capture_output_min_size_est(guc));
- guc_log_size = PAGE_SIZE + CRASH_BUFFER_SIZE + DEBUG_BUFFER_SIZE +
- CAPTURE_BUFFER_SIZE;
+ guc_log_size = intel_guc_log_size(log);
vma = intel_guc_allocate_vma(guc, guc_log_size);
if (IS_ERR(vma)) {
--
2.25.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [Intel-gfx] [Intel-gfx 4/6] drm/i915/guc: Provide debugfs for log relay sub-buf info
2022-05-09 21:01 [Intel-gfx] [Intel-gfx 0/6] Update GuC relay logging debugfs Alan Previn
` (2 preceding siblings ...)
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 3/6] drm/i915/guc: Add a helper for log buffer size Alan Previn
@ 2022-05-09 21:01 ` Alan Previn
2022-07-20 3:40 ` Dixit, Ashutosh
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 5/6] drm/i915/guc: Rename GuC log relay debugfs descriptively Alan Previn
` (4 subsequent siblings)
8 siblings, 1 reply; 25+ messages in thread
From: Alan Previn @ 2022-05-09 21:01 UTC (permalink / raw)
To: intel-gfx
In order to provide alignment between IGT intel_guc_logger tool and
i915 kernel's guc log relay channels without requiring updating both
repositories everytime a sizing change is made, provide that info
via debugfs files.
Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 10 ++++-
drivers/gpu/drm/i915/gt/uc/intel_guc_log.h | 2 +
.../drm/i915/gt/uc/intel_guc_log_debugfs.c | 41 +++++++++++++++++++
3 files changed, 51 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
index f454d53a8bca..35709202b09c 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
@@ -15,7 +15,7 @@
static void guc_log_copy_debuglogs_for_relay(struct intel_guc_log *log);
-static u32 intel_guc_log_size(struct intel_guc_log *log)
+u32 intel_guc_log_size(struct intel_guc_log *log)
{
/*
* GuC Log buffer Layout:
@@ -41,6 +41,12 @@ static u32 intel_guc_log_size(struct intel_guc_log *log)
return PAGE_SIZE + CRASH_BUFFER_SIZE + DEBUG_BUFFER_SIZE + CAPTURE_BUFFER_SIZE;
}
+#define GUC_LOG_RELAY_SUBBUF_COUNT 8
+u32 intel_guc_log_relay_subbuf_count(struct intel_guc_log *log)
+{
+ return GUC_LOG_RELAY_SUBBUF_COUNT;
+}
+
/**
* DOC: GuC firmware log
*
@@ -411,7 +417,7 @@ static int guc_log_relay_create(struct intel_guc_log *log)
* latency, for consuming the logs from relay. Also doesn't take
* up too much memory.
*/
- n_subbufs = 8;
+ n_subbufs = intel_guc_log_relay_subbuf_count(log);
guc_log_relay_chan = relay_open("guc_log",
dev_priv->drm.primary->debugfs_root,
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.h b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.h
index 18007e639be9..9e55bd7d2051 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.h
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.h
@@ -73,6 +73,8 @@ unsigned int intel_guc_get_log_buffer_size(enum guc_log_buffer_type type);
size_t intel_guc_get_log_buffer_offset(enum guc_log_buffer_type type);
int intel_guc_log_create(struct intel_guc_log *log);
void intel_guc_log_destroy(struct intel_guc_log *log);
+u32 intel_guc_log_size(struct intel_guc_log *log);
+u32 intel_guc_log_relay_subbuf_count(struct intel_guc_log *log);
int intel_guc_log_set_level(struct intel_guc_log *log, u32 level);
bool intel_guc_log_relay_created(const struct intel_guc_log *log);
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log_debugfs.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log_debugfs.c
index ddfbe334689f..983afc89b17e 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log_debugfs.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log_debugfs.c
@@ -105,10 +105,49 @@ DEFINE_SIMPLE_ATTRIBUTE(guc_log_level_fops,
guc_log_level_get, guc_log_level_set,
"%lld\n");
+static int guc_log_relay_buf_size_get(void *data, u64 *val)
+{
+ struct intel_guc_log *log = data;
+
+ if (!log)
+ return -ENODEV;
+ if (!log->vma)
+ return -ENODEV;
+
+ *val = (u64)intel_guc_log_size(log);
+
+ return 0;
+}
+
+DEFINE_SIMPLE_ATTRIBUTE(guc_log_relay_buf_size_fops,
+ guc_log_relay_buf_size_get, NULL,
+ "%lld\n");
+
+static int guc_log_relay_subbuf_count_get(void *data, u64 *val)
+{
+ struct intel_guc_log *log = data;
+
+ if (!log)
+ return -ENODEV;
+ if (!log->vma)
+ return -ENODEV;
+
+ *val = intel_guc_log_relay_subbuf_count(log);
+
+ return 0;
+}
+
+DEFINE_SIMPLE_ATTRIBUTE(guc_log_relay_subbuf_count_fops,
+ guc_log_relay_subbuf_count_get, NULL,
+ "%lld\n");
+
static int guc_log_relay_open(struct inode *inode, struct file *file)
{
struct intel_guc_log *log = inode->i_private;
+ if (!log)
+ return -ENODEV;
+
if (!intel_guc_is_ready(log_to_guc(log)))
return -ENODEV;
@@ -166,6 +205,8 @@ void intel_guc_log_debugfs_register(struct intel_guc_log *log,
{ "guc_load_err_log_dump", &guc_load_err_log_dump_fops, NULL },
{ "guc_log_level", &guc_log_level_fops, NULL },
{ "guc_log_relay", &guc_log_relay_fops, NULL },
+ { "guc_log_relay_buf_size", &guc_log_relay_buf_size_fops, NULL },
+ { "guc_log_relay_subbuf_count", &guc_log_relay_subbuf_count_fops, NULL },
};
if (!intel_guc_is_supported(log_to_guc(log)))
--
2.25.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [Intel-gfx] [Intel-gfx 5/6] drm/i915/guc: Rename GuC log relay debugfs descriptively
2022-05-09 21:01 [Intel-gfx] [Intel-gfx 0/6] Update GuC relay logging debugfs Alan Previn
` (3 preceding siblings ...)
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 4/6] drm/i915/guc: Provide debugfs for log relay sub-buf info Alan Previn
@ 2022-05-09 21:01 ` Alan Previn
2022-07-20 5:39 ` Dixit, Ashutosh
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 6/6] drm/i915/guc: Move guc_log_relay_chan debugfs path to uc Alan Previn
` (3 subsequent siblings)
8 siblings, 1 reply; 25+ messages in thread
From: Alan Previn @ 2022-05-09 21:01 UTC (permalink / raw)
To: intel-gfx
GuC log relay debugfs name for the control handle vs the actual relay
channel are vague. Fix them so it's obvious from the name.
Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 2 +-
.../drm/i915/gt/uc/intel_guc_log_debugfs.c | 22 +++++++++----------
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
index 35709202b09c..793a06a16874 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
@@ -419,7 +419,7 @@ static int guc_log_relay_create(struct intel_guc_log *log)
*/
n_subbufs = intel_guc_log_relay_subbuf_count(log);
- guc_log_relay_chan = relay_open("guc_log",
+ guc_log_relay_chan = relay_open("guc_log_relay_chan",
dev_priv->drm.primary->debugfs_root,
subbuf_size, n_subbufs,
&relay_callbacks, dev_priv);
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log_debugfs.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log_debugfs.c
index 983afc89b17e..6c5e900c4906 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log_debugfs.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log_debugfs.c
@@ -141,7 +141,7 @@ DEFINE_SIMPLE_ATTRIBUTE(guc_log_relay_subbuf_count_fops,
guc_log_relay_subbuf_count_get, NULL,
"%lld\n");
-static int guc_log_relay_open(struct inode *inode, struct file *file)
+static int guc_log_relay_ctl_open(struct inode *inode, struct file *file)
{
struct intel_guc_log *log = inode->i_private;
@@ -157,10 +157,10 @@ static int guc_log_relay_open(struct inode *inode, struct file *file)
}
static ssize_t
-guc_log_relay_write(struct file *filp,
- const char __user *ubuf,
- size_t cnt,
- loff_t *ppos)
+guc_log_relay_ctl_write(struct file *filp,
+ const char __user *ubuf,
+ size_t cnt,
+ loff_t *ppos)
{
struct intel_guc_log *log = filp->private_data;
int val;
@@ -182,7 +182,7 @@ guc_log_relay_write(struct file *filp,
return ret ?: cnt;
}
-static int guc_log_relay_release(struct inode *inode, struct file *file)
+static int guc_log_relay_ctl_release(struct inode *inode, struct file *file)
{
struct intel_guc_log *log = inode->i_private;
@@ -190,11 +190,11 @@ static int guc_log_relay_release(struct inode *inode, struct file *file)
return 0;
}
-static const struct file_operations guc_log_relay_fops = {
+static const struct file_operations guc_log_relay_ctl_fops = {
.owner = THIS_MODULE,
- .open = guc_log_relay_open,
- .write = guc_log_relay_write,
- .release = guc_log_relay_release,
+ .open = guc_log_relay_ctl_open,
+ .write = guc_log_relay_ctl_write,
+ .release = guc_log_relay_ctl_release,
};
void intel_guc_log_debugfs_register(struct intel_guc_log *log,
@@ -204,7 +204,7 @@ void intel_guc_log_debugfs_register(struct intel_guc_log *log,
{ "guc_log_dump", &guc_log_dump_fops, NULL },
{ "guc_load_err_log_dump", &guc_load_err_log_dump_fops, NULL },
{ "guc_log_level", &guc_log_level_fops, NULL },
- { "guc_log_relay", &guc_log_relay_fops, NULL },
+ { "guc_log_relay_ctl", &guc_log_relay_ctl_fops, NULL },
{ "guc_log_relay_buf_size", &guc_log_relay_buf_size_fops, NULL },
{ "guc_log_relay_subbuf_count", &guc_log_relay_subbuf_count_fops, NULL },
};
--
2.25.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [Intel-gfx] [Intel-gfx 6/6] drm/i915/guc: Move guc_log_relay_chan debugfs path to uc
2022-05-09 21:01 [Intel-gfx] [Intel-gfx 0/6] Update GuC relay logging debugfs Alan Previn
` (4 preceding siblings ...)
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 5/6] drm/i915/guc: Rename GuC log relay debugfs descriptively Alan Previn
@ 2022-05-09 21:01 ` Alan Previn
2022-07-20 19:08 ` Dixit, Ashutosh
2022-05-09 21:25 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Update GuC relay logging debugfs Patchwork
` (2 subsequent siblings)
8 siblings, 1 reply; 25+ messages in thread
From: Alan Previn @ 2022-05-09 21:01 UTC (permalink / raw)
To: intel-gfx
All other GuC Relay Logging debugfs handles including recent
additions are under the 'i915/gt/uc/path' so let's also move
'guc_log_relay_chan' to its proper home.
Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 ++
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 5 ++++-
drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c | 2 ++
3 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
index 3f3373f68123..72deac11df8a 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
@@ -41,6 +41,8 @@ struct intel_guc {
struct intel_guc_slpc slpc;
/** @capture: the error-state-capture module's data and objects */
struct intel_guc_state_capture *capture;
+ /** @dbgfs_node: the debugfs path for guc file handles */
+ struct dentry *dbgfs_node;
/** @sched_engine: Global engine used to submit requests to GuC */
struct i915_sched_engine *sched_engine;
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
index 793a06a16874..f6578565fed6 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
@@ -419,8 +419,11 @@ static int guc_log_relay_create(struct intel_guc_log *log)
*/
n_subbufs = intel_guc_log_relay_subbuf_count(log);
+ if (!guc->dbgfs_node)
+ return -ENOENT;
+
guc_log_relay_chan = relay_open("guc_log_relay_chan",
- dev_priv->drm.primary->debugfs_root,
+ guc->dbgfs_node,
subbuf_size, n_subbufs,
&relay_callbacks, dev_priv);
if (!guc_log_relay_chan) {
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
index 284d6fbc2d08..2f93cc4e408a 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
@@ -54,6 +54,8 @@ void intel_uc_debugfs_register(struct intel_uc *uc, struct dentry *gt_root)
if (IS_ERR(root))
return;
+ uc->guc.dbgfs_node = root;
+
intel_gt_debugfs_register_files(root, files, ARRAY_SIZE(files), uc);
intel_guc_debugfs_register(&uc->guc, root);
--
2.25.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Update GuC relay logging debugfs
2022-05-09 21:01 [Intel-gfx] [Intel-gfx 0/6] Update GuC relay logging debugfs Alan Previn
` (5 preceding siblings ...)
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 6/6] drm/i915/guc: Move guc_log_relay_chan debugfs path to uc Alan Previn
@ 2022-05-09 21:25 ` Patchwork
2022-05-09 21:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-05-10 10:00 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
8 siblings, 0 replies; 25+ messages in thread
From: Patchwork @ 2022-05-09 21:25 UTC (permalink / raw)
To: Alan Previn; +Cc: intel-gfx
== Series Details ==
Series: Update GuC relay logging debugfs
URL : https://patchwork.freedesktop.org/series/103767/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Update GuC relay logging debugfs
2022-05-09 21:01 [Intel-gfx] [Intel-gfx 0/6] Update GuC relay logging debugfs Alan Previn
` (6 preceding siblings ...)
2022-05-09 21:25 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Update GuC relay logging debugfs Patchwork
@ 2022-05-09 21:41 ` Patchwork
2022-05-10 10:00 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
8 siblings, 0 replies; 25+ messages in thread
From: Patchwork @ 2022-05-09 21:41 UTC (permalink / raw)
To: Alan Previn; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 8945 bytes --]
== Series Details ==
Series: Update GuC relay logging debugfs
URL : https://patchwork.freedesktop.org/series/103767/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11626 -> Patchwork_103767v1
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_103767v1 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_103767v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/index.html
Participating hosts (33 -> 40)
------------------------------
Additional (9): bat-dg2-8 bat-adlm-1 bat-dg2-9 bat-adlp-6 bat-adln-1 bat-rpls-1 bat-rpls-2 bat-jsl-2 bat-jsl-1
Missing (2): fi-kbl-soraka fi-bsw-cyan
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_103767v1:
### IGT changes ###
#### Warnings ####
* igt@debugfs_test@read_all_entries:
- fi-apl-guc: [DMESG-WARN][1] ([i915#5595]) -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/fi-apl-guc/igt@debugfs_test@read_all_entries.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/fi-apl-guc/igt@debugfs_test@read_all_entries.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_module_load@reload:
- {bat-rpls-2}: NOTRUN -> [DMESG-WARN][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/bat-rpls-2/igt@i915_module_load@reload.html
* igt@i915_selftest@live@requests:
- {bat-rpls-1}: NOTRUN -> [DMESG-FAIL][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/bat-rpls-1/igt@i915_selftest@live@requests.html
Known issues
------------
Here are the changes found in Patchwork_103767v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@gem:
- fi-pnv-d510: NOTRUN -> [DMESG-FAIL][5] ([i915#4528])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/fi-pnv-d510/igt@i915_selftest@live@gem.html
* igt@i915_selftest@live@gt_pm:
- fi-tgl-1115g4: [PASS][6] -> [DMESG-FAIL][7] ([i915#3987])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/fi-tgl-1115g4/igt@i915_selftest@live@gt_pm.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/fi-tgl-1115g4/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@hangcheck:
- fi-bdw-5557u: NOTRUN -> [INCOMPLETE][8] ([i915#3921])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/fi-bdw-5557u/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@requests:
- fi-blb-e6850: [PASS][9] -> [DMESG-FAIL][10] ([i915#4528])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/fi-blb-e6850/igt@i915_selftest@live@requests.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/fi-blb-e6850/igt@i915_selftest@live@requests.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-snb-2600: NOTRUN -> [SKIP][11] ([fdo#109271] / [fdo#111827])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/fi-snb-2600/igt@kms_chamelium@common-hpd-after-suspend.html
#### Possible fixes ####
* igt@i915_selftest@live@gem_contexts:
- fi-bdw-5557u: [INCOMPLETE][12] ([i915#5502] / [i915#5801]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/fi-bdw-5557u/igt@i915_selftest@live@gem_contexts.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/fi-bdw-5557u/igt@i915_selftest@live@gem_contexts.html
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [INCOMPLETE][14] ([i915#3921]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [DMESG-FAIL][16] ([i915#4528]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/fi-pnv-d510/igt@i915_selftest@live@requests.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/fi-pnv-d510/igt@i915_selftest@live@requests.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3003]: https://gitlab.freedesktop.org/drm/intel/issues/3003
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#3987]: https://gitlab.freedesktop.org/drm/intel/issues/3987
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#5171]: https://gitlab.freedesktop.org/drm/intel/issues/5171
[i915#5174]: https://gitlab.freedesktop.org/drm/intel/issues/5174
[i915#5181]: https://gitlab.freedesktop.org/drm/intel/issues/5181
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5275]: https://gitlab.freedesktop.org/drm/intel/issues/5275
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5502]: https://gitlab.freedesktop.org/drm/intel/issues/5502
[i915#5595]: https://gitlab.freedesktop.org/drm/intel/issues/5595
[i915#5606]: https://gitlab.freedesktop.org/drm/intel/issues/5606
[i915#5703]: https://gitlab.freedesktop.org/drm/intel/issues/5703
[i915#5763]: https://gitlab.freedesktop.org/drm/intel/issues/5763
[i915#5775]: https://gitlab.freedesktop.org/drm/intel/issues/5775
[i915#5801]: https://gitlab.freedesktop.org/drm/intel/issues/5801
[i915#5869]: https://gitlab.freedesktop.org/drm/intel/issues/5869
[i915#5874]: https://gitlab.freedesktop.org/drm/intel/issues/5874
[i915#5879]: https://gitlab.freedesktop.org/drm/intel/issues/5879
Build changes
-------------
* Linux: CI_DRM_11626 -> Patchwork_103767v1
CI-20190529: 20190529
CI_DRM_11626: 1672d1c43e4377628b445ab011343fe2496a41ce @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6468: cffa5fffe9acddf49565b4caeeb5e3355ff2ea44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_103767v1: 1672d1c43e4377628b445ab011343fe2496a41ce @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
15d7f7e8c9dd drm/i915/guc: Move guc_log_relay_chan debugfs path to uc
894adfb03de4 drm/i915/guc: Rename GuC log relay debugfs descriptively
7d7bfd63c19b drm/i915/guc: Provide debugfs for log relay sub-buf info
e50fcfcc0d40 drm/i915/guc: Add a helper for log buffer size
7dbb52d05f01 drm/i915/guc: Add unaligned wc memcpy for copying GuC Log
f91251395de7 drm/i915/guc: Fix GuC relay log debugfs failing open
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/index.html
[-- Attachment #2: Type: text/html, Size: 7379 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for Update GuC relay logging debugfs
2022-05-09 21:01 [Intel-gfx] [Intel-gfx 0/6] Update GuC relay logging debugfs Alan Previn
` (7 preceding siblings ...)
2022-05-09 21:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2022-05-10 10:00 ` Patchwork
2022-05-11 21:45 ` Teres Alexis, Alan Previn
8 siblings, 1 reply; 25+ messages in thread
From: Patchwork @ 2022-05-10 10:00 UTC (permalink / raw)
To: Alan Previn; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 58274 bytes --]
== Series Details ==
Series: Update GuC relay logging debugfs
URL : https://patchwork.freedesktop.org/series/103767/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11626_full -> Patchwork_103767v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_103767v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_103767v1_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (13 -> 13)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_103767v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_pm_dc@dc5-dpms:
- shard-skl: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-skl7/igt@i915_pm_dc@dc5-dpms.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl3/igt@i915_pm_dc@dc5-dpms.html
* igt@i915_pm_dc@dc9-dpms:
- shard-skl: NOTRUN -> [INCOMPLETE][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl7/igt@i915_pm_dc@dc9-dpms.html
* {igt@kms_concurrent@pipe-b@hdmi-a-3} (NEW):
- {shard-dg1}: NOTRUN -> [CRASH][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-dg1-18/igt@kms_concurrent@pipe-b@hdmi-a-3.html
* {igt@kms_plane_scaling@downscale-with-modifier-factor-0-25@pipe-c-hdmi-a-3-downscale-with-modifier} (NEW):
- {shard-dg1}: NOTRUN -> [SKIP][5] +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-dg1-18/igt@kms_plane_scaling@downscale-with-modifier-factor-0-25@pipe-c-hdmi-a-3-downscale-with-modifier.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_eio@in-flight-suspend:
- {shard-dg1}: NOTRUN -> [INCOMPLETE][6]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-dg1-19/igt@gem_eio@in-flight-suspend.html
* igt@kms_concurrent@pipe-c@hdmi-a-1:
- {shard-dg1}: [CRASH][7] ([i915#4886]) -> [FAIL][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-dg1-12/igt@kms_concurrent@pipe-c@hdmi-a-1.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-dg1-15/igt@kms_concurrent@pipe-c@hdmi-a-1.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- {shard-dg1}: NOTRUN -> [FAIL][9] +4 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-dg1-15/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- {shard-dg1}: [PASS][10] -> [FAIL][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-dg1-18/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-dg1-15/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_lease@empty_lease:
- {shard-dg1}: NOTRUN -> [WARN][12]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-dg1-15/igt@kms_lease@empty_lease.html
* igt@kms_plane_scaling@downscale-with-modifier-factor-0-25@pipe-d-hdmi-a-1-downscale-with-modifier:
- {shard-tglu}: NOTRUN -> [SKIP][13] +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-tglu-4/igt@kms_plane_scaling@downscale-with-modifier-factor-0-25@pipe-d-hdmi-a-1-downscale-with-modifier.html
New tests
---------
New tests have been introduced between CI_DRM_11626_full and Patchwork_103767v1_full:
### New IGT tests (5) ###
* igt@kms_concurrent@pipe-b@hdmi-a-3:
- Statuses : 1 crash(s)
- Exec time: [0.03] s
* igt@kms_plane_scaling@downscale-with-modifier-factor-0-25@pipe-a-hdmi-a-3-downscale-with-modifier:
- Statuses : 1 skip(s)
- Exec time: [0.03] s
* igt@kms_plane_scaling@downscale-with-modifier-factor-0-25@pipe-b-hdmi-a-3-downscale-with-modifier:
- Statuses : 1 skip(s)
- Exec time: [0.03] s
* igt@kms_plane_scaling@downscale-with-modifier-factor-0-25@pipe-c-hdmi-a-3-downscale-with-modifier:
- Statuses : 1 skip(s)
- Exec time: [0.03] s
* igt@kms_plane_scaling@downscale-with-modifier-factor-0-25@pipe-d-hdmi-a-3-downscale-with-modifier:
- Statuses : 1 skip(s)
- Exec time: [0.03] s
Known issues
------------
Here are the changes found in Patchwork_103767v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-kbl: NOTRUN -> [DMESG-WARN][14] ([i915#4991])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl6/igt@gem_create@create-massive.html
* igt@gem_ctx_isolation@preservation-s3@vecs0:
- shard-skl: NOTRUN -> [INCOMPLETE][15] ([i915#4939])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl10/igt@gem_ctx_isolation@preservation-s3@vecs0.html
* igt@gem_ctx_persistence@legacy-engines-hostile:
- shard-snb: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#1099])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-snb5/igt@gem_ctx_persistence@legacy-engines-hostile.html
* igt@gem_eio@kms:
- shard-tglb: [PASS][17] -> [FAIL][18] ([i915#5784])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-tglb7/igt@gem_eio@kms.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-tglb3/igt@gem_eio@kms.html
* igt@gem_exec_balancer@parallel:
- shard-kbl: NOTRUN -> [DMESG-WARN][19] ([i915#5076] / [i915#5614])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl6/igt@gem_exec_balancer@parallel.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-skl: NOTRUN -> [SKIP][20] ([fdo#109271]) +114 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl10/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][21] -> [FAIL][22] ([i915#2842])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-iclb4/igt@gem_exec_fair@basic-none-share@rcs0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-iclb2/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][23] -> [FAIL][24] ([i915#2842])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-tglb3/igt@gem_exec_fair@basic-pace-share@rcs0.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-tglb5/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-snb: NOTRUN -> [SKIP][25] ([fdo#109271]) +42 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-snb5/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
* igt@gem_exec_flush@basic-batch-kernel-default-uc:
- shard-snb: [PASS][26] -> [SKIP][27] ([fdo#109271]) +4 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-snb2/igt@gem_exec_flush@basic-batch-kernel-default-uc.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-snb6/igt@gem_exec_flush@basic-batch-kernel-default-uc.html
* igt@gem_lmem_swapping@verify:
- shard-skl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#4613])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl7/igt@gem_lmem_swapping@verify.html
* igt@gem_lmem_swapping@verify-ccs:
- shard-kbl: NOTRUN -> [SKIP][29] ([fdo#109271] / [i915#4613])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl4/igt@gem_lmem_swapping@verify-ccs.html
* igt@gem_userptr_blits@vma-merge:
- shard-kbl: NOTRUN -> [FAIL][30] ([i915#3318])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl4/igt@gem_userptr_blits@vma-merge.html
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: NOTRUN -> [DMESG-WARN][31] ([i915#180])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl6/igt@gem_workarounds@suspend-resume-fd.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][32] -> [DMESG-WARN][33] ([i915#5566] / [i915#716])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-glk4/igt@gen9_exec_parse@allowed-single.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-glk4/igt@gen9_exec_parse@allowed-single.html
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-kbl: NOTRUN -> [FAIL][34] ([i915#2521])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl6/igt@kms_async_flips@alternate-sync-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][35] ([i915#3763])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl7/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#3886])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-apl6/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][37] ([fdo#109271] / [i915#3886]) +5 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl10/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][38] ([fdo#109271] / [i915#3886])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl6/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@dp-edid-read:
- shard-snb: NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-snb5/igt@kms_chamelium@dp-edid-read.html
* igt@kms_chamelium@hdmi-audio-edid:
- shard-apl: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-apl6/igt@kms_chamelium@hdmi-audio-edid.html
* igt@kms_chamelium@hdmi-hpd-for-each-pipe:
- shard-kbl: NOTRUN -> [SKIP][41] ([fdo#109271] / [fdo#111827]) +8 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl4/igt@kms_chamelium@hdmi-hpd-for-each-pipe.html
* igt@kms_chamelium@vga-hpd-after-suspend:
- shard-skl: NOTRUN -> [SKIP][42] ([fdo#109271] / [fdo#111827]) +9 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl7/igt@kms_chamelium@vga-hpd-after-suspend.html
* igt@kms_cursor_crc@pipe-b-cursor-32x32-offscreen:
- shard-apl: NOTRUN -> [SKIP][43] ([fdo#109271]) +13 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-apl6/igt@kms_cursor_crc@pipe-b-cursor-32x32-offscreen.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: NOTRUN -> [FAIL][44] ([i915#2346])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-iclb: [PASS][45] -> [FAIL][46] ([i915#2346])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-iclb4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [PASS][47] -> [FAIL][48] ([i915#2122])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl3/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling:
- shard-iclb: [PASS][49] -> [SKIP][50] ([i915#3701]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-iclb4/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-blt:
- shard-kbl: NOTRUN -> [SKIP][51] ([fdo#109271]) +101 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-blt.html
* igt@kms_hdr@bpc-switch@bpc-switch-edp-1-pipe-a:
- shard-skl: NOTRUN -> [FAIL][52] ([i915#1188])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl7/igt@kms_hdr@bpc-switch@bpc-switch-edp-1-pipe-a.html
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-kbl: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#533])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl6/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html
- shard-skl: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#533])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl10/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-apl: [PASS][55] -> [DMESG-WARN][56] ([i915#180]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-apl8/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-apl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: NOTRUN -> [FAIL][57] ([fdo#108145] / [i915#265])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-kbl: NOTRUN -> [FAIL][58] ([fdo#108145] / [i915#265])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl4/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html
* igt@kms_plane_scaling@downscale-with-modifier-factor-0-5@pipe-c-edp-1-downscale-with-modifier:
- shard-skl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#5176]) +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl7/igt@kms_plane_scaling@downscale-with-modifier-factor-0-5@pipe-c-edp-1-downscale-with-modifier.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1-planes-upscale-downscale:
- shard-iclb: [PASS][60] -> [SKIP][61] ([i915#5235]) +2 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-iclb4/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1-planes-upscale-downscale.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-iclb2/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1-planes-upscale-downscale.html
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-skl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#658])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl7/igt@kms_psr2_su@frontbuffer-xrgb8888.html
* igt@kms_psr2_su@page_flip-p010:
- shard-kbl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#658]) +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl4/igt@kms_psr2_su@page_flip-p010.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [PASS][64] -> [SKIP][65] ([fdo#109441])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-iclb1/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_vblank@pipe-a-accuracy-idle:
- shard-glk: [PASS][66] -> [FAIL][67] ([i915#43])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-glk1/igt@kms_vblank@pipe-a-accuracy-idle.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-glk7/igt@kms_vblank@pipe-a-accuracy-idle.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][68] -> [DMESG-WARN][69] ([i915#180]) +5 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_writeback@writeback-check-output:
- shard-skl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#2437])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl7/igt@kms_writeback@writeback-check-output.html
* igt@kms_writeback@writeback-fb-id:
- shard-kbl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#2437])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl4/igt@kms_writeback@writeback-fb-id.html
* igt@perf@non-zero-reason:
- shard-skl: [PASS][72] -> [FAIL][73] ([i915#2938])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-skl3/igt@perf@non-zero-reason.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl3/igt@perf@non-zero-reason.html
* igt@syncobj_timeline@invalid-transfer-non-existent-point:
- shard-apl: NOTRUN -> [DMESG-WARN][74] ([i915#5098])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-apl6/igt@syncobj_timeline@invalid-transfer-non-existent-point.html
* igt@sysfs_clients@split-50:
- shard-skl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#2994])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl7/igt@sysfs_clients@split-50.html
#### Possible fixes ####
* igt@fbdev@eof:
- {shard-rkl}: [SKIP][76] ([i915#2582]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-5/igt@fbdev@eof.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-rkl-4/igt@fbdev@eof.html
* igt@gem_ctx_persistence@many-contexts:
- {shard-rkl}: [FAIL][78] ([i915#2410]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-2/igt@gem_ctx_persistence@many-contexts.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-rkl-6/igt@gem_ctx_persistence@many-contexts.html
* igt@gem_eio@in-flight-contexts-1us:
- shard-tglb: [TIMEOUT][80] ([i915#3063]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-tglb6/igt@gem_eio@in-flight-contexts-1us.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-tglb8/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_eio@in-flight-suspend:
- shard-kbl: [DMESG-WARN][82] ([i915#180]) -> [PASS][83] +2 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-kbl1/igt@gem_eio@in-flight-suspend.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl6/igt@gem_eio@in-flight-suspend.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [FAIL][84] ([i915#2842]) -> [PASS][85] +2 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-kbl6/igt@gem_exec_fair@basic-none@vcs0.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl3/igt@gem_exec_fair@basic-none@vcs0.html
- shard-glk: [FAIL][86] ([i915#2842]) -> [PASS][87] +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-glk2/igt@gem_exec_fair@basic-none@vcs0.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-glk6/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][88] ([i915#2849]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-iclb1/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_flush@basic-wb-pro-default:
- shard-snb: [SKIP][90] ([fdo#109271]) -> [PASS][91] +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-snb6/igt@gem_exec_flush@basic-wb-pro-default.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-snb7/igt@gem_exec_flush@basic-wb-pro-default.html
* igt@gem_mmap_gtt@fault-concurrent-x:
- shard-snb: [INCOMPLETE][92] ([i915#5161]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-snb5/igt@gem_mmap_gtt@fault-concurrent-x.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-snb5/igt@gem_mmap_gtt@fault-concurrent-x.html
* igt@gem_userptr_blits@stress-mm:
- {shard-rkl}: ([INCOMPLETE][94], [PASS][95]) ([i915#3297]) -> [PASS][96]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-5/igt@gem_userptr_blits@stress-mm.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-5/igt@gem_userptr_blits@stress-mm.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-rkl-5/igt@gem_userptr_blits@stress-mm.html
* igt@gem_workarounds@suspend-resume-fd:
- shard-apl: [DMESG-WARN][97] ([i915#180]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-apl1/igt@gem_workarounds@suspend-resume-fd.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-apl6/igt@gem_workarounds@suspend-resume-fd.html
* igt@gen9_exec_parse@allowed-single:
- shard-kbl: [DMESG-WARN][99] ([i915#5566] / [i915#716]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-kbl6/igt@gen9_exec_parse@allowed-single.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl6/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_backlight@fade_with_dpms:
- {shard-rkl}: [SKIP][101] ([i915#3012]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-1/igt@i915_pm_backlight@fade_with_dpms.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-rkl-6/igt@i915_pm_backlight@fade_with_dpms.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][103] ([i915#3921]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-snb6/igt@i915_selftest@live@hangcheck.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-snb5/igt@i915_selftest@live@hangcheck.html
- shard-tglb: [DMESG-WARN][105] ([i915#5591]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-tglb3/igt@i915_selftest@live@hangcheck.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-tglb5/igt@i915_selftest@live@hangcheck.html
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-tglb: [FAIL][107] ([i915#2521]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-tglb8/igt@kms_async_flips@alternate-sync-async-flip.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-tglb2/igt@kms_async_flips@alternate-sync-async-flip.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-180:
- shard-glk: [FAIL][109] ([i915#1888] / [i915#5138]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-glk1/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-glk9/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- {shard-rkl}: [SKIP][111] ([i915#1845] / [i915#4098]) -> [PASS][112] +17 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-2/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-rkl-6/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- {shard-rkl}: ([SKIP][113], [SKIP][114]) ([i915#1845] / [i915#4098]) -> [PASS][115]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-5/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-5/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-rkl-6/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_color@pipe-a-ctm-green-to-red:
- {shard-rkl}: [SKIP][116] ([i915#1149] / [i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-5/igt@kms_color@pipe-a-ctm-green-to-red.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-rkl-6/igt@kms_color@pipe-a-ctm-green-to-red.html
* igt@kms_cursor_crc@pipe-a-cursor-256x256-rapid-movement:
- {shard-rkl}: [SKIP][118] ([fdo#112022] / [i915#4070]) -> [PASS][119] +5 similar issues
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-1/igt@kms_cursor_crc@pipe-a-cursor-256x256-rapid-movement.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-rkl-6/igt@kms_cursor_crc@pipe-a-cursor-256x256-rapid-movement.html
* igt@kms_cursor_crc@pipe-a-cursor-64x64-rapid-movement:
- shard-glk: [DMESG-WARN][120] ([i915#118]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-glk9/igt@kms_cursor_crc@pipe-a-cursor-64x64-rapid-movement.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-glk2/igt@kms_cursor_crc@pipe-a-cursor-64x64-rapid-movement.html
* igt@kms_cursor_edge_walk@pipe-a-256x256-right-edge:
- {shard-rkl}: [SKIP][122] ([i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][123] +1 similar issue
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-1/igt@kms_cursor_edge_walk@pipe-a-256x256-right-edge.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-rkl-6/igt@kms_cursor_edge_walk@pipe-a-256x256-right-edge.html
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size:
- shard-iclb: [FAIL][124] ([i915#5072]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-iclb7/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-iclb3/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][126] ([i915#2346]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- {shard-rkl}: [SKIP][128] ([fdo#111825] / [i915#4070]) -> [PASS][129] +1 similar issue
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-rkl-6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
- shard-glk: [FAIL][130] ([i915#2346] / [i915#533]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic:
- shard-skl: [FAIL][132] ([i915#2346]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-toggle:
- shard-iclb: [FAIL][134] ([i915#2346]) -> [PASS][135] +1 similar issue
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-iclb3/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html
* igt@kms_cursor_legacy@pipe-c-single-move:
- {shard-rkl}: [SKIP][136] ([i915#4070]) -> [PASS][137]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-6/igt@kms_cursor_legacy@pipe-c-single-move.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-rkl-5/igt@kms_cursor_legacy@pipe-c-single-move.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled:
- {shard-rkl}: [SKIP][138] ([fdo#111314] / [i915#4098] / [i915#4369]) -> [PASS][139] +2 similar issues
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-5/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-rkl-6/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled.html
* igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@c-edp1:
- shard-skl: [FAIL][140] ([i915#2122]) -> [PASS][141] +1 similar issue
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-skl3/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@c-edp1.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl7/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@c-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling:
- shard-iclb: [SKIP][142] ([i915#3701]) -> [PASS][143]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-iclb1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling:
- {shard-rkl}: [SKIP][144] ([i915#3701]) -> [PASS][145]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-5/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-rkl-6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling.html
* igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-wc:
- shard-iclb: [FAIL][146] ([i915#1888] / [i915#2546]) -> [PASS][147]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-wc.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-blt:
- {shard-rkl}: [SKIP][148] ([i915#1849] / [i915#4098]) -> [PASS][149] +22 similar issues
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-1/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-blt.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-blt.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-move:
- {shard-rkl}: ([SKIP][150], [SKIP][151]) ([i915#1849] / [i915#4098]) -> [PASS][152]
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-move.html
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-move.html
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-move.html
* igt@kms_invalid_mode@bad-htotal:
- {shard-rkl}: ([PASS][153], [SKIP][154]) ([i915#4278]) -> [PASS][155]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-6/igt@kms_invalid_mode@bad-htotal.html
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-2/igt@kms_invalid_mode@bad-htotal.html
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-rkl-6/igt@kms_invalid_mode@bad-htotal.html
* igt@kms_invalid_mode@zero-vdisplay:
- {shard-rkl}: [SKIP][156] ([i915#4278]) -> [PASS][157]
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-5/igt@kms_invalid_mode@zero-vdisplay.html
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-rkl-6/igt@kms_invalid_mode@zero-vdisplay.html
* igt@kms_plane@pixel-format-source-clamping@pipe-b-planes:
- {shard-rkl}: [SKIP][158] ([i915#3558]) -> [PASS][159] +1 similar issue
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-1/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-rkl-6/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [FAIL][160] ([fdo#108145] / [i915#265]) -> [PASS][161]
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- {shard-rkl}: [SKIP][162] ([i915#1849] / [i915#3558] / [i915#4070]) -> [PASS][163]
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-5/igt@kms_plane_multiple@atomic-pipe-b-tiling-none.html
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-rkl-6/igt@kms_plane_multiple@atomic-pipe-b-tiling-none.html
* igt@kms_psr@dpms:
- {shard-rkl}: ([SKIP][164], [PASS][165]) ([i915#1072]) -> [PASS][166]
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-5/igt@kms_psr@dpms.html
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-6/igt@kms_psr@dpms.html
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-rkl-6/igt@kms_psr@dpms.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][167] ([fdo#109441]) -> [PASS][168] +2 similar issues
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-iclb4/igt@kms_psr@psr2_primary_page_flip.html
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
* igt@kms_psr@sprite_blt:
- {shard-rkl}: [SKIP][169] ([i915#1072]) -> [PASS][170] +1 similar issue
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-2/igt@kms_psr@sprite_blt.html
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-rkl-6/igt@kms_psr@sprite_blt.html
* igt@kms_rotation_crc@sprite-rotation-270:
- {shard-rkl}: ([PASS][171], [SKIP][172]) ([i915#1845] / [i915#4098]) -> [PASS][173] +1 similar issue
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-6/igt@kms_rotation_crc@sprite-rotation-270.html
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-2/igt@kms_rotation_crc@sprite-rotation-270.html
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-rkl-6/igt@kms_rotation_crc@sprite-rotation-270.html
* igt@kms_universal_plane@universal-plane-gen9-features-pipe-b:
- {shard-rkl}: [SKIP][174] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][175] +1 similar issue
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-rkl-1/igt@kms_universal_plane@universal-plane-gen9-features-pipe-b.html
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-rkl-6/igt@kms_universal_plane@universal-plane-gen9-features-pipe-b.html
* igt@perf@polling-small-buf:
- shard-skl: [FAIL][176] ([i915#1722]) -> [PASS][177]
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-skl7/igt@perf@polling-small-buf.html
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl10/igt@perf@polling-small-buf.html
#### Warnings ####
* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [SKIP][178] ([i915#4525]) -> [DMESG-FAIL][179] ([i915#5614])
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-iclb8/igt@gem_exec_balancer@parallel-ordering.html
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-iclb1/igt@gem_exec_balancer@parallel-ordering.html
* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [SKIP][180] ([i915#4525]) -> [DMESG-WARN][181] ([i915#5614]) +1 similar issue
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-iclb6/igt@gem_exec_balancer@parallel-out-fence.html
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-iclb2/igt@gem_exec_balancer@parallel-out-fence.html
* igt@gen9_exec_parse@bb-large:
- shard-skl: [SKIP][182] ([fdo#109271]) -> [SKIP][183] ([fdo#109271] / [i915#1888])
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-skl10/igt@gen9_exec_parse@bb-large.html
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl4/igt@gen9_exec_parse@bb-large.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][184] ([i915#658]) -> [SKIP][185] ([i915#588])
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-iclb4/igt@i915_pm_dc@dc3co-vpb-simulation.html
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [INCOMPLETE][186] ([i915#180]) -> [FAIL][187] ([i915#4767])
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl4/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [INCOMPLETE][188] ([i915#3614]) -> [DMESG-WARN][189] ([i915#180])
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-kbl3/igt@kms_flip@flip-vs-suspend@c-dp1.html
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl7/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-iclb: [SKIP][190] ([i915#658]) -> [SKIP][191] ([i915#2920])
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-iclb4/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-iclb: [SKIP][192] ([i915#2920]) -> [SKIP][193] ([fdo#111068] / [i915#658])
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-iclb1/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][194], [FAIL][195], [FAIL][196], [FAIL][197], [FAIL][198], [FAIL][199], [FAIL][200], [FAIL][201], [FAIL][202], [FAIL][203], [FAIL][204], [FAIL][205], [FAIL][206], [FAIL][207], [FAIL][208]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#716] / [i915#92]) -> ([FAIL][209], [FAIL][210], [FAIL][211], [FAIL][212], [FAIL][213], [FAIL][214], [FAIL][215], [FAIL][216], [FAIL][217], [FAIL][218], [FAIL][219], [FAIL][220], [FAIL][221], [FAIL][222], [FAIL][223], [FAIL][224]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257])
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-kbl4/igt@runner@aborted.html
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-kbl6/igt@runner@aborted.html
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-kbl1/igt@runner@aborted.html
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-kbl7/igt@runner@aborted.html
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-kbl4/igt@runner@aborted.html
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-kbl6/igt@runner@aborted.html
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-kbl1/igt@runner@aborted.html
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-kbl1/igt@runner@aborted.html
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-kbl4/igt@runner@aborted.html
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-kbl6/igt@runner@aborted.html
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-kbl4/igt@runner@aborted.html
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-kbl1/igt@runner@aborted.html
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-kbl3/igt@runner@aborted.html
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-kbl1/igt@runner@aborted.html
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-kbl1/igt@runner@aborted.html
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl7/igt@runner@aborted.html
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl6/igt@runner@aborted.html
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl7/igt@runner@aborted.html
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl1/igt@runner@aborted.html
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl1/igt@runner@aborted.html
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl6/igt@runner@aborted.html
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl3/igt@runner@aborted.html
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl7/igt@runner@aborted.html
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl6/igt@runner@aborted.html
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl6/igt@runner@aborted.html
[219]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl6/igt@runner@aborted.html
[220]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl6/igt@runner@aborted.html
[221]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl7/igt@runner@aborted.html
[222]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl1/igt@runner@aborted.html
[223]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl1/igt@runner@aborted.html
[224]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-kbl3/igt@runner@aborted.html
### Piglit changes ###
#### Issues hit ####
* spec@arb_pixel_buffer_object@texsubimage pbo:
- pig-glk-j5005: NOTRUN -> [FAIL][225] ([i915#5603])
[225]: None
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110254]: https://bugs.freedesktop.org/show_bug.cgi?id=110254
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112022]: https://bugs.freedesktop.org/show_bug.cgi?id=112022
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2938]: https://gitlab.freedesktop.org/drm/intel/issues/2938
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3319]: https://gitlab.freedesktop.org/drm/intel/issues/3319
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3464]: https://gitlab.freedesktop.org/drm/intel/issues/3464
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3614]: https://gitlab.freedesktop.org/drm/intel/issues/3614
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3701]: https://gitlab.freedesktop.org/drm/intel/issues/3701
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3763]: https://gitlab.freedesktop.org/drm/intel/issues/3763
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3828]: https://gitlab.freedesktop.org/drm/intel/issues/3828
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#3987]: https://gitlab.freedesktop.org/drm/intel/issues/3987
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4278]: https://gitlab.freedesktop.org/drm/intel/issues/4278
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#43]: https://gitlab.freedesktop.org/drm/intel/issues/43
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4807]: https://gitlab.freedesktop.org/drm/intel/issues/4807
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4842]: https://gitlab.freedesktop.org/drm/intel/issues/4842
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4853]: https://gitlab.freedesktop.org/drm/intel/issues/4853
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879
[i915#4886]: https://gitlab.freedesktop.org/drm/intel/issues/4886
[i915#4893]: https://gitlab.freedesktop.org/drm/intel/issues/4893
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5072]: https://gitlab.freedesktop.org/drm/intel/issues/5072
[i915#5076]: https://gitlab.freedesktop.org/drm/intel/issues/5076
[i915#5080]: https://gitlab.freedesktop.org/drm/intel/issues/5080
[i915#5098]: https://gitlab.freedesktop.org/drm/intel/issues/5098
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
[i915#5161]: https://gitlab.freedesktop.org/drm/intel/issues/5161
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5264]: https://gitlab.freedesktop.org/drm/intel/issues/5264
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5357]: https://gitlab.freedesktop.org/drm/intel/issues/5357
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#5603]: https://gitlab.freedesktop.org/drm/intel/issues/5603
[i915#5614]: https://gitlab.freedesktop.org/drm/intel/issues/5614
[i915#5721]: https://gitlab.freedesktop.org/drm/intel/issues/5721
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#5849]: https://gitlab.freedesktop.org/drm/intel/issues/5849
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
Build changes
-------------
* Linux: CI_DRM_11626 -> Patchwork_103767v1
CI-20190529: 20190529
CI_DRM_11626: 1672d1c43e4377628b445ab011343fe2496a41ce @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6468: cffa5fffe9acddf49565b4caeeb5e3355ff2ea44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_103767v1: 1672d1c43e4377628b445ab011343fe2496a41ce @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/index.html
[-- Attachment #2: Type: text/html, Size: 61956 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Update GuC relay logging debugfs
2022-05-10 10:00 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2022-05-11 21:45 ` Teres Alexis, Alan Previn
0 siblings, 0 replies; 25+ messages in thread
From: Teres Alexis, Alan Previn @ 2022-05-11 21:45 UTC (permalink / raw)
To: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 1814 bytes --]
Looking through the log messages, all 4 failures below are not related to the GuC relay logging change of this series. They are all display related.
Two of the failures were on SKL which doesn't have GuC enabled.
Interestingly, all 4 cases, carries multiple different test or subtest failures but the error message when failed was always "-77" (File descriptor in bad state)
On Tue, 2022-05-10 at 10:00 +0000, Patchwork wrote:
Patch Details
Series: Update GuC relay logging debugfs
URL: https://patchwork.freedesktop.org/series/103767/
State: failure
Details: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/index.html
...
Possible new issues
Here are the unknown changes that may have been introduced in Patchwork_103767v1_full:
IGT changes
Possible regressions
* igt@i915_pm_dc@dc5-dpms:
* shard-skl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11626/shard-skl7/igt@i915_pm_dc@dc5-dpms.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl3/igt@i915_pm_dc@dc5-dpms.html>
* igt@i915_pm_dc@dc9-dpms:
* shard-skl: NOTRUN -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-skl7/igt@i915_pm_dc@dc9-dpms.html>
* {igt@kms_concurrent@pipe-b@hdmi-a-3} (NEW):
* {shard-dg1}: NOTRUN -> CRASH<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-dg1-18/igt@kms_concurrent@pipe-b@hdmi-a-3.html>
* {igt@kms_plane_scaling@downscale-with-modifier-factor-0-25@pipe-c-hdmi-a-3-downscale-with-modifier} (NEW):
* {shard-dg1}: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103767v1/shard-dg1-18/igt@kms_plane_scaling@downscale-with-modifier-factor-0-25@pipe-c-hdmi-a-3-downscale-with-modifier.html> +3 similar issues
[-- Attachment #2: Type: text/html, Size: 3042 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [Intel-gfx] [Intel-gfx 1/6] drm/i915/guc: Fix GuC relay log debugfs failing open
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 1/6] drm/i915/guc: Fix GuC relay log debugfs failing open Alan Previn
@ 2022-07-19 3:58 ` Dixit, Ashutosh
2022-12-06 8:32 ` Tvrtko Ursulin
1 sibling, 0 replies; 25+ messages in thread
From: Dixit, Ashutosh @ 2022-07-19 3:58 UTC (permalink / raw)
To: Alan Previn; +Cc: intel-gfx
On Mon, 09 May 2022 14:01:46 -0700, Alan Previn wrote:
>
> When GuC-Error-Capture was introduced, we created
> buf_in_use as a way to identify if relay logging
> had started. It is meant to replace the previous
> method where a mmap of the GuC log buffer was
Let's change mmap to something else since mmap refers to something
different.
> the indicator but not since GuC Error Capture
> shares that mapping throughout operation.
>
> However, that method of checking was not updated
> when the debugfs guc_log_relay_ctl_open was called.
OK guc_log_relay_ctl_open introduced in this series...
The code change itself lgtm, though in general I prefer count's to
bool's.
After tweaking the commit message above this is:
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Fix that check.
>
> Fixes:
> drm/i915/guc: Add capture region into intel_guc_log
> (daff407a083d).
>
> Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
> Link: https://patchwork.freedesktop.org/patch/479021/?series=101603&rev=1
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> index 78d2989fe917..09f4d5fbca82 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> @@ -568,7 +568,7 @@ int intel_guc_log_set_level(struct intel_guc_log *log, u32 level)
>
> bool intel_guc_log_relay_created(const struct intel_guc_log *log)
> {
> - return log->buf_addr;
> + return log->relay.buf_in_use;
> }
>
> int intel_guc_log_relay_open(struct intel_guc_log *log)
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [Intel-gfx] [Intel-gfx 2/6] drm/i915/guc: Add unaligned wc memcpy for copying GuC Log
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 2/6] drm/i915/guc: Add unaligned wc memcpy for copying GuC Log Alan Previn
@ 2022-07-19 17:54 ` Dixit, Ashutosh
0 siblings, 0 replies; 25+ messages in thread
From: Dixit, Ashutosh @ 2022-07-19 17:54 UTC (permalink / raw)
To: Alan Previn; +Cc: intel-gfx
On Mon, 09 May 2022 14:01:47 -0700, Alan Previn wrote:
>
> Add usage of unaligned wc mempy in read_update_log_buffer
> as newer formats of GuC debug-log-events are no longer
> guaranteed to be exactly 4-dwords long per event.
>
> Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> index 09f4d5fbca82..d902b40ded0e 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> @@ -301,13 +301,16 @@ static void _guc_log_copy_debuglogs_for_relay(struct intel_guc_log *log)
>
> /* Just copy the newly written data */
> if (read_offset > write_offset) {
> - i915_memcpy_from_wc(dst_data, src_data, write_offset);
> + if (!i915_memcpy_from_wc(dst_data, src_data, write_offset))
> + i915_unaligned_memcpy_from_wc(dst_data, src_data, write_offset);
> bytes_to_copy = buffer_size - read_offset;
> } else {
> bytes_to_copy = write_offset - read_offset;
> }
> - i915_memcpy_from_wc(dst_data + read_offset,
> - src_data + read_offset, bytes_to_copy);
> + if (!i915_memcpy_from_wc(dst_data + read_offset,
> + src_data + read_offset, bytes_to_copy))
> + i915_unaligned_memcpy_from_wc(dst_data + read_offset,
> + src_data + read_offset, bytes_to_copy);
It should be possible to call i915_unaligned_memcpy_from_wc()
unconditionally? Looks like it would work but not sure of the performance
gain between first attempting an aligned copy and falling back to
unaligned. Assuming there is some, this is:
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [Intel-gfx] [Intel-gfx 3/6] drm/i915/guc: Add a helper for log buffer size
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 3/6] drm/i915/guc: Add a helper for log buffer size Alan Previn
@ 2022-07-20 2:49 ` Dixit, Ashutosh
2022-12-06 1:56 ` Teres Alexis, Alan Previn
0 siblings, 1 reply; 25+ messages in thread
From: Dixit, Ashutosh @ 2022-07-20 2:49 UTC (permalink / raw)
To: Alan Previn; +Cc: intel-gfx
On Mon, 09 May 2022 14:01:48 -0700, Alan Previn wrote:
>
> Add a helper to get GuC log buffer size.
>
> Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 49 ++++++++++++----------
> 1 file changed, 27 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> index d902b40ded0e..f454d53a8bca 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> @@ -15,6 +15,32 @@
>
> static void guc_log_copy_debuglogs_for_relay(struct intel_guc_log *log);
>
> +static u32 intel_guc_log_size(struct intel_guc_log *log)
> +{
> + /*
> + * GuC Log buffer Layout:
> + *
> + * NB: Ordering must follow "enum guc_log_buffer_type".
> + *
> + * +===============================+ 00B
> + * | Debug state header |
> + * +-------------------------------+ 32B
> + * | Crash dump state header |
> + * +-------------------------------+ 64B
> + * | Capture state header |
> + * +-------------------------------+ 96B
> + * | |
> + * +===============================+ PAGE_SIZE (4KB)
> + * | Debug logs |
> + * +===============================+ + DEBUG_SIZE
> + * | Crash Dump logs |
> + * +===============================+ + CRASH_SIZE
> + * | Capture logs |
> + * +===============================+ + CAPTURE_SIZE
> + */
> + return PAGE_SIZE + CRASH_BUFFER_SIZE + DEBUG_BUFFER_SIZE + CAPTURE_BUFFER_SIZE;
> +}
> +
> /**
> * DOC: GuC firmware log
> *
> @@ -464,32 +490,11 @@ int intel_guc_log_create(struct intel_guc_log *log)
>
> GEM_BUG_ON(log->vma);
>
> - /*
> - * GuC Log buffer Layout
> - * (this ordering must follow "enum guc_log_buffer_type" definition)
> - *
> - * +===============================+ 00B
> - * | Debug state header |
> - * +-------------------------------+ 32B
> - * | Crash dump state header |
> - * +-------------------------------+ 64B
> - * | Capture state header |
> - * +-------------------------------+ 96B
> - * | |
> - * +===============================+ PAGE_SIZE (4KB)
> - * | Debug logs |
> - * +===============================+ + DEBUG_SIZE
> - * | Crash Dump logs |
> - * +===============================+ + CRASH_SIZE
> - * | Capture logs |
> - * +===============================+ + CAPTURE_SIZE
> - */
> if (intel_guc_capture_output_min_size_est(guc) > CAPTURE_BUFFER_SIZE)
> DRM_WARN("GuC log buffer for state_capture maybe too small. %d < %d\n",
> CAPTURE_BUFFER_SIZE, intel_guc_capture_output_min_size_est(guc));
>
> - guc_log_size = PAGE_SIZE + CRASH_BUFFER_SIZE + DEBUG_BUFFER_SIZE +
> - CAPTURE_BUFFER_SIZE;
> + guc_log_size = intel_guc_log_size(log);
>
> vma = intel_guc_allocate_vma(guc, guc_log_size);
> if (IS_ERR(vma)) {
My nit-pick suggestions are:
* Call the static function guc_log_size() (don't append intel_ prefix for
static/internal functions)
* Eliminate the guc_log_size variable and just do
* vma = intel_guc_allocate_vma(guc, guc_log_size());
Otherwise this is:
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [Intel-gfx] [Intel-gfx 4/6] drm/i915/guc: Provide debugfs for log relay sub-buf info
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 4/6] drm/i915/guc: Provide debugfs for log relay sub-buf info Alan Previn
@ 2022-07-20 3:40 ` Dixit, Ashutosh
2022-12-06 1:55 ` Teres Alexis, Alan Previn
0 siblings, 1 reply; 25+ messages in thread
From: Dixit, Ashutosh @ 2022-07-20 3:40 UTC (permalink / raw)
To: Alan Previn; +Cc: intel-gfx
On Mon, 09 May 2022 14:01:49 -0700, Alan Previn wrote:
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> index f454d53a8bca..35709202b09c 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> @@ -15,7 +15,7 @@
>
> static void guc_log_copy_debuglogs_for_relay(struct intel_guc_log *log);
>
> -static u32 intel_guc_log_size(struct intel_guc_log *log)
> +u32 intel_guc_log_size(struct intel_guc_log *log)
> {
> /*
> * GuC Log buffer Layout:
> @@ -41,6 +41,12 @@ static u32 intel_guc_log_size(struct intel_guc_log *log)
> return PAGE_SIZE + CRASH_BUFFER_SIZE + DEBUG_BUFFER_SIZE + CAPTURE_BUFFER_SIZE;
> }
>
> +#define GUC_LOG_RELAY_SUBBUF_COUNT 8
> +u32 intel_guc_log_relay_subbuf_count(struct intel_guc_log *log)
> +{
> + return GUC_LOG_RELAY_SUBBUF_COUNT;
> +}
uapi wise, instead of exposing guc_log_size and subbuf_count, why not
expose subbuf_size and subbuf_count?
> +static int guc_log_relay_buf_size_get(void *data, u64 *val)
> +{
> + struct intel_guc_log *log = data;
> +
> + if (!log)
> + return -ENODEV;
> + if (!log->vma)
> + return -ENODEV;
Why are these checks needed? Hasn't log been initialized and attached at
intel_gt_debugfs_register_files()/debugfs_create_file() time itself?
Also if needed let's do:
if (!log || !log->vma)
return -ENODEV;
> +
> + *val = (u64)intel_guc_log_size(log);
> +
> + return 0;
> +}
> +
> +DEFINE_SIMPLE_ATTRIBUTE(guc_log_relay_buf_size_fops,
> + guc_log_relay_buf_size_get, NULL,
> + "%lld\n");
> +
> +static int guc_log_relay_subbuf_count_get(void *data, u64 *val)
> +{
> + struct intel_guc_log *log = data;
> +
> + if (!log)
> + return -ENODEV;
> + if (!log->vma)
> + return -ENODEV;
Same issue as above.
> +
> + *val = intel_guc_log_relay_subbuf_count(log);
> +
> + return 0;
> +}
> +
> +DEFINE_SIMPLE_ATTRIBUTE(guc_log_relay_subbuf_count_fops,
> + guc_log_relay_subbuf_count_get, NULL,
> + "%lld\n");
> +
> static int guc_log_relay_open(struct inode *inode, struct file *file)
> {
> struct intel_guc_log *log = inode->i_private;
>
> + if (!log)
> + return -ENODEV;
> +
Same issue as above.
> if (!intel_guc_is_ready(log_to_guc(log)))
> return -ENODEV;
>
> @@ -166,6 +205,8 @@ void intel_guc_log_debugfs_register(struct intel_guc_log *log,
> { "guc_load_err_log_dump", &guc_load_err_log_dump_fops, NULL },
> { "guc_log_level", &guc_log_level_fops, NULL },
> { "guc_log_relay", &guc_log_relay_fops, NULL },
> + { "guc_log_relay_buf_size", &guc_log_relay_buf_size_fops, NULL },
> + { "guc_log_relay_subbuf_count", &guc_log_relay_subbuf_count_fops, NULL },
> };
>
> if (!intel_guc_is_supported(log_to_guc(log)))
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [Intel-gfx] [Intel-gfx 5/6] drm/i915/guc: Rename GuC log relay debugfs descriptively
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 5/6] drm/i915/guc: Rename GuC log relay debugfs descriptively Alan Previn
@ 2022-07-20 5:39 ` Dixit, Ashutosh
2022-12-06 1:58 ` Teres Alexis, Alan Previn
0 siblings, 1 reply; 25+ messages in thread
From: Dixit, Ashutosh @ 2022-07-20 5:39 UTC (permalink / raw)
To: Alan Previn; +Cc: intel-gfx
On Mon, 09 May 2022 14:01:50 -0700, Alan Previn wrote:
>
> @@ -190,11 +190,11 @@ static int guc_log_relay_release(struct inode *inode, struct file *file)
> return 0;
> }
>
> -static const struct file_operations guc_log_relay_fops = {
> +static const struct file_operations guc_log_relay_ctl_fops = {
> .owner = THIS_MODULE,
> - .open = guc_log_relay_open,
> - .write = guc_log_relay_write,
> - .release = guc_log_relay_release,
> + .open = guc_log_relay_ctl_open,
> + .write = guc_log_relay_ctl_write,
> + .release = guc_log_relay_ctl_release,
> };
>
> void intel_guc_log_debugfs_register(struct intel_guc_log *log,
> @@ -204,7 +204,7 @@ void intel_guc_log_debugfs_register(struct intel_guc_log *log,
> { "guc_log_dump", &guc_log_dump_fops, NULL },
> { "guc_load_err_log_dump", &guc_load_err_log_dump_fops, NULL },
> { "guc_log_level", &guc_log_level_fops, NULL },
> - { "guc_log_relay", &guc_log_relay_fops, NULL },
> + { "guc_log_relay_ctl", &guc_log_relay_ctl_fops, NULL },
Even though debugfs, any issue with changing the file name from the uapi
point of view? Any scripts etc. which will need to be updated?
> { "guc_log_relay_buf_size", &guc_log_relay_buf_size_fops, NULL },
> { "guc_log_relay_subbuf_count", &guc_log_relay_subbuf_count_fops, NULL },
> };
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [Intel-gfx] [Intel-gfx 6/6] drm/i915/guc: Move guc_log_relay_chan debugfs path to uc
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 6/6] drm/i915/guc: Move guc_log_relay_chan debugfs path to uc Alan Previn
@ 2022-07-20 19:08 ` Dixit, Ashutosh
2022-12-06 2:01 ` Teres Alexis, Alan Previn
0 siblings, 1 reply; 25+ messages in thread
From: Dixit, Ashutosh @ 2022-07-20 19:08 UTC (permalink / raw)
To: Alan Previn; +Cc: intel-gfx
On Mon, 09 May 2022 14:01:51 -0700, Alan Previn wrote:
>
> All other GuC Relay Logging debugfs handles including recent
> additions are under the 'i915/gt/uc/path' so let's also move
> 'guc_log_relay_chan' to its proper home.
>
> Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 ++
> drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 5 ++++-
> drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c | 2 ++
> 3 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> index 3f3373f68123..72deac11df8a 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> @@ -41,6 +41,8 @@ struct intel_guc {
> struct intel_guc_slpc slpc;
> /** @capture: the error-state-capture module's data and objects */
> struct intel_guc_state_capture *capture;
> + /** @dbgfs_node: the debugfs path for guc file handles */
> + struct dentry *dbgfs_node;
>
> /** @sched_engine: Global engine used to submit requests to GuC */
> struct i915_sched_engine *sched_engine;
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> index 793a06a16874..f6578565fed6 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> @@ -419,8 +419,11 @@ static int guc_log_relay_create(struct intel_guc_log *log)
> */
> n_subbufs = intel_guc_log_relay_subbuf_count(log);
>
> + if (!guc->dbgfs_node)
> + return -ENOENT;
Once again, why is this check needed? The patch is otherwise fine.
> +
> guc_log_relay_chan = relay_open("guc_log_relay_chan",
> - dev_priv->drm.primary->debugfs_root,
> + guc->dbgfs_node,
> subbuf_size, n_subbufs,
> &relay_callbacks, dev_priv);
> if (!guc_log_relay_chan) {
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> index 284d6fbc2d08..2f93cc4e408a 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> @@ -54,6 +54,8 @@ void intel_uc_debugfs_register(struct intel_uc *uc, struct dentry *gt_root)
> if (IS_ERR(root))
> return;
>
> + uc->guc.dbgfs_node = root;
> +
> intel_gt_debugfs_register_files(root, files, ARRAY_SIZE(files), uc);
>
> intel_guc_debugfs_register(&uc->guc, root);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [Intel-gfx] [Intel-gfx 4/6] drm/i915/guc: Provide debugfs for log relay sub-buf info
2022-07-20 3:40 ` Dixit, Ashutosh
@ 2022-12-06 1:55 ` Teres Alexis, Alan Previn
2022-12-07 6:00 ` Dixit, Ashutosh
0 siblings, 1 reply; 25+ messages in thread
From: Teres Alexis, Alan Previn @ 2022-12-06 1:55 UTC (permalink / raw)
To: Dixit, Ashutosh; +Cc: intel-gfx
It's been a while - trying to resurrect this now.
On Tue, 2022-07-19 at 20:40 -0700, Dixit, Ashutosh wrote:
> On Mon, 09 May 2022 14:01:49 -0700, Alan Previn wrote:
> >
> >
Alan: [snip]
> > +#define GUC_LOG_RELAY_SUBBUF_COUNT 8
> > +u32 intel_guc_log_relay_subbuf_count(struct intel_guc_log *log)
> > +{
> > + return GUC_LOG_RELAY_SUBBUF_COUNT;
> > +}
>
> uapi wise, instead of exposing guc_log_size and subbuf_count, why not
> expose subbuf_size and subbuf_count?
To combine addressing your request + consistency with existing knobs (all of which are dedicated for guc-relay-logging),
I'll go ahead and change it to guc_log_relay_subbuf_size_get and guc_log_relay_subbuf_count_get.
>
> > +static int guc_log_relay_buf_size_get(void *data, u64 *val)
> > +{
> > + struct intel_guc_log *log = data;
> > +
> > + if (!log)
> > + return -ENODEV;
> > + if (!log->vma)
> > + return -ENODEV;
>
> Why are these checks needed? Hasn't log been initialized and attached at
> intel_gt_debugfs_register_files()/debugfs_create_file() time itself?
>
> Also if needed let's do:
>
> if (!log || !log->vma)
> return -ENODEV;
>
Alan: You are right, we don't to check log but might need to check log->vma: its been a long time - i can vaguely
remember but i recall some weird behavior if the user space was holding on to relay logging handles and still calling in
while driver is being unloaded. I'll have to retest this and see if its something to care about or consider as a user
error. But even there, we can shorten it to if(!log->vma) as the minimum. (of course even if there was a bug, the
debugfs path should eventually get released as part of the i915 unload but just a tiny bit later after the guc resources
are freed). Same comment here applies to two more comments you provided. Needs to be tested.
>
Alan: [snip]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [Intel-gfx] [Intel-gfx 3/6] drm/i915/guc: Add a helper for log buffer size
2022-07-20 2:49 ` Dixit, Ashutosh
@ 2022-12-06 1:56 ` Teres Alexis, Alan Previn
0 siblings, 0 replies; 25+ messages in thread
From: Teres Alexis, Alan Previn @ 2022-12-06 1:56 UTC (permalink / raw)
To: Dixit, Ashutosh; +Cc: intel-gfx
On Tue, 2022-07-19 at 19:49 -0700, Dixit, Ashutosh wrote:
> On Mon, 09 May 2022 14:01:48 -0700, Alan Previn wrote:
> >
Alan: [snip]
Alan: This patch is not needed any longer because it was also part of another re-factor related to error-capture and
debug-log-sizing management changes that got merged earlier this year.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [Intel-gfx] [Intel-gfx 5/6] drm/i915/guc: Rename GuC log relay debugfs descriptively
2022-07-20 5:39 ` Dixit, Ashutosh
@ 2022-12-06 1:58 ` Teres Alexis, Alan Previn
0 siblings, 0 replies; 25+ messages in thread
From: Teres Alexis, Alan Previn @ 2022-12-06 1:58 UTC (permalink / raw)
To: Dixit, Ashutosh; +Cc: intel-gfx
>
Alan:snip
>
> > void intel_guc_log_debugfs_register(struct intel_guc_log *log,
> > @@ -204,7 +204,7 @@ void intel_guc_log_debugfs_register(struct intel_guc_log *log,
> > { "guc_log_dump", &guc_log_dump_fops, NULL },
> > { "guc_load_err_log_dump", &guc_load_err_log_dump_fops, NULL },
> > { "guc_log_level", &guc_log_level_fops, NULL },
> > - { "guc_log_relay", &guc_log_relay_fops, NULL },
> > + { "guc_log_relay_ctl", &guc_log_relay_ctl_fops, NULL },
>
> Even though debugfs, any issue with changing the file name from the uapi
> point of view? Any scripts etc. which will need to be updated?
>
>
Alan: Actually, relay logging tool in the IGT would need to change but upstream version of that tool has been broken for
a long while now nothing new can break on top of above change. I didnt see any other comments on this patch - let me
know if missed something else - as i will attempt to post this again tonight.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [Intel-gfx] [Intel-gfx 6/6] drm/i915/guc: Move guc_log_relay_chan debugfs path to uc
2022-07-20 19:08 ` Dixit, Ashutosh
@ 2022-12-06 2:01 ` Teres Alexis, Alan Previn
2022-12-06 6:08 ` Teres Alexis, Alan Previn
0 siblings, 1 reply; 25+ messages in thread
From: Teres Alexis, Alan Previn @ 2022-12-06 2:01 UTC (permalink / raw)
To: Dixit, Ashutosh; +Cc: intel-gfx
On Wed, 2022-07-20 at 12:08 -0700, Dixit, Ashutosh wrote:
> On Mon, 09 May 2022 14:01:51 -0700, Alan Previn wrote:
> >
> > All other GuC Relay Logging debugfs handles including recent
> > additions are under the 'i915/gt/uc/path' so let's also move
> > 'guc_log_relay_chan' to its proper home
Alan:[snip]
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > index 793a06a16874..f6578565fed6 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > @@ -419,8 +419,11 @@ static int guc_log_relay_create(struct intel_guc_log *log)
> > */
> > n_subbufs = intel_guc_log_relay_subbuf_count(log);
> >
> > + if (!guc->dbgfs_node)
> > + return -ENOENT;
>
> Once again, why is this check needed? The patch is otherwise fine.
>
Because on i915 upstream today, we do have a code path where that dbgfs_node is not being populated and i assume that
would be the case if config file disables debugfs? And without that we don't support guc-relay-logging.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [Intel-gfx] [Intel-gfx 6/6] drm/i915/guc: Move guc_log_relay_chan debugfs path to uc
2022-12-06 2:01 ` Teres Alexis, Alan Previn
@ 2022-12-06 6:08 ` Teres Alexis, Alan Previn
0 siblings, 0 replies; 25+ messages in thread
From: Teres Alexis, Alan Previn @ 2022-12-06 6:08 UTC (permalink / raw)
To: Dixit, Ashutosh; +Cc: intel-gfx
On Mon, 2022-12-05 at 18:04 -0800, Alan Previn Teres Alexis wrote:
> On Wed, 2022-07-20 at 12:08 -0700, Dixit, Ashutosh wrote:
> > On Mon, 09 May 2022 14:01:51 -0700, Alan Previn wrote:
> > >
> > > All other GuC Relay Logging debugfs handles including recent
> > > additions are under the 'i915/gt/uc/path' so let's also move
> > > 'guc_log_relay_chan' to its proper home
> Alan:[snip]
>
> > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > > index 793a06a16874..f6578565fed6 100644
> > > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > > @@ -419,8 +419,11 @@ static int guc_log_relay_create(struct intel_guc_log *log)
> > > */
> > > n_subbufs = intel_guc_log_relay_subbuf_count(log);
> > >
> > > + if (!guc->dbgfs_node)
> > > + return -ENOENT;
> >
> > Once again, why is this check needed? The patch is otherwise fine.
> >
>
> Because on i915 upstream today, we do have a code path where that dbgfs_node is not being populated and i assume that
> would be the case if config file disables debugfs? And without that we don't support guc-relay-logging.
>
Alan: Scratch that - its not needed.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [Intel-gfx] [Intel-gfx 1/6] drm/i915/guc: Fix GuC relay log debugfs failing open
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 1/6] drm/i915/guc: Fix GuC relay log debugfs failing open Alan Previn
2022-07-19 3:58 ` Dixit, Ashutosh
@ 2022-12-06 8:32 ` Tvrtko Ursulin
2022-12-06 8:35 ` Tvrtko Ursulin
1 sibling, 1 reply; 25+ messages in thread
From: Tvrtko Ursulin @ 2022-12-06 8:32 UTC (permalink / raw)
To: Alan Previn, intel-gfx
On 09/05/2022 22:01, Alan Previn wrote:
> When GuC-Error-Capture was introduced, we created
> buf_in_use as a way to identify if relay logging
> had started. It is meant to replace the previous
> method where a mmap of the GuC log buffer was
> the indicator but not since GuC Error Capture
> shares that mapping throughout operation.
>
> However, that method of checking was not updated
> when the debugfs guc_log_relay_ctl_open was called.
> Fix that check.
>
> Fixes:
> drm/i915/guc: Add capture region into intel_guc_log
> (daff407a083d).
Wrong format of fixes tag - if you want this picked up by any of the
automated tooling, it won't be. (And you probably do given DG2 is out of
force probe.)
Regards,
Tvrtko
> Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
> Link: https://patchwork.freedesktop.org/patch/479021/?series=101603&rev=1
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> index 78d2989fe917..09f4d5fbca82 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> @@ -568,7 +568,7 @@ int intel_guc_log_set_level(struct intel_guc_log *log, u32 level)
>
> bool intel_guc_log_relay_created(const struct intel_guc_log *log)
> {
> - return log->buf_addr;
> + return log->relay.buf_in_use;
> }
>
> int intel_guc_log_relay_open(struct intel_guc_log *log)
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [Intel-gfx] [Intel-gfx 1/6] drm/i915/guc: Fix GuC relay log debugfs failing open
2022-12-06 8:32 ` Tvrtko Ursulin
@ 2022-12-06 8:35 ` Tvrtko Ursulin
0 siblings, 0 replies; 25+ messages in thread
From: Tvrtko Ursulin @ 2022-12-06 8:35 UTC (permalink / raw)
To: Alan Previn, intel-gfx
On 06/12/2022 08:32, Tvrtko Ursulin wrote:
>
> On 09/05/2022 22:01, Alan Previn wrote:
>> When GuC-Error-Capture was introduced, we created
>> buf_in_use as a way to identify if relay logging
>> had started. It is meant to replace the previous
>> method where a mmap of the GuC log buffer was
>> the indicator but not since GuC Error Capture
>> shares that mapping throughout operation.
>>
>> However, that method of checking was not updated
>> when the debugfs guc_log_relay_ctl_open was called.
>> Fix that check.
>>
>> Fixes:
>> drm/i915/guc: Add capture region into intel_guc_log
>> (daff407a083d).
>
> Wrong format of fixes tag - if you want this picked up by any of the
> automated tooling, it won't be. (And you probably do given DG2 is out of
> force probe.)
ENOCOFFEE - replying to re-surrected ancient thread so I guess this does
not matter any more.
Regards,
Tvrtko
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [Intel-gfx] [Intel-gfx 4/6] drm/i915/guc: Provide debugfs for log relay sub-buf info
2022-12-06 1:55 ` Teres Alexis, Alan Previn
@ 2022-12-07 6:00 ` Dixit, Ashutosh
0 siblings, 0 replies; 25+ messages in thread
From: Dixit, Ashutosh @ 2022-12-07 6:00 UTC (permalink / raw)
To: Teres Alexis, Alan Previn; +Cc: intel-gfx
On Mon, 05 Dec 2022 17:55:20 -0800, Teres Alexis, Alan Previn wrote:
>
Hi Alan,
> It's been a while - trying to resurrect this now.
>
> On Tue, 2022-07-19 at 20:40 -0700, Dixit, Ashutosh wrote:
> > On Mon, 09 May 2022 14:01:49 -0700, Alan Previn wrote:
> > >
> > >
> Alan: [snip]
>
> > > +#define GUC_LOG_RELAY_SUBBUF_COUNT 8
> > > +u32 intel_guc_log_relay_subbuf_count(struct intel_guc_log *log)
> > > +{
> > > + return GUC_LOG_RELAY_SUBBUF_COUNT;
> > > +}
> >
> > uapi wise, instead of exposing guc_log_size and subbuf_count, why not
> > expose subbuf_size and subbuf_count?
>
> To combine addressing your request + consistency with existing knobs (all
> of which are dedicated for guc-relay-logging), I'll go ahead and change
> it to guc_log_relay_subbuf_size_get and guc_log_relay_subbuf_count_get.
OK, great!
> >
> > > +static int guc_log_relay_buf_size_get(void *data, u64 *val)
> > > +{
> > > + struct intel_guc_log *log = data;
> > > +
> > > + if (!log)
> > > + return -ENODEV;
> > > + if (!log->vma)
> > > + return -ENODEV;
> >
> > Why are these checks needed? Hasn't log been initialized and attached at
> > intel_gt_debugfs_register_files()/debugfs_create_file() time itself?
> >
> > Also if needed let's do:
> >
> > if (!log || !log->vma)
> > return -ENODEV;
> >
> Alan: You are right, we don't to check log but might need to check
> log->vma: its been a long time - i can vaguely remember but i recall some
> weird behavior if the user space was holding on to relay logging handles
> and still calling in while driver is being unloaded. I'll have to retest
> this and see if its something to care about or consider as a user
> error. But even there, we can shorten it to if(!log->vma) as the
> minimum. (of course even if there was a bug, the debugfs path should
> eventually get released as part of the i915 unload but just a tiny bit
> later after the guc resources are freed). Same comment here applies to
> two more comments you provided. Needs to be tested.
So did you test this before sending out the latest series? Or does this
still have to be done? I am holding off on this patch till I hear about
this.
Thanks.
--
Ashutosh
>
> >
> Alan: [snip]
^ permalink raw reply [flat|nested] 25+ messages in thread
end of thread, other threads:[~2022-12-07 6:05 UTC | newest]
Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-09 21:01 [Intel-gfx] [Intel-gfx 0/6] Update GuC relay logging debugfs Alan Previn
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 1/6] drm/i915/guc: Fix GuC relay log debugfs failing open Alan Previn
2022-07-19 3:58 ` Dixit, Ashutosh
2022-12-06 8:32 ` Tvrtko Ursulin
2022-12-06 8:35 ` Tvrtko Ursulin
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 2/6] drm/i915/guc: Add unaligned wc memcpy for copying GuC Log Alan Previn
2022-07-19 17:54 ` Dixit, Ashutosh
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 3/6] drm/i915/guc: Add a helper for log buffer size Alan Previn
2022-07-20 2:49 ` Dixit, Ashutosh
2022-12-06 1:56 ` Teres Alexis, Alan Previn
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 4/6] drm/i915/guc: Provide debugfs for log relay sub-buf info Alan Previn
2022-07-20 3:40 ` Dixit, Ashutosh
2022-12-06 1:55 ` Teres Alexis, Alan Previn
2022-12-07 6:00 ` Dixit, Ashutosh
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 5/6] drm/i915/guc: Rename GuC log relay debugfs descriptively Alan Previn
2022-07-20 5:39 ` Dixit, Ashutosh
2022-12-06 1:58 ` Teres Alexis, Alan Previn
2022-05-09 21:01 ` [Intel-gfx] [Intel-gfx 6/6] drm/i915/guc: Move guc_log_relay_chan debugfs path to uc Alan Previn
2022-07-20 19:08 ` Dixit, Ashutosh
2022-12-06 2:01 ` Teres Alexis, Alan Previn
2022-12-06 6:08 ` Teres Alexis, Alan Previn
2022-05-09 21:25 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Update GuC relay logging debugfs Patchwork
2022-05-09 21:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-05-10 10:00 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-05-11 21:45 ` Teres Alexis, Alan Previn
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.