[PATCH net-next] selftests: forwarding: tc_actions: allow mirred egress test to run on non-offloaded h2

[PATCH net-next] selftests: forwarding: tc_actions: allow mirred egress test to run on non-offloaded h2

[Vladimir Oltean]

The host interfaces $h1 and $h2 don't have to be switchdev interfaces,
but due to the fact that we pass $tcflags which may have the value of
"skip_sw", we force $h2 to offload a drop rule for dst_ip, something
which it may not be able to do.

The selftest only wants to verify the hit count of this rule as a means
of figuring out whether the packet was received, so remove the $tcflags
for it and let it be done in software.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 tools/testing/selftests/net/forwarding/tc_actions.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/forwarding/tc_actions.sh b/tools/testing/selftests/net/forwarding/tc_actions.sh
index de19eb6c38f0..1e0a62f638fe 100755
--- a/tools/testing/selftests/net/forwarding/tc_actions.sh
+++ b/tools/testing/selftests/net/forwarding/tc_actions.sh
@@ -60,7 +60,7 @@ mirred_egress_test()
 	RET=0
 
 	tc filter add dev $h2 ingress protocol ip pref 1 handle 101 flower \
-		$tcflags dst_ip 192.0.2.2 action drop
+		dst_ip 192.0.2.2 action drop
 
 	$MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac -A 192.0.2.1 -B 192.0.2.2 \
 		-t ip -q
-- 
2.25.1

Re: [PATCH net-next] selftests: forwarding: tc_actions: allow mirred egress test to run on non-offloaded h2

[Ido Schimmel]

On Wed, May 11, 2022 at 01:09:04AM +0300, Vladimir Oltean wrote:
> The host interfaces $h1 and $h2 don't have to be switchdev interfaces,
> but due to the fact that we pass $tcflags which may have the value of
> "skip_sw", we force $h2 to offload a drop rule for dst_ip, something
> which it may not be able to do.
> 
> The selftest only wants to verify the hit count of this rule as a means
> of figuring out whether the packet was received, so remove the $tcflags
> for it and let it be done in software.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>

Re: [PATCH net-next] selftests: forwarding: tc_actions: allow mirred egress test to run on non-offloaded h2

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 11 May 2022 01:09:04 +0300 you wrote:
> The host interfaces $h1 and $h2 don't have to be switchdev interfaces,
> but due to the fact that we pass $tcflags which may have the value of
> "skip_sw", we force $h2 to offload a drop rule for dst_ip, something
> which it may not be able to do.
> 
> The selftest only wants to verify the hit count of this rule as a means
> of figuring out whether the packet was received, so remove the $tcflags
> for it and let it be done in software.
> 
> [...]

Here is the summary with links:
  - [net-next] selftests: forwarding: tc_actions: allow mirred egress test to run on non-offloaded h2
    https://git.kernel.org/netdev/net-next/c/b57c7e8b76c6

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html