From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F0EFC433F5 for ; Sat, 14 May 2022 23:15:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231651AbiENXOu (ORCPT ); Sat, 14 May 2022 19:14:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230013AbiENXOp (ORCPT ); Sat, 14 May 2022 19:14:45 -0400 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFF3F11C29; Sat, 14 May 2022 16:14:43 -0700 (PDT) Received: by mail-ot1-f45.google.com with SMTP id k25-20020a056830169900b00605f215e55dso7566412otr.13; Sat, 14 May 2022 16:14:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=8fcWrSCf5x/oR5brHV5SFMq/ic1IdVWzznom0Nby5jg=; b=GQN6ammb3tTCwLn7yMLt4mOtmdBJc86UvZs4IfwMKmXpylyl9x9Ij7wfcdxbUY6ivm NfE0tSSEAmitd21oaJzrp3zhQpupjSdHLNh/DBY4okOXL/OWmYaAG6/mailI6p1Ei3zR CQFjQUQF+yiotgw+XZOFugcEW4+X7KASK8dOuaz63iG2L7tlsWz936/1/OpkNJou2455 WMymnEGO7Q8WhcKQztu/V+FD3rMaG4TNM1ya/NHtdwNh259HX/OUct5qY0lUw4NvYfXc GX2ikAyoDQrHJxU1okcJzp6ikoAEcRoR7ZrxvS5A4xO3VOWP4lrLrDR0my/PAkToOUNX 2J0w== X-Gm-Message-State: AOAM533x0/j43MqgW3yQ89k7qjGuDCG7VUX7rmjAyBlvvG8v2y+sgT7T kNIb3OZVQiXa29AYwORFsA== X-Google-Smtp-Source: ABdhPJwl9oHK5hDNNxA5VHeDQnmNJ6i+NfFWt4ZnjKEwX0WwdMarfDgU2sJkk1jCO8U1nV6WMPCTsw== X-Received: by 2002:a05:6830:d2:b0:605:ee58:2dc5 with SMTP id x18-20020a05683000d200b00605ee582dc5mr4057650oto.252.1652570082831; Sat, 14 May 2022 16:14:42 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id k101-20020a9d19ee000000b006060322123fsm2633837otk.15.2022.05.14.16.14.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 May 2022 16:14:42 -0700 (PDT) Received: (nullmailer pid 3276246 invoked by uid 1000); Sat, 14 May 2022 23:14:41 -0000 From: Rob Herring To: Frank Wunderlich Cc: Michael Riesch , Vinod Koul , Johan Jonker , linux-rockchip@lists.infradead.org, linux-pci@vger.kernel.org, Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, Frank Wunderlich , linux-phy@lists.infradead.org, Bjorn Helgaas , Philipp Zabel , Lorenzo Pieralisi , Peter Geis , Heiko Stuebner , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, Rob Herring , devicetree@vger.kernel.org, =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= In-Reply-To: <20220514115946.8858-2-linux@fw-web.de> References: <20220514115946.8858-1-linux@fw-web.de> <20220514115946.8858-2-linux@fw-web.de> Subject: Re: [RFC v3 1/5] dt-bindings: phy: rockchip: add PCIe v3 phy Date: Sat, 14 May 2022 18:14:40 -0500 Message-Id: <1652570081.002742.3276245.nullmailer@robh.at.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 14 May 2022 13:59:42 +0200, Frank Wunderlich wrote: > From: Frank Wunderlich > > Add a new binding file for Rockchip PCIe v3 phy driver. > > Signed-off-by: Frank Wunderlich > > --- > v3: > - drop quotes > - drop rk3588 > - make clockcount fixed to 3 > - full path for binding header file > - drop phy-mode and its header and add lane-map > > v2: > dt-bindings: rename yaml for PCIe v3 > rockchip-pcie3-phy.yaml => rockchip,pcie3-phy.yaml > > changes in pcie3 phy yaml > - change clock names to ordered const list > - extend pcie30-phymode description > - add phy-cells to required properties > - drop unevaluatedProperties > - example with 1 clock each line > - use default property instead of text describing it > - update license > --- > .../bindings/phy/rockchip,pcie3-phy.yaml | 82 +++++++++++++++++++ > 1 file changed, 82 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml: properties:clock-names: 'oneOf' conditional failed, one must be fixed: [{'const': 'refclk_m'}, {'const': 'refclk_n'}, {'const': 'pclk'}] is too long [{'const': 'refclk_m'}, {'const': 'refclk_n'}, {'const': 'pclk'}] is too short False schema does not allow 3 1 was expected 3 is greater than the maximum of 2 hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml: ignoring, error in schema: properties: clock-names Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.example.dtb:0:0: /example-0/phy@fe8c0000: failed to match any schema with compatible: ['rockchip,rk3568-pcie3-phy'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72940C433EF for ; Sat, 14 May 2022 23:15:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject: References:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VukBSrtJlFRkQ7EHiOKsvnvv9SgLFK8jHNcwIiIeq+I=; b=PcDQ8ef+TdkSMD b1/k0mzNUwtYG6zOSerlDByq0C/p5zuRwJ7tnF+heFa3m0WBb0nPC3rvVnU9/d4PcwATmNJD2F2cX uuHhpG/qFSTKF1RcJLFTCu/GBWUkLNIIpAMVq3/hs/swRVg6lo/nmNZMXuK2mzu2b2Fbpb+w6E7VJ EHpi+XAo4BBfBpYKRHZYZLbMdYQSbwNf2cQH8p3Y8a2iEWNOd+Rwey8TwFpMTfsbT5kYdaF5fGHvp bz5csytSGpltEBLQPXEHevTHEmIedZY9CHUe5yKqmApRqPZLclEBNGrv2B4KUVlOnv2XUt4UkeD58 RHep/m0tmUNg+wN025BA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nq0yG-002Xv6-8w; Sat, 14 May 2022 23:14:48 +0000 Received: from mail-ot1-f41.google.com ([209.85.210.41]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nq0yC-002Xud-LY; Sat, 14 May 2022 23:14:46 +0000 Received: by mail-ot1-f41.google.com with SMTP id m15-20020a9d608f000000b00606a788887aso7556164otj.0; Sat, 14 May 2022 16:14:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=8fcWrSCf5x/oR5brHV5SFMq/ic1IdVWzznom0Nby5jg=; b=TluS2KhCLA9MaCRnYWyniZXDyA7NQbH9C1KEBTFQvcRHIdZzAoFmkPT9S//PFNuxFW 8uw9CjVsP2PHL386A2hn2dTU7hjJRvRsGv1JaklufgcIVn+C82U5/QMySVZPY+To2Ck3 e8sCGYUDxYeSlInZq56OvuRcafbd5w9hZwFdnYZMD0qQderPGFuS4U3vmtz+5kSXvQRM IOGwq+IVJc08bqXJr1Q+MK7xTtdenqeO2fH4AO2ZMJg7fMPxYBATcXmquZZuPWowPiK8 E63FAOcAabNJCdmQLXZdSEdjnyu85oTA8Y6AF7L8TiTDn6fJ6FiTn1mxQ28wnX7JjRC1 EIaw== X-Gm-Message-State: AOAM5335V3EsScnb8+/jRjVmjuFMLK0cZ12FqIeQczuZYPj0yXvNe+AJ eqJZLBaYDLtXwF8dX9e7Wg== X-Google-Smtp-Source: ABdhPJwl9oHK5hDNNxA5VHeDQnmNJ6i+NfFWt4ZnjKEwX0WwdMarfDgU2sJkk1jCO8U1nV6WMPCTsw== X-Received: by 2002:a05:6830:d2:b0:605:ee58:2dc5 with SMTP id x18-20020a05683000d200b00605ee582dc5mr4057650oto.252.1652570082831; Sat, 14 May 2022 16:14:42 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id k101-20020a9d19ee000000b006060322123fsm2633837otk.15.2022.05.14.16.14.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 May 2022 16:14:42 -0700 (PDT) Received: (nullmailer pid 3276246 invoked by uid 1000); Sat, 14 May 2022 23:14:41 -0000 From: Rob Herring To: Frank Wunderlich Cc: Michael Riesch , Vinod Koul , Johan Jonker , linux-rockchip@lists.infradead.org, linux-pci@vger.kernel.org, Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, Frank Wunderlich , linux-phy@lists.infradead.org, Bjorn Helgaas , Philipp Zabel , Lorenzo Pieralisi , Peter Geis , Heiko Stuebner , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, Rob Herring , devicetree@vger.kernel.org, =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= In-Reply-To: <20220514115946.8858-2-linux@fw-web.de> References: <20220514115946.8858-1-linux@fw-web.de> <20220514115946.8858-2-linux@fw-web.de> Subject: Re: [RFC v3 1/5] dt-bindings: phy: rockchip: add PCIe v3 phy Date: Sat, 14 May 2022 18:14:40 -0500 Message-Id: <1652570081.002742.3276245.nullmailer@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220514_161444_747245_4C68F88F X-CRM114-Status: GOOD ( 16.84 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Sat, 14 May 2022 13:59:42 +0200, Frank Wunderlich wrote: > From: Frank Wunderlich > > Add a new binding file for Rockchip PCIe v3 phy driver. > > Signed-off-by: Frank Wunderlich > > --- > v3: > - drop quotes > - drop rk3588 > - make clockcount fixed to 3 > - full path for binding header file > - drop phy-mode and its header and add lane-map > > v2: > dt-bindings: rename yaml for PCIe v3 > rockchip-pcie3-phy.yaml => rockchip,pcie3-phy.yaml > > changes in pcie3 phy yaml > - change clock names to ordered const list > - extend pcie30-phymode description > - add phy-cells to required properties > - drop unevaluatedProperties > - example with 1 clock each line > - use default property instead of text describing it > - update license > --- > .../bindings/phy/rockchip,pcie3-phy.yaml | 82 +++++++++++++++++++ > 1 file changed, 82 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml: properties:clock-names: 'oneOf' conditional failed, one must be fixed: [{'const': 'refclk_m'}, {'const': 'refclk_n'}, {'const': 'pclk'}] is too long [{'const': 'refclk_m'}, {'const': 'refclk_n'}, {'const': 'pclk'}] is too short False schema does not allow 3 1 was expected 3 is greater than the maximum of 2 hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml: ignoring, error in schema: properties: clock-names Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.example.dtb:0:0: /example-0/phy@fe8c0000: failed to match any schema with compatible: ['rockchip,rk3568-pcie3-phy'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B560C433F5 for ; Sat, 14 May 2022 23:14:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject: References:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rV5qIsocLV2oQ/8tpiCql6EQLHLY048j6zxJ+8n1j4k=; b=EH0u80vxAVp4hC kHC6kX9tZFJNTth7qOqTdm6voH2YnawWnXtvgkvR6eItLeFjCDyvlblqmBBZvCRDZdBizjs/l+O08 Y1rNr/44K9flaf9IX3Yr+GR8SB29SXCwBp1+z2tSY9kTFBJXAK4J9d4AjTquAaTp5UU7LkDJUmf4C IwbssoggzACduZkerND60oY0ZCByY5OfEo18NOU9yINPKoVVno9CNaTiGUqDFdZFKfuJ7/WnVCBrk +866Nth59KLmYqlWgVsntXXNW6D7kdgSjhCCQZpmlEJKTMAtBJhMgnzc9uzErkxkUrQ91hGgc+6e/ fnYmVadoNfvkJn2C4tiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nq0yG-002XvB-KM; Sat, 14 May 2022 23:14:48 +0000 Received: from mail-ot1-f41.google.com ([209.85.210.41]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nq0yC-002Xud-LY; Sat, 14 May 2022 23:14:46 +0000 Received: by mail-ot1-f41.google.com with SMTP id m15-20020a9d608f000000b00606a788887aso7556164otj.0; Sat, 14 May 2022 16:14:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=8fcWrSCf5x/oR5brHV5SFMq/ic1IdVWzznom0Nby5jg=; b=TluS2KhCLA9MaCRnYWyniZXDyA7NQbH9C1KEBTFQvcRHIdZzAoFmkPT9S//PFNuxFW 8uw9CjVsP2PHL386A2hn2dTU7hjJRvRsGv1JaklufgcIVn+C82U5/QMySVZPY+To2Ck3 e8sCGYUDxYeSlInZq56OvuRcafbd5w9hZwFdnYZMD0qQderPGFuS4U3vmtz+5kSXvQRM IOGwq+IVJc08bqXJr1Q+MK7xTtdenqeO2fH4AO2ZMJg7fMPxYBATcXmquZZuPWowPiK8 E63FAOcAabNJCdmQLXZdSEdjnyu85oTA8Y6AF7L8TiTDn6fJ6FiTn1mxQ28wnX7JjRC1 EIaw== X-Gm-Message-State: AOAM5335V3EsScnb8+/jRjVmjuFMLK0cZ12FqIeQczuZYPj0yXvNe+AJ eqJZLBaYDLtXwF8dX9e7Wg== X-Google-Smtp-Source: ABdhPJwl9oHK5hDNNxA5VHeDQnmNJ6i+NfFWt4ZnjKEwX0WwdMarfDgU2sJkk1jCO8U1nV6WMPCTsw== X-Received: by 2002:a05:6830:d2:b0:605:ee58:2dc5 with SMTP id x18-20020a05683000d200b00605ee582dc5mr4057650oto.252.1652570082831; Sat, 14 May 2022 16:14:42 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id k101-20020a9d19ee000000b006060322123fsm2633837otk.15.2022.05.14.16.14.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 May 2022 16:14:42 -0700 (PDT) Received: (nullmailer pid 3276246 invoked by uid 1000); Sat, 14 May 2022 23:14:41 -0000 From: Rob Herring To: Frank Wunderlich Cc: Michael Riesch , Vinod Koul , Johan Jonker , linux-rockchip@lists.infradead.org, linux-pci@vger.kernel.org, Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, Frank Wunderlich , linux-phy@lists.infradead.org, Bjorn Helgaas , Philipp Zabel , Lorenzo Pieralisi , Peter Geis , Heiko Stuebner , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, Rob Herring , devicetree@vger.kernel.org, =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= In-Reply-To: <20220514115946.8858-2-linux@fw-web.de> References: <20220514115946.8858-1-linux@fw-web.de> <20220514115946.8858-2-linux@fw-web.de> Subject: Re: [RFC v3 1/5] dt-bindings: phy: rockchip: add PCIe v3 phy Date: Sat, 14 May 2022 18:14:40 -0500 Message-Id: <1652570081.002742.3276245.nullmailer@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220514_161444_747245_4C68F88F X-CRM114-Status: GOOD ( 16.84 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Sat, 14 May 2022 13:59:42 +0200, Frank Wunderlich wrote: > From: Frank Wunderlich > > Add a new binding file for Rockchip PCIe v3 phy driver. > > Signed-off-by: Frank Wunderlich > > --- > v3: > - drop quotes > - drop rk3588 > - make clockcount fixed to 3 > - full path for binding header file > - drop phy-mode and its header and add lane-map > > v2: > dt-bindings: rename yaml for PCIe v3 > rockchip-pcie3-phy.yaml => rockchip,pcie3-phy.yaml > > changes in pcie3 phy yaml > - change clock names to ordered const list > - extend pcie30-phymode description > - add phy-cells to required properties > - drop unevaluatedProperties > - example with 1 clock each line > - use default property instead of text describing it > - update license > --- > .../bindings/phy/rockchip,pcie3-phy.yaml | 82 +++++++++++++++++++ > 1 file changed, 82 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml: properties:clock-names: 'oneOf' conditional failed, one must be fixed: [{'const': 'refclk_m'}, {'const': 'refclk_n'}, {'const': 'pclk'}] is too long [{'const': 'refclk_m'}, {'const': 'refclk_n'}, {'const': 'pclk'}] is too short False schema does not allow 3 1 was expected 3 is greater than the maximum of 2 hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml: ignoring, error in schema: properties: clock-names Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.example.dtb:0:0: /example-0/phy@fe8c0000: failed to match any schema with compatible: ['rockchip,rk3568-pcie3-phy'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2663AC433EF for ; Sat, 14 May 2022 23:16:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject: References:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s/1XuvmkOcmXm2TsYguC5mBogUkqhhvySR5qeHsMQ5M=; b=E9BiEH/GhodZa0 uFnNqbP4QUU+mBDBGC8Wi9e7We4wQ+s+q0p2n8yzPD3X51Dft1MxKoYUmTl4Vqd9PmvNI+BaPr0Rr mtW6F+vl2Qg9IHgB7baVqJtq6FRK7gArlQY/OGWIHtZC7Mf2dYzeFdiX9mSqkXY+SYZLUvIz2Uo+o Ch58UrSb5c91euqwZDE7GpnKDJ4I4fScOv71bNwhTFyfW4TLCcJ/ROM2xDdv25bB/W1KwngrMQwJj ur52/oJBu1QBN0ZkP0DuGsdW7NEhc1n9kJiQosMgixlH6uVatYjrlXr50hw4xxI2SEoyHbtn018BP 5vVr+xO4ujKOjx2RhUYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nq0yH-002XvH-5Z; Sat, 14 May 2022 23:14:49 +0000 Received: from mail-ot1-f41.google.com ([209.85.210.41]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nq0yC-002Xud-LY; Sat, 14 May 2022 23:14:46 +0000 Received: by mail-ot1-f41.google.com with SMTP id m15-20020a9d608f000000b00606a788887aso7556164otj.0; Sat, 14 May 2022 16:14:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=8fcWrSCf5x/oR5brHV5SFMq/ic1IdVWzznom0Nby5jg=; b=TluS2KhCLA9MaCRnYWyniZXDyA7NQbH9C1KEBTFQvcRHIdZzAoFmkPT9S//PFNuxFW 8uw9CjVsP2PHL386A2hn2dTU7hjJRvRsGv1JaklufgcIVn+C82U5/QMySVZPY+To2Ck3 e8sCGYUDxYeSlInZq56OvuRcafbd5w9hZwFdnYZMD0qQderPGFuS4U3vmtz+5kSXvQRM IOGwq+IVJc08bqXJr1Q+MK7xTtdenqeO2fH4AO2ZMJg7fMPxYBATcXmquZZuPWowPiK8 E63FAOcAabNJCdmQLXZdSEdjnyu85oTA8Y6AF7L8TiTDn6fJ6FiTn1mxQ28wnX7JjRC1 EIaw== X-Gm-Message-State: AOAM5335V3EsScnb8+/jRjVmjuFMLK0cZ12FqIeQczuZYPj0yXvNe+AJ eqJZLBaYDLtXwF8dX9e7Wg== X-Google-Smtp-Source: ABdhPJwl9oHK5hDNNxA5VHeDQnmNJ6i+NfFWt4ZnjKEwX0WwdMarfDgU2sJkk1jCO8U1nV6WMPCTsw== X-Received: by 2002:a05:6830:d2:b0:605:ee58:2dc5 with SMTP id x18-20020a05683000d200b00605ee582dc5mr4057650oto.252.1652570082831; Sat, 14 May 2022 16:14:42 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id k101-20020a9d19ee000000b006060322123fsm2633837otk.15.2022.05.14.16.14.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 May 2022 16:14:42 -0700 (PDT) Received: (nullmailer pid 3276246 invoked by uid 1000); Sat, 14 May 2022 23:14:41 -0000 From: Rob Herring To: Frank Wunderlich Cc: Michael Riesch , Vinod Koul , Johan Jonker , linux-rockchip@lists.infradead.org, linux-pci@vger.kernel.org, Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, Frank Wunderlich , linux-phy@lists.infradead.org, Bjorn Helgaas , Philipp Zabel , Lorenzo Pieralisi , Peter Geis , Heiko Stuebner , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, Rob Herring , devicetree@vger.kernel.org, =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= In-Reply-To: <20220514115946.8858-2-linux@fw-web.de> References: <20220514115946.8858-1-linux@fw-web.de> <20220514115946.8858-2-linux@fw-web.de> Subject: Re: [RFC v3 1/5] dt-bindings: phy: rockchip: add PCIe v3 phy Date: Sat, 14 May 2022 18:14:40 -0500 Message-Id: <1652570081.002742.3276245.nullmailer@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220514_161444_747245_4C68F88F X-CRM114-Status: GOOD ( 16.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 14 May 2022 13:59:42 +0200, Frank Wunderlich wrote: > From: Frank Wunderlich > > Add a new binding file for Rockchip PCIe v3 phy driver. > > Signed-off-by: Frank Wunderlich > > --- > v3: > - drop quotes > - drop rk3588 > - make clockcount fixed to 3 > - full path for binding header file > - drop phy-mode and its header and add lane-map > > v2: > dt-bindings: rename yaml for PCIe v3 > rockchip-pcie3-phy.yaml => rockchip,pcie3-phy.yaml > > changes in pcie3 phy yaml > - change clock names to ordered const list > - extend pcie30-phymode description > - add phy-cells to required properties > - drop unevaluatedProperties > - example with 1 clock each line > - use default property instead of text describing it > - update license > --- > .../bindings/phy/rockchip,pcie3-phy.yaml | 82 +++++++++++++++++++ > 1 file changed, 82 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml: properties:clock-names: 'oneOf' conditional failed, one must be fixed: [{'const': 'refclk_m'}, {'const': 'refclk_n'}, {'const': 'pclk'}] is too long [{'const': 'refclk_m'}, {'const': 'refclk_n'}, {'const': 'pclk'}] is too short False schema does not allow 3 1 was expected 3 is greater than the maximum of 2 hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml: ignoring, error in schema: properties: clock-names Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.example.dtb:0:0: /example-0/phy@fe8c0000: failed to match any schema with compatible: ['rockchip,rk3568-pcie3-phy'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel