From: Jens Axboe <axboe@kernel.dk>
To: xieyongji@bytedance.com, josef@toxicpanda.com
Cc: nbd@other.debian.org, zero.xu@bytedance.com, linux-block@vger.kernel.org
Subject: Re: [PATCH] nbd: Fix hung on disconnect request if socket is closed before
Date: Mon, 16 May 2022 06:20:24 -0600 [thread overview]
Message-ID: <165270362494.10115.13881054748910771179.b4-ty@kernel.dk> (raw)
In-Reply-To: <20220322080639.142-1-xieyongji@bytedance.com>
On Tue, 22 Mar 2022 16:06:39 +0800, Xie Yongji wrote:
> When userspace closes the socket before sending a disconnect
> request, the following I/O requests will be blocked in
> wait_for_reconnect() until dead timeout. This will cause the
> following disconnect request also hung on blk_mq_quiesce_queue().
> That means we have no way to disconnect a nbd device if there
> are some I/O requests waiting for reconnecting until dead timeout.
> It's not expected. So let's wake up the thread waiting for
> reconnecting directly when a disconnect request is sent.
>
> [...]
Applied, thanks!
[1/1] nbd: Fix hung on disconnect request if socket is closed before
commit: 491bf8f236fdeec698fa6744993f1ecf3fafd1a5
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2022-05-16 12:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 8:06 [PATCH] nbd: Fix hung on disconnect request if socket is closed before Xie Yongji
2022-03-22 19:56 ` Josef Bacik
2022-05-16 6:12 ` Yongji Xie
2022-05-16 12:20 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165270362494.10115.13881054748910771179.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=nbd@other.debian.org \
--cc=xieyongji@bytedance.com \
--cc=zero.xu@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.