From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 181F5C433F5 for ; Tue, 17 May 2022 14:05:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348386AbiEQOFE (ORCPT ); Tue, 17 May 2022 10:05:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348433AbiEQOE7 (ORCPT ); Tue, 17 May 2022 10:04:59 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6DBB4C79F for ; Tue, 17 May 2022 07:04:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 594D7615C1 for ; Tue, 17 May 2022 14:04:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 449AEC34116; Tue, 17 May 2022 14:04:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652796295; bh=Q2KpV/j2HnVCcTf13L/YKoxhkcb4XM6FTwEhlWOH0vA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j32IXsAfOr79u1X0Suaw8ekFaezaseBcc7NgoIGbMpu3OKCg7nXWb6piMdPzCtH3T 8jM7pHfs5dkojn9N4AgfpIVj/ZckGLqc07q0UZI8+ZAdqcebRy642vy3Ilb1ynoNri tmH/Tz8gWMY043W39P9duG3I/UyHdgfRXIn2HvM0jR/3xvrhTR1MlGqvJjUqOjg2qp LrCg9AanQK1ars7TGq/R6AENgZxWEaUof7PtWtqT4eT8CBmvtUnA8O6icQ9wH9GZEM BOnM3LFV7cCc+9ObMGUOBKKxeJpT+Ur7GVhZ6Oi9iiuls3GPHfA0rXhS60ZcXe8PxF K3UqJq5CYVpZA== From: Will Deacon To: Elliot Berman , Catalin Marinas , Alexey Makhalov , Juergen Gross , "Srivatsa S. Bhat (VMware)" Cc: kernel-team@android.com, Will Deacon , Prakruthi Deepak Heragu , linux-kernel@vger.kernel.org, Murali Nalajala , virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org Subject: Re: [PATCH v3] arm64: paravirt: Use RCU read locks to guard stolen_time Date: Tue, 17 May 2022 15:04:44 +0100 Message-Id: <165279381181.2978864.3665903579432057917.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220513174654.362169-1-quic_eberman@quicinc.com> References: <20220513174654.362169-1-quic_eberman@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 May 2022 10:46:54 -0700, Elliot Berman wrote: > From: Prakruthi Deepak Heragu > > During hotplug, the stolen time data structure is unmapped and memset. > There is a possibility of the timer IRQ being triggered before memset > and stolen time is getting updated as part of this timer IRQ handler. This > causes the below crash in timer handler - > > [...] Applied to arm64 (for-next/fixes), thanks! [1/1] arm64: paravirt: Use RCU read locks to guard stolen_time https://git.kernel.org/arm64/c/19bef63f951e Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D924FC433F5 for ; Tue, 17 May 2022 14:05:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 6FB2840C72; Tue, 17 May 2022 14:05:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MHoeq86J3z0V; Tue, 17 May 2022 14:05:01 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id 7D18040C6F; Tue, 17 May 2022 14:05:00 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 51853C0032; Tue, 17 May 2022 14:05:00 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 61B3EC002D for ; Tue, 17 May 2022 14:04:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 4A1354093D for ; Tue, 17 May 2022 14:04:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=kernel.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z4SidnckwrH0 for ; Tue, 17 May 2022 14:04:58 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp4.osuosl.org (Postfix) with ESMTPS id 4AAA140902 for ; Tue, 17 May 2022 14:04:58 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 19E32615C7; Tue, 17 May 2022 14:04:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 449AEC34116; Tue, 17 May 2022 14:04:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652796295; bh=Q2KpV/j2HnVCcTf13L/YKoxhkcb4XM6FTwEhlWOH0vA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j32IXsAfOr79u1X0Suaw8ekFaezaseBcc7NgoIGbMpu3OKCg7nXWb6piMdPzCtH3T 8jM7pHfs5dkojn9N4AgfpIVj/ZckGLqc07q0UZI8+ZAdqcebRy642vy3Ilb1ynoNri tmH/Tz8gWMY043W39P9duG3I/UyHdgfRXIn2HvM0jR/3xvrhTR1MlGqvJjUqOjg2qp LrCg9AanQK1ars7TGq/R6AENgZxWEaUof7PtWtqT4eT8CBmvtUnA8O6icQ9wH9GZEM BOnM3LFV7cCc+9ObMGUOBKKxeJpT+Ur7GVhZ6Oi9iiuls3GPHfA0rXhS60ZcXe8PxF K3UqJq5CYVpZA== From: Will Deacon To: Elliot Berman , Catalin Marinas , Alexey Makhalov , Juergen Gross , "Srivatsa S. Bhat (VMware)" Subject: Re: [PATCH v3] arm64: paravirt: Use RCU read locks to guard stolen_time Date: Tue, 17 May 2022 15:04:44 +0100 Message-Id: <165279381181.2978864.3665903579432057917.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220513174654.362169-1-quic_eberman@quicinc.com> References: <20220513174654.362169-1-quic_eberman@quicinc.com> MIME-Version: 1.0 Cc: Murali Nalajala , kernel-team@android.com, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Prakruthi Deepak Heragu , Will Deacon , linux-arm-kernel@lists.infradead.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Fri, 13 May 2022 10:46:54 -0700, Elliot Berman wrote: > From: Prakruthi Deepak Heragu > > During hotplug, the stolen time data structure is unmapped and memset. > There is a possibility of the timer IRQ being triggered before memset > and stolen time is getting updated as part of this timer IRQ handler. This > causes the below crash in timer handler - > > [...] Applied to arm64 (for-next/fixes), thanks! [1/1] arm64: paravirt: Use RCU read locks to guard stolen_time https://git.kernel.org/arm64/c/19bef63f951e Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A496BC433F5 for ; Tue, 17 May 2022 14:09:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=45H9SMmPKER+Q+lg+9sKuDs2SzBmkXy8Vdu+JmEdJj0=; b=OVQNk58cxnIMZh zDBqzfT6MD4GGecfl8xH/Jz29Ionz+viqRpx61uaBDhQKGEwaqc8y1E2eSWTg3jW2OGagpit9/Oqo FJnPNgfmCVU9slHJC2gze8xhrb19jHWz2dPa91aiwjLj5uGq25eXDJv7nD3HJ6IAksBBr4vBQ6rrc pxlgH2JD+3dP6wisjfXmDegvT4QOlA3FFMzybxHs9btZ9UR5JAeYzzvcCBHRBw96cHBpleJprNeW2 GNTmmphJe1/rIiQFtWrvU1OpSRAVbNuLfpS6jSBrZY/JlrUF5IwXw/CoXhhXGtSqu1IouRwWAmUzI 2kTXyCrK/h0su9cBPTWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqxsG-00EDOc-Gu; Tue, 17 May 2022 14:08:33 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqxon-00EBhK-KR for linux-arm-kernel@lists.infradead.org; Tue, 17 May 2022 14:04:59 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 19E32615C7; Tue, 17 May 2022 14:04:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 449AEC34116; Tue, 17 May 2022 14:04:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652796295; bh=Q2KpV/j2HnVCcTf13L/YKoxhkcb4XM6FTwEhlWOH0vA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j32IXsAfOr79u1X0Suaw8ekFaezaseBcc7NgoIGbMpu3OKCg7nXWb6piMdPzCtH3T 8jM7pHfs5dkojn9N4AgfpIVj/ZckGLqc07q0UZI8+ZAdqcebRy642vy3Ilb1ynoNri tmH/Tz8gWMY043W39P9duG3I/UyHdgfRXIn2HvM0jR/3xvrhTR1MlGqvJjUqOjg2qp LrCg9AanQK1ars7TGq/R6AENgZxWEaUof7PtWtqT4eT8CBmvtUnA8O6icQ9wH9GZEM BOnM3LFV7cCc+9ObMGUOBKKxeJpT+Ur7GVhZ6Oi9iiuls3GPHfA0rXhS60ZcXe8PxF K3UqJq5CYVpZA== From: Will Deacon To: Elliot Berman , Catalin Marinas , Alexey Makhalov , Juergen Gross , "Srivatsa S. Bhat (VMware)" Cc: kernel-team@android.com, Will Deacon , Prakruthi Deepak Heragu , linux-kernel@vger.kernel.org, Murali Nalajala , virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org Subject: Re: [PATCH v3] arm64: paravirt: Use RCU read locks to guard stolen_time Date: Tue, 17 May 2022 15:04:44 +0100 Message-Id: <165279381181.2978864.3665903579432057917.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220513174654.362169-1-quic_eberman@quicinc.com> References: <20220513174654.362169-1-quic_eberman@quicinc.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220517_070457_787997_874AC121 X-CRM114-Status: GOOD ( 10.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 13 May 2022 10:46:54 -0700, Elliot Berman wrote: > From: Prakruthi Deepak Heragu > > During hotplug, the stolen time data structure is unmapped and memset. > There is a possibility of the timer IRQ being triggered before memset > and stolen time is getting updated as part of this timer IRQ handler. This > causes the below crash in timer handler - > > [...] Applied to arm64 (for-next/fixes), thanks! [1/1] arm64: paravirt: Use RCU read locks to guard stolen_time https://git.kernel.org/arm64/c/19bef63f951e Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel