From: Yongzhi Liu <lyz_cs@pku.edu.cn> To: agross@kernel.org, bjorn.andersson@linaro.org, jic23@kernel.org, lars@metafoo.de, svarbanov@mm-sol.com, iivanov@mm-sol.com, jonathan.cameron@huawei.com Cc: linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, fuyq@stu.pku.edu.cn, Yongzhi Liu <lyz_cs@pku.edu.cn> Subject: [PATCH] hv_netvsc: Fix potential dereference of NULL pointer Date: Fri, 20 May 2022 20:31:02 -0700 [thread overview] Message-ID: <1653103862-36104-1-git-send-email-lyz_cs@pku.edu.cn> (raw) In-Reply-To: <20220520181323.00002892@huawei.com> The return value of netvsc_devinfo_get() needs to be checked to avoid use of NULL pointer in case of an allocation failure. Fixes: 0efeea5fb ("hv_netvsc: Add the support of hibernation") Signed-off-by: Yongzhi Liu <lyz_cs@pku.edu.cn> --- drivers/net/hyperv/netvsc_drv.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index fde1c49..b1dece6 100644 --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -2671,7 +2671,10 @@ static int netvsc_suspend(struct hv_device *dev) /* Save the current config info */ ndev_ctx->saved_netvsc_dev_info = netvsc_devinfo_get(nvdev); - + if (!ndev_ctx->saved_netvsc_dev_info) { + ret = -ENOMEM; + goto out; + } ret = netvsc_detach(net, nvdev); out: rtnl_unlock(); -- 2.7.4
next prev parent reply other threads:[~2022-05-21 3:31 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-18 6:43 [PATCH] iio: vadc: " Yongzhi Liu 2022-05-18 17:31 ` Matthias Kaehlcke 2022-05-19 5:50 ` [PATCH v2] " Yongzhi Liu 2022-05-20 17:13 ` Jonathan Cameron 2022-05-21 3:31 ` Yongzhi Liu [this message] 2022-05-21 3:34 ` [PATCH] hv_netvsc: " 刘永志 2022-05-23 15:21 ` Andy Shevchenko 2022-05-23 15:45 ` 刘永志 2022-05-21 3:35 ` [PATCH v3] iio: vadc: " Yongzhi Liu 2022-05-22 11:01 ` Jonathan Cameron 2022-05-22 16:53 ` [PATCH v4] " Yongzhi Liu 2022-06-03 15:02 ` Jonathan Cameron 2022-06-03 15:20 ` Jonathan Cameron 2022-05-19 12:09 [PATCH] hv_netvsc: " Yongzhi Liu 2022-05-19 13:45 ` Haiyang Zhang 2022-05-21 1:00 ` patchwork-bot+netdevbpf
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1653103862-36104-1-git-send-email-lyz_cs@pku.edu.cn \ --to=lyz_cs@pku.edu.cn \ --cc=agross@kernel.org \ --cc=bjorn.andersson@linaro.org \ --cc=fuyq@stu.pku.edu.cn \ --cc=iivanov@mm-sol.com \ --cc=jic23@kernel.org \ --cc=jonathan.cameron@huawei.com \ --cc=lars@metafoo.de \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=svarbanov@mm-sol.com \ --subject='Re: [PATCH] hv_netvsc: Fix potential dereference of NULL pointer' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.