All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] iio: vadc: Fix potential dereference of NULL pointer
@ 2022-05-18  6:43 Yongzhi Liu
  2022-05-18 17:31 ` Matthias Kaehlcke
  0 siblings, 1 reply; 13+ messages in thread
From: Yongzhi Liu @ 2022-05-18  6:43 UTC (permalink / raw)
  To: agross, bjorn.andersson, jic23, lars
  Cc: linux-arm-msm, linux-iio, linux-kernel, fuyq, Yongzhi Liu

The return value of vadc_get_channel() needs to be checked
to avoid use of NULL pointer, which is followed by
the caller 'vadc_do_conversion' of function 'vadc_configure'.
Fix this by adding the null pointer check on prop
in function 'vadc_configure'.

Signed-off-by: Yongzhi Liu <lyz_cs@pku.edu.cn>
---
 drivers/iio/adc/qcom-spmi-vadc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/iio/adc/qcom-spmi-vadc.c b/drivers/iio/adc/qcom-spmi-vadc.c
index 34202ba..d99bd72 100644
--- a/drivers/iio/adc/qcom-spmi-vadc.c
+++ b/drivers/iio/adc/qcom-spmi-vadc.c
@@ -210,6 +210,9 @@ static int vadc_configure(struct vadc_priv *vadc,
 	u8 decimation, mode_ctrl;
 	int ret;
 
+	if (!prop)
+		return -ENODEV;
+
 	/* Mode selection */
 	mode_ctrl = (VADC_OP_MODE_NORMAL << VADC_OP_MODE_SHIFT) |
 		     VADC_ADC_TRIM_EN | VADC_AMUX_TRIM_EN;
-- 
2.7.4


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2022-06-03 15:11 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-18  6:43 [PATCH] iio: vadc: Fix potential dereference of NULL pointer Yongzhi Liu
2022-05-18 17:31 ` Matthias Kaehlcke
2022-05-19  5:50   ` [PATCH v2] " Yongzhi Liu
2022-05-20 17:13     ` Jonathan Cameron
2022-05-21  3:31       ` [PATCH] hv_netvsc: " Yongzhi Liu
2022-05-21  3:34         ` 刘永志
2022-05-23 15:21         ` Andy Shevchenko
2022-05-23 15:45           ` 刘永志
2022-05-21  3:35       ` [PATCH v3] iio: vadc: " Yongzhi Liu
2022-05-22 11:01         ` Jonathan Cameron
2022-05-22 16:53           ` [PATCH v4] " Yongzhi Liu
2022-06-03 15:02             ` Jonathan Cameron
2022-06-03 15:20               ` Jonathan Cameron

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.