From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74AEBC433F5 for ; Mon, 23 May 2022 21:34:06 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E94941611; Mon, 23 May 2022 23:34:05 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 2AF2A40156; Mon, 23 May 2022 23:34:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653341643; x=1684877643; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=WliwIJAHSrqJX0JkohDXfNc2G2g+MqDMbxRN/NP82Og=; b=n/yRilMD7oqpDh+vmue0fSiYnV9/aizrMR9vSU4U00Py9Rma9uY4JceI HewvRRZIfILj9Zxbb3NgCusAw1QnuhD23pfYuPR9YA6Y6FDESsBgxMr+c mljr2A0quBT5CuV678Zaui+isb+f0CSCoQk5mPOmhvK5hlzNx/JBAU2Jo UnPHaAToCuMO63WeCOS5enAL1qrxxNRf7tNJSbJK4e0S/5/QPydTZ8Rj7 4uk62xeSNUpgk/wbkdQNbzpkd3Xh/2YZsoKoQDNxVhJeCUjoO0taStnaX Kwiz8uBav4YXtMNfC7fVXEme1NI3NryqlG+ZPGzjYaOVImBDYz5GrRXyt w==; X-IronPort-AV: E=McAfee;i="6400,9594,10356"; a="272183538" X-IronPort-AV: E=Sophos;i="5.91,247,1647327600"; d="scan'208";a="272183538" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2022 14:33:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,247,1647327600"; d="scan'208";a="629591634" Received: from skx-5gnr-sc12-4.sc.intel.com ([172.25.69.210]) by fmsmga008.fm.intel.com with ESMTP; 23 May 2022 14:33:56 -0700 From: Nicolas Chautru To: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com, maxime.coquelin@redhat.com Cc: thomas@monjalon.net, ray.kinsella@intel.com, bruce.richardson@intel.com, hemant.agrawal@nxp.com, hernan.vargas@intel.com, david.marchand@redhat.com, Nicolas Chautru , stable@dpdk.org Subject: [PATCH v4 2/5] baseband/acc100: add protection for some negative scenario Date: Mon, 23 May 2022 14:25:13 -0700 Message-Id: <1653341116-50325-3-git-send-email-nicolas.chautru@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1653341116-50325-1-git-send-email-nicolas.chautru@intel.com> References: <1651083423-33202-1-git-send-email-nicolas.chautru@intel.com> <1653341116-50325-1-git-send-email-nicolas.chautru@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Catch exception in PMD in case of invalid input parameter. Fixes: 5ad5060f8f7a ("baseband/acc100: add LDPC processing functions") Cc: stable@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c index 9135c0e..3fdf17d 100644 --- a/drivers/baseband/acc100/rte_acc100_pmd.c +++ b/drivers/baseband/acc100/rte_acc100_pmd.c @@ -1236,6 +1236,8 @@ return (bg == 1 ? ACC100_K0_3_1 : ACC100_K0_3_2) * z_c; } /* LBRM case - includes a division by N */ + if (unlikely(z_c == 0)) + return 0; if (rv_index == 1) return (((bg == 1 ? ACC100_K0_1_1 : ACC100_K0_1_2) * n_cb) / n) * z_c; @@ -1764,6 +1766,10 @@ /* Soft output */ if (check_bit(op->turbo_dec.op_flags, RTE_BBDEV_TURBO_SOFT_OUTPUT)) { + if (op->turbo_dec.soft_output.data == 0) { + rte_bbdev_log(ERR, "Soft output is not defined"); + return -1; + } if (check_bit(op->turbo_dec.op_flags, RTE_BBDEV_TURBO_EQUALIZER)) *s_out_length = e; -- 1.8.3.1