All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org
Cc: linux-xfs@vger.kernel.org, david@fromorbit.com,
	allison.henderson@oracle.com
Subject: [PATCH 1/5] xfs: don't log every time we clear the log incompat flags
Date: Mon, 23 May 2022 22:36:25 -0700	[thread overview]
Message-ID: <165337058586.994444.2832013222792677840.stgit@magnolia> (raw)
In-Reply-To: <165337058023.994444.12794741176651030531.stgit@magnolia>

From: Darrick J. Wong <djwong@kernel.org>

There's no need to spam the logs every time we clear the log incompat
flags -- if someone is periodically using one of these features, they'll
be cleared every time the log tries to clean itself, which can get
pretty chatty:

$ dmesg | grep -i clear
[ 5363.894711] XFS (sdd): Clearing log incompat feature flags.
[ 5365.157516] XFS (sdd): Clearing log incompat feature flags.
[ 5369.388543] XFS (sdd): Clearing log incompat feature flags.
[ 5371.281246] XFS (sdd): Clearing log incompat feature flags.

These aren't high value messages either -- nothing's gone wrong, and
nobody's trying anything tricky.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 fs/xfs/xfs_mount.c |    1 -
 1 file changed, 1 deletion(-)


diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
index 0c0bcbd4949d..daa8d29c46b4 100644
--- a/fs/xfs/xfs_mount.c
+++ b/fs/xfs/xfs_mount.c
@@ -1356,7 +1356,6 @@ xfs_clear_incompat_log_features(
 
 	if (xfs_sb_has_incompat_log_feature(&mp->m_sb,
 				XFS_SB_FEAT_INCOMPAT_LOG_ALL)) {
-		xfs_info(mp, "Clearing log incompat feature flags.");
 		xfs_sb_remove_incompat_log_features(&mp->m_sb);
 		ret = true;
 	}


  reply	other threads:[~2022-05-24  5:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-24  5:36 [PATCHSET v2 0/5] xfs: last pile of LARP cleanups for 5.19 Darrick J. Wong
2022-05-24  5:36 ` Darrick J. Wong [this message]
2022-05-27  1:26   ` [PATCH 1/5] xfs: don't log every time we clear the log incompat flags Dave Chinner
2022-05-24  5:36 ` [PATCH 2/5] xfs: implement per-mount warnings for scrub and shrink usage Darrick J. Wong
2022-05-27  1:26   ` Dave Chinner
2022-05-24  5:36 ` [PATCH 3/5] xfs: warn about LARP once per mount Darrick J. Wong
2022-05-27  1:27   ` Dave Chinner
2022-05-24  5:36 ` [PATCH 4/5] xfs: move xfs_attr_use_log_assist out of xfs_log.c Darrick J. Wong
2022-05-27  1:28   ` Dave Chinner
2022-05-24  5:36 ` [PATCH 5/5] xfs: move xfs_attr_use_log_assist usage out of libxfs Darrick J. Wong
2022-05-27  1:29   ` Dave Chinner
  -- strict thread matches above, loose matches on Subject: below --
2022-05-22 15:28 [PATCHSET 0/5] xfs: last pile of LARP cleanups for 5.19 Darrick J. Wong
2022-05-22 15:28 ` [PATCH 1/5] xfs: don't log every time we clear the log incompat flags Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=165337058586.994444.2832013222792677840.stgit@magnolia \
    --to=djwong@kernel.org \
    --cc=allison.henderson@oracle.com \
    --cc=david@fromorbit.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.