From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E8A7C433F5 for ; Tue, 24 May 2022 11:21:45 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4L6sGc1ChFz3fw6 for ; Tue, 24 May 2022 21:21:44 +1000 (AEST) Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4L6s7k43W2z3cCN for ; Tue, 24 May 2022 21:15:46 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4L6s7k3J4fz4ySv; Tue, 24 May 2022 21:15:46 +1000 (AEST) From: Michael Ellerman To: Kajol Jain , mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org In-Reply-To: <20220506061015.43916-1-kjain@linux.ibm.com> References: <20220506061015.43916-1-kjain@linux.ibm.com> Subject: Re: [PATCH 1/2] powerpc/perf: Fix the threshold compare group constraint for power10 Message-Id: <165339057636.1718562.13444860575931956627.b4-ty@ellerman.id.au> Date: Tue, 24 May 2022 21:09:36 +1000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: atrajeev@linux.vnet.ibm.com, maddy@linux.ibm.com, disgoel@linux.vnet.ibm.com, rnsastry@linux.ibm.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, 6 May 2022 11:40:14 +0530, Kajol Jain wrote: > Thresh compare bits for a event is used to program thresh compare > field in Monitor Mode Control Register A (MMCRA: 8-18 bits for power10). > When scheduling events as a group, all events in that group should > match value in threshold bits. Otherwise event open for the sibling > events should fail. But in the current code, incase thresh compare bits are > not valid, we are not failing in group_constraint function which can result > in invalid group schduling. > > [...] Applied to powerpc/next. [1/2] powerpc/perf: Fix the threshold compare group constraint for power10 https://git.kernel.org/powerpc/c/505d31650ba96d6032313480fdb566d289a4698c [2/2] powerpc/perf: Fix the threshold compare group constraint for power9 https://git.kernel.org/powerpc/c/ab0cc6bbf0c812731c703ec757fcc3fc3a457a34 cheers