[PATCH] CI: make qemuarm-secureboot builds more thorough

[PATCH] CI: make qemuarm-secureboot builds more thorough

[Jon Mason]

Build all the things that qemuarm64-secureboot builds, removing those
that fail to compile (e.g., optee-spdevkit).  Unfortunately, clang
doesn't work at all.

Signed-off-by: Jon Mason <jon.mason@arm.com>
---
 .gitlab-ci.yml            | 3 ++-
 ci/qemuarm-secureboot.yml | 6 ++++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 40e00fc0..bc9f0801 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -191,7 +191,8 @@ qemuarm-secureboot:
   extends: .build
   parallel:
     matrix:
-      - TESTING: testimage
+      - TCLIBC: [glibc, musl]
+        TESTING: testimage
 
 qemuarm:
   extends: .build
diff --git a/ci/qemuarm-secureboot.yml b/ci/qemuarm-secureboot.yml
index 2fa8ef08..044661cd 100644
--- a/ci/qemuarm-secureboot.yml
+++ b/ci/qemuarm-secureboot.yml
@@ -4,3 +4,9 @@ header:
     - ci/base.yml
 
 machine: qemuarm-secureboot
+
+target:
+  - core-image-base
+  - optee-examples
+  - optee-test
+  - optee-os-tadevkit
-- 
2.17.1

Re: [meta-arm] [PATCH] CI: make qemuarm-secureboot builds more thorough

[Sumit Garg]

+ Abdellatif (author of optee-spdevkit recipe), Khem

Hi Jon,

On Wed, 11 May 2022 at 20:54, Jon Mason <jon.mason@arm.com> wrote:
>
> Build all the things that qemuarm64-secureboot builds, removing those
> that fail to compile (e.g., optee-spdevkit).

optee-spdevkit recipe seems to be based on non-upstream OP-TEE tree:

# spdevkit isn't yet merged to master
SRC_URI = "git://git.trustedfirmware.org/OP-TEE/optee_os.git;protocol=https;branch=psa-development"
SRCREV = "f9de2c9520ed97b89760cc4c99424aae440b63f4"
PV = "3.10+git${SRCPV}"

Abdellatif,

Are you aware of any plans to support FFA based secure partitions on 32-bit Arm?

>  Unfortunately, clang
> doesn't work at all.
>

This looks related to regression reported by Khem here [1].

[1] https://lists.yoctoproject.org/g/meta-arm/topic/91003714#3373

-Sumit

> Signed-off-by: Jon Mason <jon.mason@arm.com>
> ---
>  .gitlab-ci.yml            | 3 ++-
>  ci/qemuarm-secureboot.yml | 6 ++++++
>  2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 40e00fc0..bc9f0801 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -191,7 +191,8 @@ qemuarm-secureboot:
>    extends: .build
>    parallel:
>      matrix:
> -      - TESTING: testimage
> +      - TCLIBC: [glibc, musl]
> +        TESTING: testimage
>
>  qemuarm:
>    extends: .build
> diff --git a/ci/qemuarm-secureboot.yml b/ci/qemuarm-secureboot.yml
> index 2fa8ef08..044661cd 100644
> --- a/ci/qemuarm-secureboot.yml
> +++ b/ci/qemuarm-secureboot.yml
> @@ -4,3 +4,9 @@ header:
>      - ci/base.yml
>
>  machine: qemuarm-secureboot
> +
> +target:
> +  - core-image-base
> +  - optee-examples
> +  - optee-test
> +  - optee-os-tadevkit
> --
> 2.17.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#3384): https://lists.yoctoproject.org/g/meta-arm/message/3384
> Mute This Topic: https://lists.yoctoproject.org/mt/91038263/1777089
> Group Owner: meta-arm+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [sumit.garg@linaro.org]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [meta-arm] [PATCH] CI: make qemuarm-secureboot builds more thorough

[Jon Mason]

On Thu, May 12, 2022 at 12:50:20PM +0530, Sumit Garg wrote:
> + Abdellatif (author of optee-spdevkit recipe), Khem
> 
> Hi Jon,
> 
> On Wed, 11 May 2022 at 20:54, Jon Mason <jon.mason@arm.com> wrote:
> >
> > Build all the things that qemuarm64-secureboot builds, removing those
> > that fail to compile (e.g., optee-spdevkit).
> 
> optee-spdevkit recipe seems to be based on non-upstream OP-TEE tree:
> 
> # spdevkit isn't yet merged to master
> SRC_URI = "git://git.trustedfirmware.org/OP-TEE/optee_os.git;protocol=https;branch=psa-development"
> SRCREV = "f9de2c9520ed97b89760cc4c99424aae440b63f4"
> PV = "3.10+git${SRCPV}"

Yes, we've recently discovered this too.  We'll start appling pressure
to get this rebased to the latest version of OPTEE, get it working on
arm32, and get it merged upstream.

Thanks,
Jon

> 
> Abdellatif,
> 
> Are you aware of any plans to support FFA based secure partitions on 32-bit Arm?
> 
> >  Unfortunately, clang
> > doesn't work at all.
> >
> 
> This looks related to regression reported by Khem here [1].
> 
> [1] https://lists.yoctoproject.org/g/meta-arm/topic/91003714#3373
> -Sumit
> 
> > Signed-off-by: Jon Mason <jon.mason@arm.com>
> > ---
> >  .gitlab-ci.yml            | 3 ++-
> >  ci/qemuarm-secureboot.yml | 6 ++++++
> >  2 files changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > index 40e00fc0..bc9f0801 100644
> > --- a/.gitlab-ci.yml
> > +++ b/.gitlab-ci.yml
> > @@ -191,7 +191,8 @@ qemuarm-secureboot:
> >    extends: .build
> >    parallel:
> >      matrix:
> > -      - TESTING: testimage
> > +      - TCLIBC: [glibc, musl]
> > +        TESTING: testimage
> >
> >  qemuarm:
> >    extends: .build
> > diff --git a/ci/qemuarm-secureboot.yml b/ci/qemuarm-secureboot.yml
> > index 2fa8ef08..044661cd 100644
> > --- a/ci/qemuarm-secureboot.yml
> > +++ b/ci/qemuarm-secureboot.yml
> > @@ -4,3 +4,9 @@ header:
> >      - ci/base.yml
> >
> >  machine: qemuarm-secureboot
> > +
> > +target:
> > +  - core-image-base
> > +  - optee-examples
> > +  - optee-test
> > +  - optee-os-tadevkit
> > --
> > 2.17.1
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#3384): https://lists.yoctoproject.org/g/meta-arm/message/3384
> > Mute This Topic: https://lists.yoctoproject.org/mt/91038263/1777089
> > Group Owner: meta-arm+owner@lists.yoctoproject.org
> > Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [sumit.garg@linaro.org]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
> 

Re: [PATCH] CI: make qemuarm-secureboot builds more thorough

[Jon Mason]

On Wed, 11 May 2022 11:24:01 -0400, Jon Mason wrote:
> Build all the things that qemuarm64-secureboot builds, removing those
> that fail to compile (e.g., optee-spdevkit).  Unfortunately, clang
> doesn't work at all.

Applied, thanks!

[1/1] CI: make qemuarm-secureboot builds more thorough
      commit: 0c4c33de09aa921cafcea2ad4b7bc0e19f844213

Best regards,
-- 
Jon Mason <jon.mason@arm.com>

[PATCH] CI: make qemuarm-secureboot builds more thorough

[Jon Mason]

Build all the things that qemuarm64-secureboot builds, removing those
that fail to compile.  Unfortunately, musl doesn't play nicely with
optee-test.

Signed-off-by: Jon Mason <jon.mason@arm.com>
---
 .gitlab-ci.yml            | 3 ++-
 ci/qemuarm-secureboot.yml | 6 ++++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index a6804215..6532fd09 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -191,7 +191,8 @@ qemuarm-secureboot:
   extends: .build
   parallel:
     matrix:
-      - TESTING: testimage
+      - TOOLCHAINS: [gcc, clang]
+        TESTING: testimage
 
 qemuarm:
   extends: .build
diff --git a/ci/qemuarm-secureboot.yml b/ci/qemuarm-secureboot.yml
index 2fa8ef08..044661cd 100644
--- a/ci/qemuarm-secureboot.yml
+++ b/ci/qemuarm-secureboot.yml
@@ -4,3 +4,9 @@ header:
     - ci/base.yml
 
 machine: qemuarm-secureboot
+
+target:
+  - core-image-base
+  - optee-examples
+  - optee-test
+  - optee-os-tadevkit
-- 
2.17.1