[PATCH] btrfs: print if fsverity support is built in when loading module

[PATCH] btrfs: print if fsverity support is built in when loading module

[David Sterba]

As fsverity support depends on a config option, print that at module
load time like we do for similar features.

Signed-off-by: David Sterba <dsterba@suse.com>
---
 fs/btrfs/super.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index 2bdc544b4c95..d444338db3c6 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -2566,6 +2566,11 @@ static void __init btrfs_print_mod_info(void)
 			", zoned=yes"
 #else
 			", zoned=no"
+#endif
+#ifdef CONFIG_FS_VERITY
+			", fsverity=yes"
+#else
+			", fsverity=no"
 #endif
 			;
 	pr_info("Btrfs loaded, crc32c=%s%s\n", crc32c_impl(), options);
-- 
2.31.1

Re: [PATCH] btrfs: print if fsverity support is built in when loading module

[Anand Jain]

On 29/07/2021 00:22, David Sterba wrote:
> As fsverity support depends on a config option, print that at module
> load time like we do for similar features.

  So similarly /sys/fs/btrfs/features/fsverity may be required too?

> Signed-off-by: David Sterba <dsterba@suse.com>

  Reviewed-by: Anand Jain <anand.jain@oracle.com>

Thanks.

> ---
>   fs/btrfs/super.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
> index 2bdc544b4c95..d444338db3c6 100644
> --- a/fs/btrfs/super.c
> +++ b/fs/btrfs/super.c
> @@ -2566,6 +2566,11 @@ static void __init btrfs_print_mod_info(void)
>   			", zoned=yes"
>   #else
>   			", zoned=no"
> +#endif
> +#ifdef CONFIG_FS_VERITY
> +			", fsverity=yes"
> +#else
> +			", fsverity=no"
>   #endif
>   			;
>   	pr_info("Btrfs loaded, crc32c=%s%s\n", crc32c_impl(), options);
> 

Re: [PATCH] btrfs: print if fsverity support is built in when loading module

[David Sterba]

On Thu, Jul 29, 2021 at 10:29:32PM +0800, Anand Jain wrote:
> On 29/07/2021 00:22, David Sterba wrote:
> > As fsverity support depends on a config option, print that at module
> > load time like we do for similar features.
> 
>   So similarly /sys/fs/btrfs/features/fsverity may be required too?

Yes, feel free to send a patch.

Re: [PATCH] btrfs: print if fsverity support is built in when loading module

[Anand Jain]

On 29/07/2021 23:56, David Sterba wrote:
> On Thu, Jul 29, 2021 at 10:29:32PM +0800, Anand Jain wrote:
>> On 29/07/2021 00:22, David Sterba wrote:
>>> As fsverity support depends on a config option, print that at module
>>> load time like we do for similar features.
>>
>>    So similarly /sys/fs/btrfs/features/fsverity may be required too?
> 
> Yes, feel free to send a patch.

  Oops. It's already there. Commit 6875cbd232c7 (btrfs: initial fsverity 
support) added it.

Thanks, Anand