From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F9F4CCA481 for ; Fri, 24 Jun 2022 14:37:12 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 510241866; Fri, 24 Jun 2022 16:36:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 510241866 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1656081430; bh=YLOYNbTCSohGH/+DsIqSDrc5jnYVINgv/JKlqhF3jys=; h=From:To:In-Reply-To:References:Subject:Date:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=uIPk9jPKCXsCc8IzKbcuBBvLsKBQ+ou4DR7sBm9/u2IbNeM4+XPYz5+2BaeaUrgd+ 8TytvDxknbF+NPGejbnCNqTGQv2ldIPYuftqb5aIJOZuIeUyUPOZWVXh/iPqMCSCPk uRd3KGV8vPz0V38go+3xUfs2gqiTh4z+8Cl+yRjE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4A23EF804ED; Fri, 24 Jun 2022 16:35:51 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A15CBF80139; Fri, 24 Jun 2022 16:35:49 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 42FD8F80107 for ; Fri, 24 Jun 2022 16:35:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 42FD8F80107 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jAEiTwOm" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EA5D862072; Fri, 24 Jun 2022 14:35:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81462C3411C; Fri, 24 Jun 2022 14:35:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656081343; bh=YLOYNbTCSohGH/+DsIqSDrc5jnYVINgv/JKlqhF3jys=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=jAEiTwOmqVmDx/uUmKUQGo7PPCoeKHT8ewH9a3F1d7A07rPABtsAjd1RqmuiGZONh J0A+99w0db7KlubgJQkvXdsNZv77nBfAXGiH7HUVf89EaaUbcnX/BHWZOh82D5hylv VGJf4NA0FvWlDrzAiCc5jTcU+Xm9oM/BjB2x+tyGHHCYkTnaYWnJwKI9TXX3gyfobV eO3nhDAzQmCE4L15qutDxs3xHHrVFk2kKBvq3bjkfq8U2SnM0L04u+xGXm2QpkVSLS kh/m/j8tGqziM3WMHl9IbSAV6p2W5zjR6NRZpQDBTUH4lPBlfTZmHI5tElT4R3qcRa L/dOUby1OUleA== From: Mark Brown To: francesco.dolcini@toradex.com, festevam@gmail.com In-Reply-To: <20220624101301.441314-1-francesco.dolcini@toradex.com> References: <20220624101301.441314-1-francesco.dolcini@toradex.com> Subject: Re: [PATCH v1] ASoC: sgtl5000: Fix noise on shutdown/remove Message-Id: <165608134224.445804.6652358254691834854.b4-ty@kernel.org> Date: Fri, 24 Jun 2022 15:35:42 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Cc: zhaoming.zeng@freescale.com, alsa-devel@alsa-project.org, tiwai@suse.com, lgirdwood@gmail.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 24 Jun 2022 12:13:01 +0200, Francesco Dolcini wrote: > Put the SGTL5000 in a silent/safe state on shutdown/remove, this is > required since the SGTL5000 produces a constant noise on its output > after it is configured and its clock is removed. Without this change > this is happening every time the module is unbound/removed or from > reboot till the clock is enabled again. > > The issue was experienced on both a Toradex Colibri/Apalis iMX6, but can > be easily reproduced everywhere just playing something on the codec and > after that removing/unbinding the driver. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: sgtl5000: Fix noise on shutdown/remove commit: 8070e590dd66b1af68b031da2edf5791fbda7b62 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark