From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9287BC433EF for ; Tue, 28 Jun 2022 10:31:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344898AbiF1Kbf (ORCPT ); Tue, 28 Jun 2022 06:31:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344894AbiF1Kbd (ORCPT ); Tue, 28 Jun 2022 06:31:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF66C2F3B4; Tue, 28 Jun 2022 03:31:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7D7AB618EC; Tue, 28 Jun 2022 10:31:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D279C341CA; Tue, 28 Jun 2022 10:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656412291; bh=DC3SosWVleDuC54lFe3RBAgCx3NcMzRvnRRfzT1qGeQ=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=I/SdXgOHd3IxZuzYEpEWShovO3gHPUUR4oa9GuFrk1qd7XHI7VOQZDGMxJBHAaFNU 9pAczmA6K8YTtGecVZznCtWHsr+x1Bo9Bp4y95Q+trG7mgRkiijbpTvIENLSLkSRin oTeiuj+3TULfsgp8qa9tE+wz4fWVihEGKreZ+QGcA8IHtT8T0JUMNA1Lf7OMzLZKx4 XljrYYsOPapZxG5KgWjb+LHiCCyhzjbnIWqc4xCFRnquCPkApxDE9sF25dN04m6Ray UbJHiLWScWPddkBQFt6q9VnVJe2yOfQKkOQYaj0thZuZ8VrlU11XDs2jfseUCtZo3B 8mVv8c3Qxln5g== From: Mark Brown To: chanho61.park@samsung.com, krzysztof.kozlowski@linaro.org, andi@etezian.org Cc: alim.akhtar@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org, adithya.kv@samsung.com In-Reply-To: <20220627013845.138350-1-chanho61.park@samsung.com> References: <20220627013845.138350-1-chanho61.park@samsung.com> Subject: Re: [PATCH] spi: s3c64xx: move dma_release_channel to unprepare Message-Id: <165641229004.254742.10031368402707043673.b4-ty@kernel.org> Date: Tue, 28 Jun 2022 11:31:30 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Mon, 27 Jun 2022 10:38:45 +0900, Chanho Park wrote: > This fixes the sequence of dma_release_channel. > Since commit f52b03c70744 ("spi: s3c64xx: requests spi-dma channel only > during data transfer"), > dma_release_channel has been located in the s3c64xx_spi_transfer_one > but this makes invalid return of can_dma callback. > __spi_unmap_msg will check whether the request is requested by dma or > not via can_dma callback. When it is calling to check it, the channels > will be already released at the end of s3c64xx_spi_transfer_one so the > callback function will return always "false". So, they can't be unmapped > from __spi_unmap_msg call. To fix this, we need to add > unprepare_transfer_hardware callback and move the dma_release_channel > from s3c64xx_spi_transfer_one to there. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: s3c64xx: move dma_release_channel to unprepare commit: 82295bc0d192d7e35e0568b18ca66da2c3058fd5 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B24C4C43334 for ; Tue, 28 Jun 2022 10:32:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Date:Message-Id:Subject: References:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LCzDCUngG71WZfiKLxBwznej/MYCste9l491FvsAaxM=; b=xUhfIOIPC8ttSF epiricSJzniis+AfddtaqN8pSlQvUCsBK0ygpqnUZt0EUAMBDVSxQHBnEB8OcB45ke6XFirkaWj9m pJKH91JWrpxgsj0ld/gr4ogJokRsPkkXMtD8zlfWvUN1akN++XHYW9ULcxOi1dJQC1WqO1YmcqxCf vp37+c2ZkL1PcZgYaq0VdCUgrrznwg7+T8FOSsn4EpAmSj6lsUo8Eu6ZuFHnFKDHuSsOppggNU79E qbVGFDbraYCJnELjjIZZceiJpfPPbnZ42kuIreGkbluBuM3klteoSPVD2zD/gFHOk1iMeHUDNG9q/ lZTE33HF1mYcqnlF/iBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o68VO-005huv-2q; Tue, 28 Jun 2022 10:31:38 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o68VK-005htE-L0 for linux-arm-kernel@lists.infradead.org; Tue, 28 Jun 2022 10:31:36 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0DE75B81DCE; Tue, 28 Jun 2022 10:31:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D279C341CA; Tue, 28 Jun 2022 10:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656412291; bh=DC3SosWVleDuC54lFe3RBAgCx3NcMzRvnRRfzT1qGeQ=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=I/SdXgOHd3IxZuzYEpEWShovO3gHPUUR4oa9GuFrk1qd7XHI7VOQZDGMxJBHAaFNU 9pAczmA6K8YTtGecVZznCtWHsr+x1Bo9Bp4y95Q+trG7mgRkiijbpTvIENLSLkSRin oTeiuj+3TULfsgp8qa9tE+wz4fWVihEGKreZ+QGcA8IHtT8T0JUMNA1Lf7OMzLZKx4 XljrYYsOPapZxG5KgWjb+LHiCCyhzjbnIWqc4xCFRnquCPkApxDE9sF25dN04m6Ray UbJHiLWScWPddkBQFt6q9VnVJe2yOfQKkOQYaj0thZuZ8VrlU11XDs2jfseUCtZo3B 8mVv8c3Qxln5g== From: Mark Brown To: chanho61.park@samsung.com, krzysztof.kozlowski@linaro.org, andi@etezian.org Cc: alim.akhtar@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org, adithya.kv@samsung.com In-Reply-To: <20220627013845.138350-1-chanho61.park@samsung.com> References: <20220627013845.138350-1-chanho61.park@samsung.com> Subject: Re: [PATCH] spi: s3c64xx: move dma_release_channel to unprepare Message-Id: <165641229004.254742.10031368402707043673.b4-ty@kernel.org> Date: Tue, 28 Jun 2022 11:31:30 +0100 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_033134_882045_A4CCBB8F X-CRM114-Status: GOOD ( 17.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 27 Jun 2022 10:38:45 +0900, Chanho Park wrote: > This fixes the sequence of dma_release_channel. > Since commit f52b03c70744 ("spi: s3c64xx: requests spi-dma channel only > during data transfer"), > dma_release_channel has been located in the s3c64xx_spi_transfer_one > but this makes invalid return of can_dma callback. > __spi_unmap_msg will check whether the request is requested by dma or > not via can_dma callback. When it is calling to check it, the channels > will be already released at the end of s3c64xx_spi_transfer_one so the > callback function will return always "false". So, they can't be unmapped > from __spi_unmap_msg call. To fix this, we need to add > unprepare_transfer_hardware callback and move the dma_release_channel > from s3c64xx_spi_transfer_one to there. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: s3c64xx: move dma_release_channel to unprepare commit: 82295bc0d192d7e35e0568b18ca66da2c3058fd5 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel